You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/07/01 17:36:18 UTC

[GitHub] [incubator-pinot] mcvsubbu opened a new pull request #5645: Fix ORC Record reader to ignore extra fields

mcvsubbu opened a new pull request #5645:
URL: https://github.com/apache/incubator-pinot/pull/5645


   Fixing an issue introduced in PR #5267
   We should not be validating the type of fields that we don't care about.
   Cleaned up the messages and exceptions thrown so that we know which
   field is the problematic one.
   
   ## Description
   Add a description of your PR here.
   A good description should include pointers to an issue or design document, etc.
   ## Upgrade Notes
   Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
   * [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
   
   Does this PR fix a zero-downtime upgrade introduced earlier?
   * [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
   
   Does this PR otherwise need attention when creating release notes? Things to consider:
   - New configuration options
   - Deprecation of configurations
   - Signature changes to public methods/interfaces
   - New plugins added or old plugins removed
   * [ ] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes)
   ## Release Notes
   If you have tagged this as either backward-incompat or release-notes,
   you MUST add text here that you would like to see appear in release notes of the
   next release.
   
   If you have a series of commits adding or enabling a feature, then
   add this section only in final commit that marks the feature completed.
   Refer to earlier release notes to see examples of text
   
   ## Documentation
   If you have introduced a new feature or configuration, please add it to the documentation as well.
   See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5645: Fix ORC Record reader to ignore extra fields

Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on a change in pull request #5645:
URL: https://github.com/apache/incubator-pinot/pull/5645#discussion_r448521328



##########
File path: pinot-plugins/pinot-input-format/pinot-orc/src/main/java/org/apache/pinot/plugin/inputformat/orc/ORCRecordReader.java
##########
@@ -324,7 +324,7 @@ private static Object extractSingleValue(ColumnVector columnVector, int rowId, T
         }
       default:
         // Unsupported types
-        throw new IllegalStateException("Unsupported field type: " + category);
+        throw new IllegalStateException("Unsupported field type: " + category + " for field " + field);

Review comment:
       (nit)
   ```suggestion
           throw new IllegalStateException("Unsupported field type: " + category + " for field: " + field);
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] mcvsubbu merged pull request #5645: Fix ORC Record reader to ignore extra fields

Posted by GitBox <gi...@apache.org>.
mcvsubbu merged pull request #5645:
URL: https://github.com/apache/incubator-pinot/pull/5645


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org