[incubator-plc4x] branch master updated: added TODO for serial protocol

[sr...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

sruehl pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-plc4x.git


The following commit(s) were added to refs/heads/master by this push:
     new b80028e  added TODO for serial protocol
b80028e is described below

commit b80028e69ca9fa172357a2f8380f8ec8c398cf47
Author: Sebastian Rühl <sr...@apache.org>
AuthorDate: Thu Mar 22 10:15:51 2018 +0100

    added TODO for serial protocol
---
 .../java/org/apache/plc4x/java/ads/protocol/Payload2SerialProtocol.java | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/protocol/Payload2SerialProtocol.java b/plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/protocol/Payload2SerialProtocol.java
index 7234f37..66ad189 100644
--- a/plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/protocol/Payload2SerialProtocol.java
+++ b/plc4j/protocols/ads/src/main/java/org/apache/plc4x/java/ads/protocol/Payload2SerialProtocol.java
@@ -73,6 +73,8 @@ public class Payload2SerialProtocol extends MessageToMessageCodec<ByteBuf, ByteB
                 channelFuture.addListener((ChannelFutureListener) future -> {
                     // TODO: we might wait for the ack-frame to be transmitted before we forward the package
                 });
+                // TODO: check if this await is right as this might be against the concept of netty
+                channelFuture.await();
                 out.add(userData.getByteBuf());
                 break;
             case AmsSerialAcknowledgeFrame.ID:

-- 
To stop receiving notification emails like this one, please contact
sruehl@apache.org.