You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/03 23:19:49 UTC
[GitHub] [flink] tweise opened a new pull request #11006:
[FLINK-15868][kinesis] Resolve version conflict between jackson-core and
jackson-dataformat-cbor
tweise opened a new pull request #11006: [FLINK-15868][kinesis] Resolve version conflict between jackson-core and jackson-dataformat-cbor
URL: https://github.com/apache/flink/pull/11006
## What is the purpose of the change
For the Kinesis consumer to work, `jackson-core` and `jackson-dataformat-cbor` need to be at the same version. This change will ensure that users get the same version w/o having to override the `jackson-dataformat-cbor` dependency.
## Verifying this change
Run `mvn dependency:tree` on a downstream project and check that versions are same. Was also tested with the 1.10 RC1 with one of our internal deployments.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11006:
[FLINK-15868][kinesis] Resolve version conflict between jackson-core and
jackson-dataformat-cbor
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11006: [FLINK-15868][kinesis] Resolve version conflict between jackson-core and jackson-dataformat-cbor
URL: https://github.com/apache/flink/pull/11006#issuecomment-581673930
<!--
Meta data
Hash:af2a640e770f0fff302ec8d3b8920895a3f40bfb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147296723 TriggerType:PUSH TriggerID:af2a640e770f0fff302ec8d3b8920895a3f40bfb
Hash:af2a640e770f0fff302ec8d3b8920895a3f40bfb Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4801 TriggerType:PUSH TriggerID:af2a640e770f0fff302ec8d3b8920895a3f40bfb
Hash:6ab5029ed1264709672e813440d233558a7c6d8c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147414268 TriggerType:PUSH TriggerID:6ab5029ed1264709672e813440d233558a7c6d8c
Hash:6ab5029ed1264709672e813440d233558a7c6d8c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4840 TriggerType:PUSH TriggerID:6ab5029ed1264709672e813440d233558a7c6d8c
Hash:f79154debfe89f8226803d2b7ffedd88050728fa Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:f79154debfe89f8226803d2b7ffedd88050728fa
-->
## CI report:
* af2a640e770f0fff302ec8d3b8920895a3f40bfb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147296723) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4801)
* 6ab5029ed1264709672e813440d233558a7c6d8c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147414268) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4840)
* f79154debfe89f8226803d2b7ffedd88050728fa UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11006:
[FLINK-15868][kinesis] Resolve version conflict between jackson-core and
jackson-dataformat-cbor
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11006: [FLINK-15868][kinesis] Resolve version conflict between jackson-core and jackson-dataformat-cbor
URL: https://github.com/apache/flink/pull/11006#issuecomment-581673930
<!--
Meta data
Hash:af2a640e770f0fff302ec8d3b8920895a3f40bfb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147296723 TriggerType:PUSH TriggerID:af2a640e770f0fff302ec8d3b8920895a3f40bfb
Hash:af2a640e770f0fff302ec8d3b8920895a3f40bfb Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4801 TriggerType:PUSH TriggerID:af2a640e770f0fff302ec8d3b8920895a3f40bfb
Hash:6ab5029ed1264709672e813440d233558a7c6d8c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147414268 TriggerType:PUSH TriggerID:6ab5029ed1264709672e813440d233558a7c6d8c
Hash:6ab5029ed1264709672e813440d233558a7c6d8c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4840 TriggerType:PUSH TriggerID:6ab5029ed1264709672e813440d233558a7c6d8c
Hash:f79154debfe89f8226803d2b7ffedd88050728fa Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147425762 TriggerType:PUSH TriggerID:f79154debfe89f8226803d2b7ffedd88050728fa
Hash:f79154debfe89f8226803d2b7ffedd88050728fa Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4842 TriggerType:PUSH TriggerID:f79154debfe89f8226803d2b7ffedd88050728fa
Hash:6c424da718479b60dbbe5ba7243399b509e237f6 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147430035 TriggerType:PUSH TriggerID:6c424da718479b60dbbe5ba7243399b509e237f6
Hash:6c424da718479b60dbbe5ba7243399b509e237f6 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4844 TriggerType:PUSH TriggerID:6c424da718479b60dbbe5ba7243399b509e237f6
Hash:7e5471a154002dfe0a1d99ac120ef61dcf895bda Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4855 TriggerType:PUSH TriggerID:7e5471a154002dfe0a1d99ac120ef61dcf895bda
Hash:7e5471a154002dfe0a1d99ac120ef61dcf895bda Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147523042 TriggerType:PUSH TriggerID:7e5471a154002dfe0a1d99ac120ef61dcf895bda
-->
## CI report:
* af2a640e770f0fff302ec8d3b8920895a3f40bfb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147296723) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4801)
* 6ab5029ed1264709672e813440d233558a7c6d8c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147414268) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4840)
* f79154debfe89f8226803d2b7ffedd88050728fa Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147425762) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4842)
* 6c424da718479b60dbbe5ba7243399b509e237f6 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147430035) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4844)
* 7e5471a154002dfe0a1d99ac120ef61dcf895bda Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147523042) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4855)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #11006:
[FLINK-15868][kinesis] Resolve version conflict between jackson-core and
jackson-dataformat-cbor
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11006: [FLINK-15868][kinesis] Resolve version conflict between jackson-core and jackson-dataformat-cbor
URL: https://github.com/apache/flink/pull/11006#discussion_r374641750
##########
File path: pom.xml
##########
@@ -390,19 +390,26 @@ under the License.
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
- <version>2.10.1</version>
+ <version>${jackson.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
- <version>2.10.1</version>
+ <version>${jackson.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
- <version>2.10.1</version>
+ <version>${jackson.version}</version>
+ </dependency>
+
+ <!-- https://issues.apache.org/jira/browse/FLINK-15868 -->
+ <dependency>
+ <groupId>com.fasterxml.jackson.dataformat</groupId>
+ <artifactId>jackson-dataformat-cbor</artifactId>
Review comment:
I would only put this into the kinesis connector pom. This is the only module that should be affected by virtue of promoting transitive dependencies via the shade-plugin.
This promotion should likely be removed in the future because it has rather subtle side-effects.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tweise commented on issue #11006: [FLINK-15868][kinesis]
Resolve version conflict between jackson-core and jackson-dataformat-cbor
Posted by GitBox <gi...@apache.org>.
tweise commented on issue #11006: [FLINK-15868][kinesis] Resolve version conflict between jackson-core and jackson-dataformat-cbor
URL: https://github.com/apache/flink/pull/11006#issuecomment-582101154
LGTM for the additional changes (I cannot approve the PR I opened)
@tillrohrmann thanks for taking care of the updates for the ES modules. We are not using these connectors in our applications, so I have no means to do additional verification. I think it is important to keep the jackson modules on the same version, however. Glad to see this is happening now vs. just patching up the Kinesis connector.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11006:
[FLINK-15868][kinesis] Resolve version conflict between jackson-core and
jackson-dataformat-cbor
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11006: [FLINK-15868][kinesis] Resolve version conflict between jackson-core and jackson-dataformat-cbor
URL: https://github.com/apache/flink/pull/11006#issuecomment-581673930
<!--
Meta data
Hash:af2a640e770f0fff302ec8d3b8920895a3f40bfb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147296723 TriggerType:PUSH TriggerID:af2a640e770f0fff302ec8d3b8920895a3f40bfb
Hash:af2a640e770f0fff302ec8d3b8920895a3f40bfb Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4801 TriggerType:PUSH TriggerID:af2a640e770f0fff302ec8d3b8920895a3f40bfb
Hash:6ab5029ed1264709672e813440d233558a7c6d8c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147414268 TriggerType:PUSH TriggerID:6ab5029ed1264709672e813440d233558a7c6d8c
Hash:6ab5029ed1264709672e813440d233558a7c6d8c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4840 TriggerType:PUSH TriggerID:6ab5029ed1264709672e813440d233558a7c6d8c
Hash:f79154debfe89f8226803d2b7ffedd88050728fa Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147425762 TriggerType:PUSH TriggerID:f79154debfe89f8226803d2b7ffedd88050728fa
Hash:f79154debfe89f8226803d2b7ffedd88050728fa Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4842 TriggerType:PUSH TriggerID:f79154debfe89f8226803d2b7ffedd88050728fa
Hash:6c424da718479b60dbbe5ba7243399b509e237f6 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147430035 TriggerType:PUSH TriggerID:6c424da718479b60dbbe5ba7243399b509e237f6
Hash:6c424da718479b60dbbe5ba7243399b509e237f6 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4844 TriggerType:PUSH TriggerID:6c424da718479b60dbbe5ba7243399b509e237f6
Hash:7e5471a154002dfe0a1d99ac120ef61dcf895bda Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:7e5471a154002dfe0a1d99ac120ef61dcf895bda
-->
## CI report:
* af2a640e770f0fff302ec8d3b8920895a3f40bfb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147296723) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4801)
* 6ab5029ed1264709672e813440d233558a7c6d8c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147414268) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4840)
* f79154debfe89f8226803d2b7ffedd88050728fa Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147425762) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4842)
* 6c424da718479b60dbbe5ba7243399b509e237f6 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147430035) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4844)
* 7e5471a154002dfe0a1d99ac120ef61dcf895bda UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on issue #11006:
[FLINK-15868][kinesis] Resolve version conflict between jackson-core and
jackson-dataformat-cbor
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on issue #11006: [FLINK-15868][kinesis] Resolve version conflict between jackson-core and jackson-dataformat-cbor
URL: https://github.com/apache/flink/pull/11006#issuecomment-582013455
I've updated the PR and additionally removed the pinning of Jackson dependencies to `2.9.6` from `flink-table-planner`. Let's hope that everything still runs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #11006:
[FLINK-15868][kinesis] Resolve version conflict between jackson-core and
jackson-dataformat-cbor
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11006: [FLINK-15868][kinesis] Resolve version conflict between jackson-core and jackson-dataformat-cbor
URL: https://github.com/apache/flink/pull/11006#discussion_r375241377
##########
File path: pom.xml
##########
@@ -390,19 +390,26 @@ under the License.
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
- <version>2.10.1</version>
+ <version>${jackson.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
- <version>2.10.1</version>
+ <version>${jackson.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
- <version>2.10.1</version>
+ <version>${jackson.version}</version>
+ </dependency>
+
+ <!-- https://issues.apache.org/jira/browse/FLINK-15868 -->
+ <dependency>
+ <groupId>com.fasterxml.jackson.dataformat</groupId>
+ <artifactId>jackson-dataformat-cbor</artifactId>
Review comment:
> Looks like there is consensus to keep it centralized
Not quite; this came up during the offline discussion and we continued with the existing approach for the time-being for simplicity. Long-term we're likely to throw a jackson bom into every module that needs it, and ban older versions.
This way it is a lot easier to tell which modules are affected by the, if a new jackson dependency is added 1 of three cases happen:
a) dependency convergence fails (happens if it is not shaded)
b) enforcer check fails (old insecure versions used that we don't want)
c) a safe version is used and shaded (hence no conflicts), in which case there is no reason to mandate another version. This also allows us to use the version that the transitive dependency was built against, which is one less uncertainty on our side.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11006:
[FLINK-15868][kinesis] Resolve version conflict between jackson-core and
jackson-dataformat-cbor
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11006: [FLINK-15868][kinesis] Resolve version conflict between jackson-core and jackson-dataformat-cbor
URL: https://github.com/apache/flink/pull/11006#issuecomment-581673930
<!--
Meta data
Hash:af2a640e770f0fff302ec8d3b8920895a3f40bfb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147296723 TriggerType:PUSH TriggerID:af2a640e770f0fff302ec8d3b8920895a3f40bfb
Hash:af2a640e770f0fff302ec8d3b8920895a3f40bfb Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4801 TriggerType:PUSH TriggerID:af2a640e770f0fff302ec8d3b8920895a3f40bfb
Hash:6ab5029ed1264709672e813440d233558a7c6d8c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147414268 TriggerType:PUSH TriggerID:6ab5029ed1264709672e813440d233558a7c6d8c
Hash:6ab5029ed1264709672e813440d233558a7c6d8c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4840 TriggerType:PUSH TriggerID:6ab5029ed1264709672e813440d233558a7c6d8c
Hash:f79154debfe89f8226803d2b7ffedd88050728fa Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147425762 TriggerType:PUSH TriggerID:f79154debfe89f8226803d2b7ffedd88050728fa
Hash:f79154debfe89f8226803d2b7ffedd88050728fa Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4842 TriggerType:PUSH TriggerID:f79154debfe89f8226803d2b7ffedd88050728fa
Hash:6c424da718479b60dbbe5ba7243399b509e237f6 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:6c424da718479b60dbbe5ba7243399b509e237f6
-->
## CI report:
* af2a640e770f0fff302ec8d3b8920895a3f40bfb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147296723) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4801)
* 6ab5029ed1264709672e813440d233558a7c6d8c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147414268) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4840)
* f79154debfe89f8226803d2b7ffedd88050728fa Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147425762) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4842)
* 6c424da718479b60dbbe5ba7243399b509e237f6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11006:
[FLINK-15868][kinesis] Resolve version conflict between jackson-core and
jackson-dataformat-cbor
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11006: [FLINK-15868][kinesis] Resolve version conflict between jackson-core and jackson-dataformat-cbor
URL: https://github.com/apache/flink/pull/11006#issuecomment-581673930
<!--
Meta data
Hash:af2a640e770f0fff302ec8d3b8920895a3f40bfb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147296723 TriggerType:PUSH TriggerID:af2a640e770f0fff302ec8d3b8920895a3f40bfb
Hash:af2a640e770f0fff302ec8d3b8920895a3f40bfb Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4801 TriggerType:PUSH TriggerID:af2a640e770f0fff302ec8d3b8920895a3f40bfb
-->
## CI report:
* af2a640e770f0fff302ec8d3b8920895a3f40bfb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147296723) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4801)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #11006:
[FLINK-15868][kinesis] Resolve version conflict between jackson-core and
jackson-dataformat-cbor
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11006: [FLINK-15868][kinesis] Resolve version conflict between jackson-core and jackson-dataformat-cbor
URL: https://github.com/apache/flink/pull/11006#discussion_r374769188
##########
File path: flink-connectors/flink-connector-elasticsearch-base/src/test/java/org/apache/flink/streaming/connectors/elasticsearch/testutils/SourceSinkDataTestKit.java
##########
@@ -66,28 +70,47 @@ public void cancel() {
}
}
- /**
- * A {@link ElasticsearchSinkFunction} that indexes each element it receives to a specified Elasticsearch index.
- */
- public static class TestElasticsearchSinkFunction implements ElasticsearchSinkFunction<Tuple2<Integer, String>> {
+ public static ElasticsearchSinkFunction<Tuple2<Integer, String>> getCborSinkFunction(String index) {
+ return new TestElasticsearchSinkFunction(index, XContentFactory::cborBuilder);
+ }
+
+ public static ElasticsearchSinkFunction<Tuple2<Integer, String>> getJsonSinkFunction(String index) {
+ return new TestElasticsearchSinkFunction(index, XContentFactory::jsonBuilder);
+ }
+
+ public static ElasticsearchSinkFunction<Tuple2<Integer, String>> getSmileSinkFunction(String index) {
+ return new TestElasticsearchSinkFunction(index, XContentFactory::smileBuilder);
+ }
+
+ public static ElasticsearchSinkFunction<Tuple2<Integer, String>> getYamlSinkFunction(String index) {
+ return new TestElasticsearchSinkFunction(index, XContentFactory::yamlBuilder);
+ }
+
+ private static class TestElasticsearchSinkFunction implements ElasticsearchSinkFunction<Tuple2<Integer, String>> {
private static final long serialVersionUID = 1L;
private final String index;
+ private XContentBuilderProvider contentBuilderProvider;
Review comment:
my bad, this one should be final
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11006:
[FLINK-15868][kinesis] Resolve version conflict between jackson-core and
jackson-dataformat-cbor
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11006: [FLINK-15868][kinesis] Resolve version conflict between jackson-core and jackson-dataformat-cbor
URL: https://github.com/apache/flink/pull/11006#issuecomment-581673930
<!--
Meta data
Hash:af2a640e770f0fff302ec8d3b8920895a3f40bfb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147296723 TriggerType:PUSH TriggerID:af2a640e770f0fff302ec8d3b8920895a3f40bfb
Hash:af2a640e770f0fff302ec8d3b8920895a3f40bfb Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4801 TriggerType:PUSH TriggerID:af2a640e770f0fff302ec8d3b8920895a3f40bfb
Hash:6ab5029ed1264709672e813440d233558a7c6d8c Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147414268 TriggerType:PUSH TriggerID:6ab5029ed1264709672e813440d233558a7c6d8c
Hash:6ab5029ed1264709672e813440d233558a7c6d8c Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4840 TriggerType:PUSH TriggerID:6ab5029ed1264709672e813440d233558a7c6d8c
-->
## CI report:
* af2a640e770f0fff302ec8d3b8920895a3f40bfb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147296723) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4801)
* 6ab5029ed1264709672e813440d233558a7c6d8c Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147414268) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4840)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann closed pull request #11006:
[FLINK-15868][kinesis] Resolve version conflict between jackson-core and
jackson-dataformat-cbor
Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #11006: [FLINK-15868][kinesis] Resolve version conflict between jackson-core and jackson-dataformat-cbor
URL: https://github.com/apache/flink/pull/11006
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11006:
[FLINK-15868][kinesis] Resolve version conflict between jackson-core and
jackson-dataformat-cbor
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11006: [FLINK-15868][kinesis] Resolve version conflict between jackson-core and jackson-dataformat-cbor
URL: https://github.com/apache/flink/pull/11006#issuecomment-581673930
<!--
Meta data
Hash:af2a640e770f0fff302ec8d3b8920895a3f40bfb Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147296723 TriggerType:PUSH TriggerID:af2a640e770f0fff302ec8d3b8920895a3f40bfb
Hash:af2a640e770f0fff302ec8d3b8920895a3f40bfb Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4801 TriggerType:PUSH TriggerID:af2a640e770f0fff302ec8d3b8920895a3f40bfb
-->
## CI report:
* af2a640e770f0fff302ec8d3b8920895a3f40bfb Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147296723) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4801)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #11006:
[FLINK-15868][kinesis] Resolve version conflict between jackson-core and
jackson-dataformat-cbor
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #11006: [FLINK-15868][kinesis] Resolve version conflict between jackson-core and jackson-dataformat-cbor
URL: https://github.com/apache/flink/pull/11006#discussion_r374556295
##########
File path: pom.xml
##########
@@ -390,19 +390,26 @@ under the License.
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
- <version>2.10.1</version>
+ <version>${jackson.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
- <version>2.10.1</version>
+ <version>${jackson.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
- <version>2.10.1</version>
+ <version>${jackson.version}</version>
+ </dependency>
+
+ <!-- https://issues.apache.org/jira/browse/FLINK-15868 -->
+ <dependency>
+ <groupId>com.fasterxml.jackson.dataformat</groupId>
+ <artifactId>jackson-dataformat-cbor</artifactId>
+ <version>${jackson.version}</version>
</dependency>
Review comment:
Do we really want to change the `jackson-dataformat-cbor` for all dependencies which rely on it? It would invalidate the testing for all these components.
On the other hand I guess that the functionality used by Kinesis should then also be broken for all the other modules.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11006: [FLINK-15868][kinesis]
Resolve version conflict between jackson-core and jackson-dataformat-cbor
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11006: [FLINK-15868][kinesis] Resolve version conflict between jackson-core and jackson-dataformat-cbor
URL: https://github.com/apache/flink/pull/11006#issuecomment-581667506
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit af2a640e770f0fff302ec8d3b8920895a3f40bfb (Mon Feb 03 23:21:52 UTC 2020)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #11006:
[FLINK-15868][kinesis] Resolve version conflict between jackson-core and
jackson-dataformat-cbor
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #11006: [FLINK-15868][kinesis] Resolve version conflict between jackson-core and jackson-dataformat-cbor
URL: https://github.com/apache/flink/pull/11006#discussion_r374788499
##########
File path: flink-connectors/flink-connector-elasticsearch-base/src/test/java/org/apache/flink/streaming/connectors/elasticsearch/testutils/SourceSinkDataTestKit.java
##########
@@ -66,28 +70,47 @@ public void cancel() {
}
}
- /**
- * A {@link ElasticsearchSinkFunction} that indexes each element it receives to a specified Elasticsearch index.
- */
- public static class TestElasticsearchSinkFunction implements ElasticsearchSinkFunction<Tuple2<Integer, String>> {
+ public static ElasticsearchSinkFunction<Tuple2<Integer, String>> getCborSinkFunction(String index) {
+ return new TestElasticsearchSinkFunction(index, XContentFactory::cborBuilder);
+ }
+
+ public static ElasticsearchSinkFunction<Tuple2<Integer, String>> getJsonSinkFunction(String index) {
+ return new TestElasticsearchSinkFunction(index, XContentFactory::jsonBuilder);
+ }
+
+ public static ElasticsearchSinkFunction<Tuple2<Integer, String>> getSmileSinkFunction(String index) {
+ return new TestElasticsearchSinkFunction(index, XContentFactory::smileBuilder);
+ }
+
+ public static ElasticsearchSinkFunction<Tuple2<Integer, String>> getYamlSinkFunction(String index) {
+ return new TestElasticsearchSinkFunction(index, XContentFactory::yamlBuilder);
+ }
+
+ private static class TestElasticsearchSinkFunction implements ElasticsearchSinkFunction<Tuple2<Integer, String>> {
private static final long serialVersionUID = 1L;
private final String index;
+ private XContentBuilderProvider contentBuilderProvider;
/**
* Create the sink function, specifying a target Elasticsearch index.
*
* @param index Name of the target Elasticsearch index.
*/
- public TestElasticsearchSinkFunction(String index) {
+ public TestElasticsearchSinkFunction(String index, XContentBuilderProvider contentBuilderProvider) {
this.index = index;
+ this.contentBuilderProvider = contentBuilderProvider;
}
public IndexRequest createIndexRequest(Tuple2<Integer, String> element) {
Map<String, Object> json = new HashMap<>();
json.put(DATA_FIELD_NAME, element.f1);
- return new IndexRequest(index, TYPE_NAME, element.f0.toString()).source(json);
+ try {
+ return new IndexRequest(index, TYPE_NAME, element.f0.toString()).source(contentBuilderProvider.getBuilder().map(json));
Review comment:
Ok I rename it into `document`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on a change in pull request #11006:
[FLINK-15868][kinesis] Resolve version conflict between jackson-core and
jackson-dataformat-cbor
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11006: [FLINK-15868][kinesis] Resolve version conflict between jackson-core and jackson-dataformat-cbor
URL: https://github.com/apache/flink/pull/11006#discussion_r375241377
##########
File path: pom.xml
##########
@@ -390,19 +390,26 @@ under the License.
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
- <version>2.10.1</version>
+ <version>${jackson.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
- <version>2.10.1</version>
+ <version>${jackson.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
- <version>2.10.1</version>
+ <version>${jackson.version}</version>
+ </dependency>
+
+ <!-- https://issues.apache.org/jira/browse/FLINK-15868 -->
+ <dependency>
+ <groupId>com.fasterxml.jackson.dataformat</groupId>
+ <artifactId>jackson-dataformat-cbor</artifactId>
Review comment:
> Looks like there is consensus to keep it centralized
Not quite; this came up during the offline discussion and we continued with the existing approach for the time-being for simplicity. Long-term we're likely to throw a jackson bom into every module that needs it, and ban older versions.
This way it is a lot easier to tell which modules are affected by the dependency management.
If a new jackson dependency is added 1 of three cases happen:
a) dependency convergence fails (happens if it is not shaded)
b) enforcer check fails (old insecure versions used that we don't want)
c) a safe version is used and shaded (hence no conflicts), in which case there is no reason to mandate another version. This also allows us to use the version that the transitive dependency was built against, which is one less uncertainty on our side.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11006:
[FLINK-15868][kinesis] Resolve version conflict between jackson-core and
jackson-dataformat-cbor
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11006: [FLINK-15868][kinesis] Resolve version conflict between jackson-core and jackson-dataformat-cbor
URL: https://github.com/apache/flink/pull/11006#issuecomment-581673930
<!--
Meta data
Hash:af2a640e770f0fff302ec8d3b8920895a3f40bfb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147296723 TriggerType:PUSH TriggerID:af2a640e770f0fff302ec8d3b8920895a3f40bfb
Hash:af2a640e770f0fff302ec8d3b8920895a3f40bfb Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4801 TriggerType:PUSH TriggerID:af2a640e770f0fff302ec8d3b8920895a3f40bfb
Hash:6ab5029ed1264709672e813440d233558a7c6d8c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147414268 TriggerType:PUSH TriggerID:6ab5029ed1264709672e813440d233558a7c6d8c
Hash:6ab5029ed1264709672e813440d233558a7c6d8c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4840 TriggerType:PUSH TriggerID:6ab5029ed1264709672e813440d233558a7c6d8c
Hash:f79154debfe89f8226803d2b7ffedd88050728fa Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147425762 TriggerType:PUSH TriggerID:f79154debfe89f8226803d2b7ffedd88050728fa
Hash:f79154debfe89f8226803d2b7ffedd88050728fa Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4842 TriggerType:PUSH TriggerID:f79154debfe89f8226803d2b7ffedd88050728fa
Hash:6c424da718479b60dbbe5ba7243399b509e237f6 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147430035 TriggerType:PUSH TriggerID:6c424da718479b60dbbe5ba7243399b509e237f6
Hash:6c424da718479b60dbbe5ba7243399b509e237f6 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4844 TriggerType:PUSH TriggerID:6c424da718479b60dbbe5ba7243399b509e237f6
Hash:7e5471a154002dfe0a1d99ac120ef61dcf895bda Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4855 TriggerType:PUSH TriggerID:7e5471a154002dfe0a1d99ac120ef61dcf895bda
Hash:7e5471a154002dfe0a1d99ac120ef61dcf895bda Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147523042 TriggerType:PUSH TriggerID:7e5471a154002dfe0a1d99ac120ef61dcf895bda
-->
## CI report:
* af2a640e770f0fff302ec8d3b8920895a3f40bfb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147296723) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4801)
* 6ab5029ed1264709672e813440d233558a7c6d8c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147414268) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4840)
* f79154debfe89f8226803d2b7ffedd88050728fa Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147425762) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4842)
* 6c424da718479b60dbbe5ba7243399b509e237f6 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147430035) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4844)
* 7e5471a154002dfe0a1d99ac120ef61dcf895bda Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147523042) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4855)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tweise commented on a change in pull request #11006:
[FLINK-15868][kinesis] Resolve version conflict between jackson-core and
jackson-dataformat-cbor
Posted by GitBox <gi...@apache.org>.
tweise commented on a change in pull request #11006: [FLINK-15868][kinesis] Resolve version conflict between jackson-core and jackson-dataformat-cbor
URL: https://github.com/apache/flink/pull/11006#discussion_r374902191
##########
File path: pom.xml
##########
@@ -390,19 +390,26 @@ under the License.
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
- <version>2.10.1</version>
+ <version>${jackson.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
- <version>2.10.1</version>
+ <version>${jackson.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
- <version>2.10.1</version>
+ <version>${jackson.version}</version>
+ </dependency>
+
+ <!-- https://issues.apache.org/jira/browse/FLINK-15868 -->
+ <dependency>
+ <groupId>com.fasterxml.jackson.dataformat</groupId>
+ <artifactId>jackson-dataformat-cbor</artifactId>
Review comment:
Looks like there is consensus to keep it centralized; I prefer that as well. This dependency isn't specific to Kinesis, it comes from `aws-java-sdk-core`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on issue #11006:
[FLINK-15868][kinesis] Resolve version conflict between jackson-core and
jackson-dataformat-cbor
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on issue #11006: [FLINK-15868][kinesis] Resolve version conflict between jackson-core and jackson-dataformat-cbor
URL: https://github.com/apache/flink/pull/11006#issuecomment-582029597
I had to pin `snakeyaml` to `1.25` to make `flink-connector-elasticsearch5` work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11006:
[FLINK-15868][kinesis] Resolve version conflict between jackson-core and
jackson-dataformat-cbor
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11006: [FLINK-15868][kinesis] Resolve version conflict between jackson-core and jackson-dataformat-cbor
URL: https://github.com/apache/flink/pull/11006#issuecomment-581673930
<!--
Meta data
Hash:af2a640e770f0fff302ec8d3b8920895a3f40bfb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147296723 TriggerType:PUSH TriggerID:af2a640e770f0fff302ec8d3b8920895a3f40bfb
Hash:af2a640e770f0fff302ec8d3b8920895a3f40bfb Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4801 TriggerType:PUSH TriggerID:af2a640e770f0fff302ec8d3b8920895a3f40bfb
Hash:6ab5029ed1264709672e813440d233558a7c6d8c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147414268 TriggerType:PUSH TriggerID:6ab5029ed1264709672e813440d233558a7c6d8c
Hash:6ab5029ed1264709672e813440d233558a7c6d8c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4840 TriggerType:PUSH TriggerID:6ab5029ed1264709672e813440d233558a7c6d8c
Hash:f79154debfe89f8226803d2b7ffedd88050728fa Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147425762 TriggerType:PUSH TriggerID:f79154debfe89f8226803d2b7ffedd88050728fa
Hash:f79154debfe89f8226803d2b7ffedd88050728fa Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4842 TriggerType:PUSH TriggerID:f79154debfe89f8226803d2b7ffedd88050728fa
Hash:6c424da718479b60dbbe5ba7243399b509e237f6 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147430035 TriggerType:PUSH TriggerID:6c424da718479b60dbbe5ba7243399b509e237f6
Hash:6c424da718479b60dbbe5ba7243399b509e237f6 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4844 TriggerType:PUSH TriggerID:6c424da718479b60dbbe5ba7243399b509e237f6
-->
## CI report:
* af2a640e770f0fff302ec8d3b8920895a3f40bfb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147296723) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4801)
* 6ab5029ed1264709672e813440d233558a7c6d8c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147414268) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4840)
* f79154debfe89f8226803d2b7ffedd88050728fa Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147425762) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4842)
* 6c424da718479b60dbbe5ba7243399b509e237f6 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147430035) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4844)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #11006:
[FLINK-15868][kinesis] Resolve version conflict between jackson-core and
jackson-dataformat-cbor
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #11006: [FLINK-15868][kinesis] Resolve version conflict between jackson-core and jackson-dataformat-cbor
URL: https://github.com/apache/flink/pull/11006#discussion_r374555701
##########
File path: pom.xml
##########
@@ -390,19 +390,26 @@ under the License.
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
- <version>2.10.1</version>
+ <version>${jackson.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
- <version>2.10.1</version>
+ <version>${jackson.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
- <version>2.10.1</version>
+ <version>${jackson.version}</version>
+ </dependency>
+
+ <!-- https://issues.apache.org/jira/browse/FLINK-15868 -->
+ <dependency>
+ <groupId>com.fasterxml.jackson.dataformat</groupId>
+ <artifactId>jackson-dataformat-cbor</artifactId>
+ <version>${jackson.version}</version>
</dependency>
Review comment:
This change requires the update of all affected `NOTICE` files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on issue #11006:
[FLINK-15868][kinesis] Resolve version conflict between jackson-core and
jackson-dataformat-cbor
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on issue #11006: [FLINK-15868][kinesis] Resolve version conflict between jackson-core and jackson-dataformat-cbor
URL: https://github.com/apache/flink/pull/11006#issuecomment-581968743
After an offline discussion with @zentol and @GJL we decided to bump the remaining Jackson dependencies to version `2.10.1`. The affected dependencies are `jackson-dataformat-smile`, `jackson-dataformat-yaml`, `jackson-module-jaxb-annotations`.
I will update the PR to reflect these changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #11006:
[FLINK-15868][kinesis] Resolve version conflict between jackson-core and
jackson-dataformat-cbor
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #11006: [FLINK-15868][kinesis] Resolve version conflict between jackson-core and jackson-dataformat-cbor
URL: https://github.com/apache/flink/pull/11006#discussion_r374557764
##########
File path: pom.xml
##########
@@ -390,19 +390,26 @@ under the License.
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
- <version>2.10.1</version>
+ <version>${jackson.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
- <version>2.10.1</version>
+ <version>${jackson.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
- <version>2.10.1</version>
+ <version>${jackson.version}</version>
+ </dependency>
+
+ <!-- https://issues.apache.org/jira/browse/FLINK-15868 -->
+ <dependency>
+ <groupId>com.fasterxml.jackson.dataformat</groupId>
+ <artifactId>jackson-dataformat-cbor</artifactId>
+ <version>${jackson.version}</version>
</dependency>
Review comment:
What about bumping other jackson dependencies such as `jackson-dataformat-smile`, `jackson-dataformat-yaml`, `jackson-module-jaxb-annotations`? Could they also be affected by the bumping the other dependencies to `2.10.1`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on a change in pull request #11006:
[FLINK-15868][kinesis] Resolve version conflict between jackson-core and
jackson-dataformat-cbor
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #11006: [FLINK-15868][kinesis] Resolve version conflict between jackson-core and jackson-dataformat-cbor
URL: https://github.com/apache/flink/pull/11006#discussion_r374779118
##########
File path: flink-connectors/flink-connector-elasticsearch-base/src/test/java/org/apache/flink/streaming/connectors/elasticsearch/testutils/SourceSinkDataTestKit.java
##########
@@ -66,28 +70,47 @@ public void cancel() {
}
}
- /**
- * A {@link ElasticsearchSinkFunction} that indexes each element it receives to a specified Elasticsearch index.
- */
- public static class TestElasticsearchSinkFunction implements ElasticsearchSinkFunction<Tuple2<Integer, String>> {
+ public static ElasticsearchSinkFunction<Tuple2<Integer, String>> getCborSinkFunction(String index) {
+ return new TestElasticsearchSinkFunction(index, XContentFactory::cborBuilder);
+ }
+
+ public static ElasticsearchSinkFunction<Tuple2<Integer, String>> getJsonSinkFunction(String index) {
+ return new TestElasticsearchSinkFunction(index, XContentFactory::jsonBuilder);
+ }
+
+ public static ElasticsearchSinkFunction<Tuple2<Integer, String>> getSmileSinkFunction(String index) {
+ return new TestElasticsearchSinkFunction(index, XContentFactory::smileBuilder);
+ }
+
+ public static ElasticsearchSinkFunction<Tuple2<Integer, String>> getYamlSinkFunction(String index) {
+ return new TestElasticsearchSinkFunction(index, XContentFactory::yamlBuilder);
+ }
+
+ private static class TestElasticsearchSinkFunction implements ElasticsearchSinkFunction<Tuple2<Integer, String>> {
private static final long serialVersionUID = 1L;
private final String index;
+ private XContentBuilderProvider contentBuilderProvider;
Review comment:
Will update the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11006: [FLINK-15868][kinesis]
Resolve version conflict between jackson-core and jackson-dataformat-cbor
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11006: [FLINK-15868][kinesis] Resolve version conflict between jackson-core and jackson-dataformat-cbor
URL: https://github.com/apache/flink/pull/11006#issuecomment-581673930
<!--
Meta data
Hash:af2a640e770f0fff302ec8d3b8920895a3f40bfb Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:af2a640e770f0fff302ec8d3b8920895a3f40bfb
-->
## CI report:
* af2a640e770f0fff302ec8d3b8920895a3f40bfb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11006:
[FLINK-15868][kinesis] Resolve version conflict between jackson-core and
jackson-dataformat-cbor
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11006: [FLINK-15868][kinesis] Resolve version conflict between jackson-core and jackson-dataformat-cbor
URL: https://github.com/apache/flink/pull/11006#issuecomment-581673930
<!--
Meta data
Hash:af2a640e770f0fff302ec8d3b8920895a3f40bfb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147296723 TriggerType:PUSH TriggerID:af2a640e770f0fff302ec8d3b8920895a3f40bfb
Hash:af2a640e770f0fff302ec8d3b8920895a3f40bfb Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4801 TriggerType:PUSH TriggerID:af2a640e770f0fff302ec8d3b8920895a3f40bfb
Hash:6ab5029ed1264709672e813440d233558a7c6d8c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147414268 TriggerType:PUSH TriggerID:6ab5029ed1264709672e813440d233558a7c6d8c
Hash:6ab5029ed1264709672e813440d233558a7c6d8c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4840 TriggerType:PUSH TriggerID:6ab5029ed1264709672e813440d233558a7c6d8c
Hash:f79154debfe89f8226803d2b7ffedd88050728fa Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147425762 TriggerType:PUSH TriggerID:f79154debfe89f8226803d2b7ffedd88050728fa
Hash:f79154debfe89f8226803d2b7ffedd88050728fa Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4842 TriggerType:PUSH TriggerID:f79154debfe89f8226803d2b7ffedd88050728fa
Hash:6c424da718479b60dbbe5ba7243399b509e237f6 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147430035 TriggerType:PUSH TriggerID:6c424da718479b60dbbe5ba7243399b509e237f6
Hash:6c424da718479b60dbbe5ba7243399b509e237f6 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4844 TriggerType:PUSH TriggerID:6c424da718479b60dbbe5ba7243399b509e237f6
-->
## CI report:
* af2a640e770f0fff302ec8d3b8920895a3f40bfb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147296723) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4801)
* 6ab5029ed1264709672e813440d233558a7c6d8c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147414268) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4840)
* f79154debfe89f8226803d2b7ffedd88050728fa Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147425762) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4842)
* 6c424da718479b60dbbe5ba7243399b509e237f6 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147430035) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4844)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on issue #11006:
[FLINK-15868][kinesis] Resolve version conflict between jackson-core and
jackson-dataformat-cbor
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on issue #11006: [FLINK-15868][kinesis] Resolve version conflict between jackson-core and jackson-dataformat-cbor
URL: https://github.com/apache/flink/pull/11006#issuecomment-581975944
We actually don't need to pin `jackson-module-jaxb-annotations` because we don't use it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11006:
[FLINK-15868][kinesis] Resolve version conflict between jackson-core and
jackson-dataformat-cbor
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11006: [FLINK-15868][kinesis] Resolve version conflict between jackson-core and jackson-dataformat-cbor
URL: https://github.com/apache/flink/pull/11006#issuecomment-581673930
<!--
Meta data
Hash:af2a640e770f0fff302ec8d3b8920895a3f40bfb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147296723 TriggerType:PUSH TriggerID:af2a640e770f0fff302ec8d3b8920895a3f40bfb
Hash:af2a640e770f0fff302ec8d3b8920895a3f40bfb Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4801 TriggerType:PUSH TriggerID:af2a640e770f0fff302ec8d3b8920895a3f40bfb
Hash:6ab5029ed1264709672e813440d233558a7c6d8c Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147414268 TriggerType:PUSH TriggerID:6ab5029ed1264709672e813440d233558a7c6d8c
Hash:6ab5029ed1264709672e813440d233558a7c6d8c Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4840 TriggerType:PUSH TriggerID:6ab5029ed1264709672e813440d233558a7c6d8c
Hash:f79154debfe89f8226803d2b7ffedd88050728fa Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147425762 TriggerType:PUSH TriggerID:f79154debfe89f8226803d2b7ffedd88050728fa
Hash:f79154debfe89f8226803d2b7ffedd88050728fa Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4842 TriggerType:PUSH TriggerID:f79154debfe89f8226803d2b7ffedd88050728fa
Hash:6c424da718479b60dbbe5ba7243399b509e237f6 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147430035 TriggerType:PUSH TriggerID:6c424da718479b60dbbe5ba7243399b509e237f6
Hash:6c424da718479b60dbbe5ba7243399b509e237f6 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4844 TriggerType:PUSH TriggerID:6c424da718479b60dbbe5ba7243399b509e237f6
Hash:7e5471a154002dfe0a1d99ac120ef61dcf895bda Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4855 TriggerType:PUSH TriggerID:7e5471a154002dfe0a1d99ac120ef61dcf895bda
Hash:7e5471a154002dfe0a1d99ac120ef61dcf895bda Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147523042 TriggerType:PUSH TriggerID:7e5471a154002dfe0a1d99ac120ef61dcf895bda
-->
## CI report:
* af2a640e770f0fff302ec8d3b8920895a3f40bfb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147296723) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4801)
* 6ab5029ed1264709672e813440d233558a7c6d8c Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147414268) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4840)
* f79154debfe89f8226803d2b7ffedd88050728fa Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147425762) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4842)
* 6c424da718479b60dbbe5ba7243399b509e237f6 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147430035) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4844)
* 7e5471a154002dfe0a1d99ac120ef61dcf895bda Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147523042) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4855)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11006:
[FLINK-15868][kinesis] Resolve version conflict between jackson-core and
jackson-dataformat-cbor
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11006: [FLINK-15868][kinesis] Resolve version conflict between jackson-core and jackson-dataformat-cbor
URL: https://github.com/apache/flink/pull/11006#issuecomment-581673930
<!--
Meta data
Hash:af2a640e770f0fff302ec8d3b8920895a3f40bfb Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147296723 TriggerType:PUSH TriggerID:af2a640e770f0fff302ec8d3b8920895a3f40bfb
Hash:af2a640e770f0fff302ec8d3b8920895a3f40bfb Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4801 TriggerType:PUSH TriggerID:af2a640e770f0fff302ec8d3b8920895a3f40bfb
Hash:6ab5029ed1264709672e813440d233558a7c6d8c Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:6ab5029ed1264709672e813440d233558a7c6d8c
-->
## CI report:
* af2a640e770f0fff302ec8d3b8920895a3f40bfb Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147296723) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4801)
* 6ab5029ed1264709672e813440d233558a7c6d8c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on issue #11006:
[FLINK-15868][kinesis] Resolve version conflict between jackson-core and
jackson-dataformat-cbor
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on issue #11006: [FLINK-15868][kinesis] Resolve version conflict between jackson-core and jackson-dataformat-cbor
URL: https://github.com/apache/flink/pull/11006#issuecomment-581976852
@zentol @GJL, I've updated the PR. Please take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL commented on a change in pull request #11006:
[FLINK-15868][kinesis] Resolve version conflict between jackson-core and
jackson-dataformat-cbor
Posted by GitBox <gi...@apache.org>.
GJL commented on a change in pull request #11006: [FLINK-15868][kinesis] Resolve version conflict between jackson-core and jackson-dataformat-cbor
URL: https://github.com/apache/flink/pull/11006#discussion_r374779177
##########
File path: flink-connectors/flink-connector-elasticsearch-base/src/test/java/org/apache/flink/streaming/connectors/elasticsearch/testutils/SourceSinkDataTestKit.java
##########
@@ -66,28 +70,47 @@ public void cancel() {
}
}
- /**
- * A {@link ElasticsearchSinkFunction} that indexes each element it receives to a specified Elasticsearch index.
- */
- public static class TestElasticsearchSinkFunction implements ElasticsearchSinkFunction<Tuple2<Integer, String>> {
+ public static ElasticsearchSinkFunction<Tuple2<Integer, String>> getCborSinkFunction(String index) {
+ return new TestElasticsearchSinkFunction(index, XContentFactory::cborBuilder);
+ }
+
+ public static ElasticsearchSinkFunction<Tuple2<Integer, String>> getJsonSinkFunction(String index) {
+ return new TestElasticsearchSinkFunction(index, XContentFactory::jsonBuilder);
+ }
+
+ public static ElasticsearchSinkFunction<Tuple2<Integer, String>> getSmileSinkFunction(String index) {
+ return new TestElasticsearchSinkFunction(index, XContentFactory::smileBuilder);
+ }
+
+ public static ElasticsearchSinkFunction<Tuple2<Integer, String>> getYamlSinkFunction(String index) {
+ return new TestElasticsearchSinkFunction(index, XContentFactory::yamlBuilder);
+ }
+
+ private static class TestElasticsearchSinkFunction implements ElasticsearchSinkFunction<Tuple2<Integer, String>> {
private static final long serialVersionUID = 1L;
private final String index;
+ private XContentBuilderProvider contentBuilderProvider;
/**
* Create the sink function, specifying a target Elasticsearch index.
*
* @param index Name of the target Elasticsearch index.
*/
- public TestElasticsearchSinkFunction(String index) {
+ public TestElasticsearchSinkFunction(String index, XContentBuilderProvider contentBuilderProvider) {
this.index = index;
+ this.contentBuilderProvider = contentBuilderProvider;
}
public IndexRequest createIndexRequest(Tuple2<Integer, String> element) {
Map<String, Object> json = new HashMap<>();
json.put(DATA_FIELD_NAME, element.f1);
- return new IndexRequest(index, TYPE_NAME, element.f0.toString()).source(json);
+ try {
+ return new IndexRequest(index, TYPE_NAME, element.f0.toString()).source(contentBuilderProvider.getBuilder().map(json));
Review comment:
I don't think `json` is accurate here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services