You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Sailesh Mukil (Code Review)" <ge...@cloudera.org> on 2018/02/01 18:50:35 UTC
[Impala-ASF-CR] IMPALA-6219: Use AES-GCM for spill-to-disk encryption
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9032 )
Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption
......................................................................
Patch Set 12: Code-Review-2
Looks like there was a clang-tidy failure. Could you have a look at that Xianda?
https://jenkins.impala.io/job/clang-tidy-ub1604/630/artifact/tidylog.txt
It looks like a simple fix. Just grep for "warning:"
/home/ubuntu/Impala/be/src/util/openssl-util.h:135:58: warning: extra ';' after member function definition [clang-diagnostic-extra-semi]
bool IsGcmMode() const { return mode_ == AES_256_GCM; };
--
To view, visit http://gerrit.cloudera.org:8080/9032
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ea87b82a8897ee8bfa187715ac1c52883790d24
Gerrit-Change-Number: 9032
Gerrit-PatchSet: 12
Gerrit-Owner: Xianda Ke <ke...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xianda Ke <ke...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Feb 2018 18:50:35 +0000
Gerrit-HasComments: No