You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by na...@apache.org on 2014/04/03 08:07:46 UTC
[3/4] git commit: Remove incorrect usage of AlertDialog.Builder.create
Remove incorrect usage of AlertDialog.Builder.create
AlertDialog.Builder.show() will create an AlertDialog before it show. This is the source code snippet:
/**
* Creates a {@link AlertDialog} with the arguments supplied to this builder and
* {@link Dialog#show()}'s the dialog.
*/
public AlertDialog show() {
AlertDialog dialog = create();
dialog.show();
return dialog;
}
github: close #96
Project: http://git-wip-us.apache.org/repos/asf/cordova-amazon-fireos/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-amazon-fireos/commit/bece02e8
Tree: http://git-wip-us.apache.org/repos/asf/cordova-amazon-fireos/tree/bece02e8
Diff: http://git-wip-us.apache.org/repos/asf/cordova-amazon-fireos/diff/bece02e8
Branch: refs/heads/master
Commit: bece02e894f67f11d1c46f4d865123b5d5ed9e97
Parents: 5e9cb8f
Author: hadeslee <ha...@vip.qq.com>
Authored: Fri Mar 21 12:06:23 2014 +0800
Committer: Archana Naik <na...@lab126.com>
Committed: Wed Apr 2 13:31:04 2014 -0700
----------------------------------------------------------------------
framework/src/org/apache/cordova/CordovaChromeClient.java | 3 ---
1 file changed, 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-amazon-fireos/blob/bece02e8/framework/src/org/apache/cordova/CordovaChromeClient.java
----------------------------------------------------------------------
diff --git a/framework/src/org/apache/cordova/CordovaChromeClient.java b/framework/src/org/apache/cordova/CordovaChromeClient.java
index 86e20f3..6de43b6 100755
--- a/framework/src/org/apache/cordova/CordovaChromeClient.java
+++ b/framework/src/org/apache/cordova/CordovaChromeClient.java
@@ -150,7 +150,6 @@ public class CordovaChromeClient extends AmazonWebChromeClient {
return true;
}
});
- dlg.create();
dlg.show();
return true;
}
@@ -203,7 +202,6 @@ public class CordovaChromeClient extends AmazonWebChromeClient {
return true;
}
});
- dlg.create();
dlg.show();
return true;
}
@@ -300,7 +298,6 @@ public class CordovaChromeClient extends AmazonWebChromeClient {
res.cancel();
}
});
- dlg.create();
dlg.show();
}
return true;