You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/17 21:10:57 UTC

[GitHub] [arrow-datafusion] Dandandan commented on a diff in pull request #3861: Fix 3635 redundant projections

Dandandan commented on code in PR #3861:
URL: https://github.com/apache/arrow-datafusion/pull/3861#discussion_r997513619


##########
benchmarks/expected-plans/q19.txt:
##########
@@ -1,9 +1,8 @@
 Projection: SUM(lineitem.l_extendedprice * Int64(1) - lineitem.l_discount) AS revenue
   Aggregate: groupBy=[[]], aggr=[[SUM(CAST(lineitem.l_extendedprice AS Decimal128(38, 4)) * CAST(Decimal128(Some(100),23,2) - CAST(lineitem.l_discount AS Decimal128(23, 2)) AS Decimal128(38, 4))) AS SUM(lineitem.l_extendedprice * Int64(1) - lineitem.l_discount)]]
-    Projection: lineitem.l_extendedprice, lineitem.l_discount

Review Comment:
   This is not really redundant I think (when converting to a physical aggregation, we don't want to hash repartition the other columns)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org