[GitHub] [spark] cloud-fan commented on a diff in pull request #36936: [SPARK-39503][SQL] Add session catalog name for v1 database table and function

[GitBox <gi...@apache.org>]

cloud-fan commented on code in PR #36936:
URL: https://github.com/apache/spark/pull/36936#discussion_r907136211


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/identifiers.scala:
##########
@@ -34,13 +38,35 @@ sealed trait IdentifierWithDatabase {
   private def quoteIdentifier(name: String): String = name.replace("`", "``")
 
   def quotedString: String = {
+    if (SQLConf.get.getConf(LEGACY_IDENTIFIER_OUTPUT_CATALOG_NAME) && database.isDefined) {
+      val replacedId = quoteIdentifier(identifier)
+      val replacedDb = database.map(quoteIdentifier(_))

Review Comment:
   ```suggestion
         val replacedDb = quoteIdentifier(database.get)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org