You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tuscany.apache.org by mc...@apache.org on 2008/03/26 20:59:14 UTC

svn commit: r641529 - in /incubator/tuscany/java/sca/modules/binding-jms/src/main/java/org/apache/tuscany/sca/binding/jms: impl/JMSBindingConstants.java provider/JMSMessageProcessor.java

Author: mcombellack
Date: Wed Mar 26 12:59:12 2008
New Revision: 641529

URL: http://svn.apache.org/viewvc?rev=641529&view=rev
Log:
Removed redundant modifiers from methods on interface

Modified:
    incubator/tuscany/java/sca/modules/binding-jms/src/main/java/org/apache/tuscany/sca/binding/jms/impl/JMSBindingConstants.java
    incubator/tuscany/java/sca/modules/binding-jms/src/main/java/org/apache/tuscany/sca/binding/jms/provider/JMSMessageProcessor.java

Modified: incubator/tuscany/java/sca/modules/binding-jms/src/main/java/org/apache/tuscany/sca/binding/jms/impl/JMSBindingConstants.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/binding-jms/src/main/java/org/apache/tuscany/sca/binding/jms/impl/JMSBindingConstants.java?rev=641529&r1=641528&r2=641529&view=diff
==============================================================================
--- incubator/tuscany/java/sca/modules/binding-jms/src/main/java/org/apache/tuscany/sca/binding/jms/impl/JMSBindingConstants.java (original)
+++ incubator/tuscany/java/sca/modules/binding-jms/src/main/java/org/apache/tuscany/sca/binding/jms/impl/JMSBindingConstants.java Wed Mar 26 12:59:12 2008
@@ -30,31 +30,31 @@
 
     // Constants used when describing the JMS binding
     // model and for setting up defaults
-    public final static String BINDING_JMS = "binding.jms";
-    public final static QName BINDING_JMS_QNAME = new QName(Constants.SCA10_NS, BINDING_JMS);
-    public final static String CORRELATE_MSG_ID = "requestmsgidtocorrelid";
-    public final static String CORRELATE_CORRELATION_ID = "requestcorrelidtocorrelid";
-    public final static String CORRELATE_NONE = "none";
-    public final static List<String> VALID_CORRELATION_SCHEMES =
+    String BINDING_JMS = "binding.jms";
+    QName BINDING_JMS_QNAME = new QName(Constants.SCA10_NS, BINDING_JMS);
+    String CORRELATE_MSG_ID = "requestmsgidtocorrelid";
+    String CORRELATE_CORRELATION_ID = "requestcorrelidtocorrelid";
+    String CORRELATE_NONE = "none";
+    List<String> VALID_CORRELATION_SCHEMES =
         Arrays.asList(new String[] {CORRELATE_MSG_ID, CORRELATE_CORRELATION_ID, CORRELATE_NONE});
-    public final static String DESTINATION_TYPE_QUEUE = "queue"; // 0
-    public final static String DESTINATION_TYPE_TOPIC = "topic"; // 1
-    public final static List<String> VALID_DESTINATION_TYPES =
+    String DESTINATION_TYPE_QUEUE = "queue"; // 0
+    String DESTINATION_TYPE_TOPIC = "topic"; // 1
+    List<String> VALID_DESTINATION_TYPES =
         Arrays.asList(new String[] {DESTINATION_TYPE_QUEUE, DESTINATION_TYPE_TOPIC});
-    public final static String CREATE_ALWAYS = "always";
-    public final static String CREATE_NEVER = "never";
-    public final static String CREATE_IF_NOT_EXIST = "ifnotexist";
-    public final static String DEFAULT_DESTINATION_NAME = "NODESTINATION";
-    public final static String DEFAULT_RESPONSE_DESTINATION_NAME = "NORESPONSEDESTINATION";
-    public final static String DEFAULT_CONNECTION_FACTORY_NAME = "ConnectionFactory";
-    public final static String DEFAULT_CONTEXT_FACTORY_NAME = "org.apache.activemq.jndi.ActiveMQInitialContextFactory";
-    public final static String DEFAULT_JNDI_URL = "tcp://localhost:61616";
-    public final static int DEFAULT_TIME_TO_LIVE = 20000; // in milliseconds
-    public final static int DEFAULT_PRIORITY = 1;
-    public final static String DEFAULT_RF_CLASSNAME = "org.apache.tuscany.sca.host.jms.activemq.JMSResourceFactoryImpl";
-    public final static String DEFAULT_MP_CLASSNAME = JMSMessageProcessorImpl.class.getName();
-    public final static String DEFAULT_OPERATION_PROP_NAME = "scaOperationName";
+    String CREATE_ALWAYS = "always";
+    String CREATE_NEVER = "never";
+    String CREATE_IF_NOT_EXIST = "ifnotexist";
+    String DEFAULT_DESTINATION_NAME = "NODESTINATION";
+    String DEFAULT_RESPONSE_DESTINATION_NAME = "NORESPONSEDESTINATION";
+    String DEFAULT_CONNECTION_FACTORY_NAME = "ConnectionFactory";
+    String DEFAULT_CONTEXT_FACTORY_NAME = "org.apache.activemq.jndi.ActiveMQInitialContextFactory";
+    String DEFAULT_JNDI_URL = "tcp://localhost:61616";
+    int DEFAULT_TIME_TO_LIVE = 20000; // in milliseconds
+    int DEFAULT_PRIORITY = 1;
+    String DEFAULT_RF_CLASSNAME = "org.apache.tuscany.sca.host.jms.activemq.JMSResourceFactoryImpl";
+    String DEFAULT_MP_CLASSNAME = JMSMessageProcessorImpl.class.getName();
+    String DEFAULT_OPERATION_PROP_NAME = "scaOperationName";
 
-    public static final String FAULT_PROPERTY = "org.apache.tuscany.sca.fault";
+    String FAULT_PROPERTY = "org.apache.tuscany.sca.fault";
 
 }

Modified: incubator/tuscany/java/sca/modules/binding-jms/src/main/java/org/apache/tuscany/sca/binding/jms/provider/JMSMessageProcessor.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/binding-jms/src/main/java/org/apache/tuscany/sca/binding/jms/provider/JMSMessageProcessor.java?rev=641529&r1=641528&r2=641529&view=diff
==============================================================================
--- incubator/tuscany/java/sca/modules/binding-jms/src/main/java/org/apache/tuscany/sca/binding/jms/provider/JMSMessageProcessor.java (original)
+++ incubator/tuscany/java/sca/modules/binding-jms/src/main/java/org/apache/tuscany/sca/binding/jms/provider/JMSMessageProcessor.java Wed Mar 26 12:59:12 2008
@@ -29,25 +29,25 @@
     /**
      * Get the operation name from a JMS Message
      */
-    public abstract String getOperationName(Message message);
+    String getOperationName(Message message);
 
     /**
      * Set the operation name on a JMS Message
      */
-    public abstract void setOperationName(String operationName, Message message);
+    void setOperationName(String operationName, Message message);
 
     /**
      * Extracts the payload from a JMS Message
      */
-    public abstract Object extractPayloadFromJMSMessage(Message msg);
+    Object extractPayloadFromJMSMessage(Message msg);
 
     /**
      * Create a JMS Message containing the payload
      */
-    public abstract Message insertPayloadIntoJMSMessage(Session session, Object payload);
+    Message insertPayloadIntoJMSMessage(Session session, Object payload);
 
     /**
      * Create a JMS Message for reporting an exception
      */
-    public abstract Message createFaultMessage(Session session, Throwable responsePayload);
+    Message createFaultMessage(Session session, Throwable responsePayload);
 }



---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-commits-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-commits-help@ws.apache.org