You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2022/11/16 17:25:55 UTC

[GitHub] [samza] jia-gao commented on a diff in pull request #1641: LISAMZA-27395 removing the current recursive call prevention logic

jia-gao commented on code in PR #1641:
URL: https://github.com/apache/samza/pull/1641#discussion_r1024297945


##########
samza-log4j2/src/main/java/org/apache/samza/logging/log4j2/StreamAppenderMetrics.java:
##########
@@ -46,7 +43,6 @@ public class StreamAppenderMetrics extends MetricsBase {
   public StreamAppenderMetrics(String prefix, MetricsRegistry registry) {
     super(prefix + "-", registry);
     bufferFillPct = newGauge("buffer-fill-percent", 0);
-    recursiveCalls = newCounter("recursive-calls");

Review Comment:
   Didn't find StreamAppenderMetrics published in any oss samza doc
   https://samza.apache.org/learn/documentation/latest/container/metrics-table.html



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org