You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/16 06:30:48 UTC
[GitHub] [incubator-doris] BiteTheDDDDt commented on a diff in pull request #9586: [fix](storage) low_cardinality_optimize core dump when is null predicate
BiteTheDDDDt commented on code in PR #9586:
URL: https://github.com/apache/incubator-doris/pull/9586#discussion_r873363170
##########
be/src/vec/columns/column_dictionary.h:
##########
@@ -98,12 +98,14 @@ class ColumnDictionary final : public COWHelper<IColumn, ColumnDictionary<T>> {
}
void insert_data(const char* pos, size_t /*length*/) override {
- _codes.push_back(unaligned_load<T>(pos));
+ if (pos == nullptr) {
Review Comment:
Why we should process this logic? It seems just like `insert_default`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org