You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nlpcraft.apache.org by Aaron Radzinski <ar...@datalingvo.com> on 2021/05/07 23:42:56 UTC
[VOTE] Release Apache NLPCraft (incubating) 0.7.5
NLPCraft-ers,
We have finally finished with the massive 0.7.5 release and are ready to
make it public. This release constitutes the biggest change since the
project inception at ASF over a year ago. This is a call for a vote to
release Apache NLPCraft (incubating) version 0.7.5. This release includes
many significant improvements and bug fixes.
Release information:
1. Release location:
https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.5/
3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.5
4. JIRA issues fixed in release:
https://issues.apache.org/jira/projects/NLPCRAFT/versions/12349604
5. KEYS file:
https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
The vote will be open for at least 72 hours or until a necessary number of
votes are reached.
Please vote accordingly:
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove with the reason
Thank you,
--
Aaron Radzinski
Re: [VOTE] Release Apache NLPCraft (incubating) 0.7.5
Posted by Ifropc <if...@protonmail.com.INVALID>.
+1
- signature and checksum
- mvn clean verify (java 11, linux)
Thanks,
Gleb.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Saturday, May 8, 2021 1:29 AM, Kamov Sergey <sk...@gmail.com> wrote:
> +1
>
> - files
> - mvn clean verify (java 11, macOS)
> - project created from sources, tests run.
>
> Regards,
> Sergey Kamov
>
> On 08.05.2021 02:42, Aaron Radzinski wrote:
>
>
> > NLPCraft-ers,
> > We have finally finished with the massive 0.7.5 release and are ready to
> > make it public. This release constitutes the biggest change since the
> > project inception at ASF over a year ago. This is a call for a vote to
> > release Apache NLPCraft (incubating) version 0.7.5. This release includes
> > many significant improvements and bug fixes.
> > Release information:
> >
> > 1. Release location:
> > https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.5/
> >
> > 2. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.5
> > 3. JIRA issues fixed in release:
> > https://issues.apache.org/jira/projects/NLPCRAFT/versions/12349604
> >
> > 4. KEYS file:
> > https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
> >
> >
> > The vote will be open for at least 72 hours or until a necessary number of
> > votes are reached.
> > Please vote accordingly:
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thank you,
> >
> > -----------
> >
> > Aaron Radzinski
Re: [VOTE] Release Apache NLPCraft (incubating) 0.7.5
Posted by Kamov Sergey <sk...@gmail.com>.
+1
- files
- mvn clean verify (java 11, macOS)
- project created from sources, tests run.
Regards,
Sergey Kamov
On 08.05.2021 02:42, Aaron Radzinski wrote:
> NLPCraft-ers,
> We have finally finished with the massive 0.7.5 release and are ready to
> make it public. This release constitutes the biggest change since the
> project inception at ASF over a year ago. This is a call for a vote to
> release Apache NLPCraft (incubating) version 0.7.5. This release includes
> many significant improvements and bug fixes.
>
> Release information:
> 1. Release location:
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.5/
> 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.5
> 4. JIRA issues fixed in release:
> https://issues.apache.org/jira/projects/NLPCRAFT/versions/12349604
> 5. KEYS file:
> https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
>
> The vote will be open for at least 72 hours or until a necessary number of
> votes are reached.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thank you,
> --
> Aaron Radzinski
>
[RESULT] [VOTE] Release Apache NLPCraft (incubating) 0.7.5
Posted by Nikita Ivanov <ni...@gmail.com>.
NLPCraft-ers,
The vote for Apache NLPCraft 0.7.5 release is closed now.
Vote result: The vote PASSES with 6 votes +1 and no -1.
+1 votes:
- Nikita Ivanov (binding)
- Aaron Radzinski
- Sergey Kamov
- Furkan KAMACI (binding)
- Gleb
- Paul King (binding)
Aaron or myself will proceed with starting the final vote at IPMC shortly.
Best,,
--
Nikita Ivanov
On behalf of NLPCraft community.
On Wed, May 12, 2021 at 5:07 AM Paul King <pa...@asert.com.au> wrote:
> +1
>
> Checked hashes and signatures
> DISCLAIMER exists
> NOTICE seems okay
> LICENSE is okay but I think can be further improved (see [1] below)
> "mvn clean package verify" passes on Ubuntu and Win10 (no VM crash on Win10
> this time - yay)
> "mvn apache-rat:rat" passes
> incubating in name
> no unexpected binary files
> I ran against some pre-existing examples (see [2] below)
>
> [1] I believe the first mention of src/main/resources/moby in LICENSE can
> be removed. The second mention is now more detailed and should be retained
> however I don't believe it would be usual to relicense the mobi works from
> public domain to Apache 2.0. The mention in the NOTICE file allows you to
> include those resources without further re-licensing. I would suggest
> removing "and licensed under Apache License, Version 2.0" unless of course
> you have a specific reasoning behind wanting to re-license those artifacts.
>
> [2] I also ran my nlpcraft groovy-data-science example which interacts with
> the light switch example model. After adding in a kotlin-stdlib dependency,
> it ran fine against the Java, Scala, Kotlin and Groovy example models. I
> had to add the language to each respective model ID,
> e.g. nlpcraft.lightswitch.ex.groovy instead of nlpcraft.lightswitch.ex
> which I have used in the past.
>
> Cheers, Paul.
>
>
>
> On Sat, May 8, 2021 at 9:43 AM Aaron Radzinski <ar...@datalingvo.com>
> wrote:
>
> > NLPCraft-ers,
> > We have finally finished with the massive 0.7.5 release and are ready to
> > make it public. This release constitutes the biggest change since the
> > project inception at ASF over a year ago. This is a call for a vote to
> > release Apache NLPCraft (incubating) version 0.7.5. This release includes
> > many significant improvements and bug fixes.
> >
> > Release information:
> > 1. Release location:
> >
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.5/
> > 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.5
> > 4. JIRA issues fixed in release:
> > https://issues.apache.org/jira/projects/NLPCRAFT/versions/12349604
> > 5. KEYS file:
> > https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
> >
> > The vote will be open for at least 72 hours or until a necessary number
> of
> > votes are reached.
> >
> > Please vote accordingly:
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thank you,
> > --
> > Aaron Radzinski
> >
>
Re: [VOTE] Release Apache NLPCraft (incubating) 0.7.5
Posted by Paul King <pa...@asert.com.au>.
+1
Checked hashes and signatures
DISCLAIMER exists
NOTICE seems okay
LICENSE is okay but I think can be further improved (see [1] below)
"mvn clean package verify" passes on Ubuntu and Win10 (no VM crash on Win10
this time - yay)
"mvn apache-rat:rat" passes
incubating in name
no unexpected binary files
I ran against some pre-existing examples (see [2] below)
[1] I believe the first mention of src/main/resources/moby in LICENSE can
be removed. The second mention is now more detailed and should be retained
however I don't believe it would be usual to relicense the mobi works from
public domain to Apache 2.0. The mention in the NOTICE file allows you to
include those resources without further re-licensing. I would suggest
removing "and licensed under Apache License, Version 2.0" unless of course
you have a specific reasoning behind wanting to re-license those artifacts.
[2] I also ran my nlpcraft groovy-data-science example which interacts with
the light switch example model. After adding in a kotlin-stdlib dependency,
it ran fine against the Java, Scala, Kotlin and Groovy example models. I
had to add the language to each respective model ID,
e.g. nlpcraft.lightswitch.ex.groovy instead of nlpcraft.lightswitch.ex
which I have used in the past.
Cheers, Paul.
On Sat, May 8, 2021 at 9:43 AM Aaron Radzinski <ar...@datalingvo.com>
wrote:
> NLPCraft-ers,
> We have finally finished with the massive 0.7.5 release and are ready to
> make it public. This release constitutes the biggest change since the
> project inception at ASF over a year ago. This is a call for a vote to
> release Apache NLPCraft (incubating) version 0.7.5. This release includes
> many significant improvements and bug fixes.
>
> Release information:
> 1. Release location:
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.5/
> 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.5
> 4. JIRA issues fixed in release:
> https://issues.apache.org/jira/projects/NLPCRAFT/versions/12349604
> 5. KEYS file:
> https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
>
> The vote will be open for at least 72 hours or until a necessary number of
> votes are reached.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thank you,
> --
> Aaron Radzinski
>
Re: [VOTE] Release Apache NLPCraft (incubating) 0.7.5
Posted by Nikita Ivanov <ni...@gmail.com>.
+1
Checked the usual:
- LICENSE, NOTE files
- Signatures match
- 'mvn clean package verify' works on Windows 10/Ubuntu 20.04/MacOS 11.3.
Thanks,
--
Nikita Ivanov
On Fri, May 7, 2021 at 4:43 PM Aaron Radzinski <ar...@datalingvo.com>
wrote:
>
> NLPCraft-ers,
> We have finally finished with the massive 0.7.5 release and are ready to
> make it public. This release constitutes the biggest change since the
> project inception at ASF over a year ago. This is a call for a vote to
> release Apache NLPCraft (incubating) version 0.7.5. This release includes
> many significant improvements and bug fixes.
>
> Release information:
> 1. Release location:
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.5/
> 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.5
> 4. JIRA issues fixed in release:
> https://issues.apache.org/jira/projects/NLPCRAFT/versions/12349604
> 5. KEYS file:
> https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
>
> The vote will be open for at least 72 hours or until a necessary number of
> votes are reached.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thank you,
> --
> Aaron Radzinski
Re: [VOTE] Release Apache NLPCraft (incubating) 0.7.5
Posted by Furkan KAMACI <fu...@gmail.com>.
Hi,
+1 from me (binding).
I checked:
- LICENSE and NOTICE are fine
- No unexpected binary files
- Checked PGP signatures
- Checked checksums
- Code compiles and tests successfully run
- Apache rat checks are OK
Kind Regards,
Furkan KAMACI
On Tue, May 11, 2021 at 11:54 PM Sergey Makov <sm...@apache.org> wrote:
> +1
>
> Checked:
> - mvn clean package verify (MacOS)
> - signatures
>
> Regards,
> Sergey
>
> On Sat, May 8, 2021 at 2:43 AM Aaron Radzinski
> <ar...@datalingvo.com> wrote:
> >
> > NLPCraft-ers,
> > We have finally finished with the massive 0.7.5 release and are ready to
> > make it public. This release constitutes the biggest change since the
> > project inception at ASF over a year ago. This is a call for a vote to
> > release Apache NLPCraft (incubating) version 0.7.5. This release includes
> > many significant improvements and bug fixes.
> >
> > Release information:
> > 1. Release location:
> >
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.5/
> > 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.5
> > 4. JIRA issues fixed in release:
> > https://issues.apache.org/jira/projects/NLPCRAFT/versions/12349604
> > 5. KEYS file:
> > https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
> >
> > The vote will be open for at least 72 hours or until a necessary number
> of
> > votes are reached.
> >
> > Please vote accordingly:
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thank you,
> > --
> > Aaron Radzinski
>
Re: [VOTE] Release Apache NLPCraft (incubating) 0.7.5
Posted by Sergey Makov <sm...@apache.org>.
+1
Checked:
- mvn clean package verify (MacOS)
- signatures
Regards,
Sergey
On Sat, May 8, 2021 at 2:43 AM Aaron Radzinski
<ar...@datalingvo.com> wrote:
>
> NLPCraft-ers,
> We have finally finished with the massive 0.7.5 release and are ready to
> make it public. This release constitutes the biggest change since the
> project inception at ASF over a year ago. This is a call for a vote to
> release Apache NLPCraft (incubating) version 0.7.5. This release includes
> many significant improvements and bug fixes.
>
> Release information:
> 1. Release location:
> https://dist.apache.org/repos/dist/dev/incubator/nlpcraft/nlpcraft/0.7.5/
> 3. Git tag: https://github.com/apache/incubator-nlpcraft/tree/v0.7.5
> 4. JIRA issues fixed in release:
> https://issues.apache.org/jira/projects/NLPCRAFT/versions/12349604
> 5. KEYS file:
> https://dist.apache.org/repos/dist/release/incubator/nlpcraft/KEYS
>
> The vote will be open for at least 72 hours or until a necessary number of
> votes are reached.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thank you,
> --
> Aaron Radzinski