You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ta...@apache.org on 2015/10/10 00:19:03 UTC
qpid-jms git commit: QPIDJMS-122 Avoid synchronizing in the connect
method when not necessary
Repository: qpid-jms
Updated Branches:
refs/heads/master f802a36ae -> 3bec45e19
QPIDJMS-122 Avoid synchronizing in the connect method when not necessary
Project: http://git-wip-us.apache.org/repos/asf/qpid-jms/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-jms/commit/3bec45e1
Tree: http://git-wip-us.apache.org/repos/asf/qpid-jms/tree/3bec45e1
Diff: http://git-wip-us.apache.org/repos/asf/qpid-jms/diff/3bec45e1
Branch: refs/heads/master
Commit: 3bec45e1961d9c126dbe7b36d4290b3de273721c
Parents: f802a36
Author: Timothy Bish <ta...@gmail.com>
Authored: Fri Oct 9 18:18:55 2015 -0400
Committer: Timothy Bish <ta...@gmail.com>
Committed: Fri Oct 9 18:18:55 2015 -0400
----------------------------------------------------------------------
.../src/main/java/org/apache/qpid/jms/JmsConnection.java | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/3bec45e1/qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsConnection.java
----------------------------------------------------------------------
diff --git a/qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsConnection.java b/qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsConnection.java
index 5e83302..43607e4 100644
--- a/qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsConnection.java
+++ b/qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsConnection.java
@@ -431,6 +431,10 @@ public class JmsConnection implements Connection, TopicConnection, QueueConnecti
}
private void connect() throws JMSException {
+ if (isConnected() || closed.get()) {
+ return;
+ }
+
synchronized(this.connectionInfo) {
if (isConnected() || closed.get()) {
return;
@@ -441,7 +445,7 @@ public class JmsConnection implements Connection, TopicConnection, QueueConnecti
}
createResource(connectionInfo);
- this.connected.set(true);
+ connected.set(true);
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org