You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spamassassin.apache.org by bi...@apache.org on 2018/12/20 21:43:37 UTC
svn commit: r1849441 - in /spamassassin: branches/3.4/build/mkrules
trunk/build/mkrules
Author: billcole
Date: Thu Dec 20 21:43:37 2018
New Revision: 1849441
URL: http://svn.apache.org/viewvc?rev=1849441&view=rev
Log:
Failed lint should fail for real.
Modified:
spamassassin/branches/3.4/build/mkrules
spamassassin/trunk/build/mkrules
Modified: spamassassin/branches/3.4/build/mkrules
URL: http://svn.apache.org/viewvc/spamassassin/branches/3.4/build/mkrules?rev=1849441&r1=1849440&r2=1849441&view=diff
==============================================================================
--- spamassassin/branches/3.4/build/mkrules (original)
+++ spamassassin/branches/3.4/build/mkrules Thu Dec 20 21:43:37 2018
@@ -213,14 +213,7 @@ sub lint_output_files {
foreach my $file (keys %{$files_to_lint}) {
my $text = join("\n", "file start $file", $output_file_text->{$file}, "file end $file");
if (lint_rule_text($text) != 0) {
- warn "\nERROR: LINT FAILED, suppressing output: $file\n\n";
-
- # don't suppress entirely, otherwise 'make distcheck'/'disttest'
- # will fail since the MANIFEST-listed output files will be
- # empty.
-
- # delete $output_file_text->{$file};
- $output_file_text->{$file} = '';
+ die "\nERROR: LINT FAILED, suppressing output: $file\n\n";
}
}
}
Modified: spamassassin/trunk/build/mkrules
URL: http://svn.apache.org/viewvc/spamassassin/trunk/build/mkrules?rev=1849441&r1=1849440&r2=1849441&view=diff
==============================================================================
--- spamassassin/trunk/build/mkrules (original)
+++ spamassassin/trunk/build/mkrules Thu Dec 20 21:43:37 2018
@@ -213,14 +213,7 @@ sub lint_output_files {
foreach my $file (keys %{$files_to_lint}) {
my $text = join("\n", "file start $file", $output_file_text->{$file}, "file end $file");
if (lint_rule_text($text) != 0) {
- warn "\nERROR: LINT FAILED, suppressing output: $file\n\n";
-
- # don't suppress entirely, otherwise 'make distcheck'/'disttest'
- # will fail since the MANIFEST-listed output files will be
- # empty.
-
- # delete $output_file_text->{$file};
- $output_file_text->{$file} = '';
+ die "\nERROR: LINT FAILED, suppressing output: $file\n\n";
}
}
}