You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2014/07/24 11:45:40 UTC

Review Request 23882: CLOUDSTACK-7125: Fixed test_blocker_bugs.py, added code to wait for snapshots to be in 'BackedUp' state

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23882/
-----------------------------------------------------------

Review request for cloudstack and Santhosh Edukulla.


Bugs: CLOUDSTACK-7125
    https://issues.apache.org/jira/browse/CLOUDSTACK-7125


Repository: cloudstack-git


Description
-------

After creating snapshot, added check if the snapshot is in backed up state or not using the library function already availble in base.py.
Earlier this check was not done and directly template was created from snapshot. When snapshot is not backedup state, then template creation will fail.


Diffs
-----

  test/integration/component/test_blocker_bugs.py ba15b18 

Diff: https://reviews.apache.org/r/23882/diff/


Testing
-------

Did not run the test cases as already existing library function is used.
Checked for sytax/import errors using pyflakes and python command.


Thanks,

Gaurav Aradhye


Re: Review Request 23882: CLOUDSTACK-7125: Fixed test_blocker_bugs.py, added code to wait for snapshots to be in 'BackedUp' state

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23882/#review48653
-----------------------------------------------------------


Commit 4395308bd8b469fb02fc71d1e22f25c7d89b6dff in cloudstack's branch refs/heads/4.4-forward from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4395308 ]

CLOUDSTACK-7125: Fixed test_blocker_bugs.py, added code to wait for snapshots to be in 'BackedU' state


- ASF Subversion and Git Services


On July 24, 2014, 2:43 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23882/
> -----------------------------------------------------------
> 
> (Updated July 24, 2014, 2:43 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-7125
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7125
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> After creating snapshot, added check if the snapshot is in backed up state or not using the library function already availble in base.py.
> Earlier this check was not done and directly template was created from snapshot. When snapshot is not backedup state, then template creation will fail.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_blocker_bugs.py ba15b18 
> 
> Diff: https://reviews.apache.org/r/23882/diff/
> 
> 
> Testing
> -------
> 
> Did not run the test cases as already existing library function is used.
> Checked for sytax/import errors using pyflakes and python command.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Re: Review Request 23882: CLOUDSTACK-7125: Fixed test_blocker_bugs.py, added code to wait for snapshots to be in 'BackedUp' state

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23882/#review48849
-----------------------------------------------------------


Commit 724c8dc7c98574dcdf669c0c2d7549981667ab77 in cloudstack's branch refs/heads/4.4 from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=724c8dc ]

CLOUDSTACK-7125: Fixed test_blocker_bugs.py, added code to wait for snapshots to be in 'BackedU' state

(cherry picked from commit 4395308bd8b469fb02fc71d1e22f25c7d89b6dff)


- ASF Subversion and Git Services


On July 24, 2014, 2:43 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23882/
> -----------------------------------------------------------
> 
> (Updated July 24, 2014, 2:43 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-7125
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7125
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> After creating snapshot, added check if the snapshot is in backed up state or not using the library function already availble in base.py.
> Earlier this check was not done and directly template was created from snapshot. When snapshot is not backedup state, then template creation will fail.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_blocker_bugs.py ba15b18 
> 
> Diff: https://reviews.apache.org/r/23882/diff/
> 
> 
> Testing
> -------
> 
> Did not run the test cases as already existing library function is used.
> Checked for sytax/import errors using pyflakes and python command.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Re: Review Request 23882: CLOUDSTACK-7125: Fixed test_blocker_bugs.py, added code to wait for snapshots to be in 'BackedUp' state

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23882/#review48652
-----------------------------------------------------------


Commit 49005b324f18e19166bcbb801bcd07609e44d8db in cloudstack's branch refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=49005b3 ]

CLOUDSTACK-7125: Fixed test_blocker_bugs.py, added code to wait for snapshots to be in 'BackedU' state


- ASF Subversion and Git Services


On July 24, 2014, 2:43 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23882/
> -----------------------------------------------------------
> 
> (Updated July 24, 2014, 2:43 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-7125
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7125
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> After creating snapshot, added check if the snapshot is in backed up state or not using the library function already availble in base.py.
> Earlier this check was not done and directly template was created from snapshot. When snapshot is not backedup state, then template creation will fail.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_blocker_bugs.py ba15b18 
> 
> Diff: https://reviews.apache.org/r/23882/diff/
> 
> 
> Testing
> -------
> 
> Did not run the test cases as already existing library function is used.
> Checked for sytax/import errors using pyflakes and python command.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Re: Review Request 23882: CLOUDSTACK-7125: Fixed test_blocker_bugs.py, added code to wait for snapshots to be in 'BackedUp' state

Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23882/
-----------------------------------------------------------

(Updated July 24, 2014, 8:13 p.m.)


Review request for cloudstack and Girish Shilamkar.


Bugs: CLOUDSTACK-7125
    https://issues.apache.org/jira/browse/CLOUDSTACK-7125


Repository: cloudstack-git


Description
-------

After creating snapshot, added check if the snapshot is in backed up state or not using the library function already availble in base.py.
Earlier this check was not done and directly template was created from snapshot. When snapshot is not backedup state, then template creation will fail.


Diffs
-----

  test/integration/component/test_blocker_bugs.py ba15b18 

Diff: https://reviews.apache.org/r/23882/diff/


Testing
-------

Did not run the test cases as already existing library function is used.
Checked for sytax/import errors using pyflakes and python command.


Thanks,

Gaurav Aradhye