You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/07 03:33:53 UTC
[GitHub] [incubator-doris] HappenLee opened a new pull request, #8882: [Feature] Disable cast operation of hll/bitmap type
HappenLee opened a new pull request, #8882:
URL: https://github.com/apache/incubator-doris/pull/8882
# Proposed changes
Issue Number: close #8881
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes)
2. Has unit tests been added: (Ye)
3. Has document been added or modified: (No Need)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (Yes)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8882: [Feature] Disable cast operation of hll/bitmap type
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8882:
URL: https://github.com/apache/incubator-doris/pull/8882#issuecomment-1091729449
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #8882: [Feature] Disable cast operation of hll/bitmap type
Posted by GitBox <gi...@apache.org>.
morningman merged PR #8882:
URL: https://github.com/apache/incubator-doris/pull/8882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HappenLee commented on a diff in pull request #8882: [Feature] Disable cast operation of hll/bitmap type
Posted by GitBox <gi...@apache.org>.
HappenLee commented on code in PR #8882:
URL: https://github.com/apache/incubator-doris/pull/8882#discussion_r844738223
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/CastExpr.java:
##########
@@ -134,23 +134,29 @@ public TypeDef getTargetTypeDef() {
return targetTypeDef;
}
+ private static boolean disableRegisterCastingFunction(Type fromType, Type toType) {
+ // Disable casting from boolean to decimal or datetime or date
+ if (fromType.isBoolean() &&
+ (toType.equals(Type.DECIMALV2) ||
+ toType.equals(Type.DATETIME) || toType.equals(Type.DATE))) {
+ return true;
+ }
+
+ // Disable casting operation of hll/bitmap
+ if (fromType.isBitmapType() || fromType.isHllType() || toType.isHllType() || toType.isBitmapType()) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8882: [Feature] Disable cast operation of hll/bitmap type
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8882:
URL: https://github.com/apache/incubator-doris/pull/8882#issuecomment-1091729501
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a diff in pull request #8882: [Feature] Disable cast operation of hll/bitmap type
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #8882:
URL: https://github.com/apache/incubator-doris/pull/8882#discussion_r844641534
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/CastExpr.java:
##########
@@ -134,23 +134,29 @@ public TypeDef getTargetTypeDef() {
return targetTypeDef;
}
+ private static boolean disableRegisterCastingFunction(Type fromType, Type toType) {
+ // Disable casting from boolean to decimal or datetime or date
+ if (fromType.isBoolean() &&
+ (toType.equals(Type.DECIMALV2) ||
+ toType.equals(Type.DATETIME) || toType.equals(Type.DATE))) {
+ return true;
+ }
+
+ // Disable casting operation of hll/bitmap
+ if (fromType.isBitmapType() || fromType.isHllType() || toType.isHllType() || toType.isBitmapType()) {
Review Comment:
We also had a `QUANTILE_STATE
You can use `isObjectStored()` instead.
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/PrimitiveType.java:
##########
@@ -266,8 +264,6 @@
builder.put(STRING, DECIMALV2);
builder.put(STRING, VARCHAR);
builder.put(STRING, STRING);
- builder.put(STRING, HLL);
- builder.put(STRING, BITMAP);
builder.put(STRING, QUANTILE_STATE);
Review Comment:
disable `STRING, QUANTILE_STATE`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a diff in pull request #8882: [Feature] Disable cast operation of hll/bitmap type
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #8882:
URL: https://github.com/apache/incubator-doris/pull/8882#discussion_r844844669
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/PrimitiveType.java:
##########
@@ -248,8 +248,6 @@
builder.put(VARCHAR, DECIMALV2);
builder.put(VARCHAR, VARCHAR);
builder.put(VARCHAR, STRING);
- builder.put(VARCHAR, HLL);
- builder.put(VARCHAR, BITMAP);
builder.put(VARCHAR, QUANTILE_STATE);
Review Comment:
remove this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org