You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by "kinow (via GitHub)" <gi...@apache.org> on 2023/02/12 08:41:48 UTC
[GitHub] [jena-site] kinow opened a new pull request, #146: Add basic search with Fuse.js (search engine), Mark.js (word highlighter) and Hugo (search index)
kinow opened a new pull request, #146:
URL: https://github.com/apache/jena-site/pull/146
Had some 40 minutes this morning while waiting to go out for a local party (st eulalia with giants and castellers! :partying_face:), so had a go at adding search to Jena's website.
Hugo has a page to [Search for your Hugo Website](https://gohugo.io/tools/search/) with links go gists, libraries, and posts. After some searching, I found this one to be up to date and very simple to follow: https://makewithhugo.com/add-search-to-a-hugo-site/
It uses Fuse.js, a fast and dependency-free JS library (really rare!) to perform full text search with support to fuzzy searching. The post also uses Mark.js, which I am not sure if was really necessary, as it's a library to highlight words, but I preferred to just add it for now and decide to drop it or not later.
The layout of the search results was not customized, we can change how they are displayed later if needed. I focused more on the search input field/form for now (due to short time). See screenshots below where I searched for "infrenc":
And, of course, if you search for a correct term, then it's highlighted in the results, like "query builder":
That's it :+1:
Cheers,
-Bruno
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jena-site] kinow commented on pull request #146: Add basic search with Fuse.js (search engine), Mark.js (word highlighter) and Hugo (search index)
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on PR #146:
URL: https://github.com/apache/jena-site/pull/146#issuecomment-1498161142
(rebased)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jena-site] kinow merged pull request #146: Add basic search with Fuse.js (search engine), Mark.js (word highlighter) and Hugo (search index)
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow merged PR #146:
URL: https://github.com/apache/jena-site/pull/146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jena-site] afs commented on pull request #146: Add basic search with Fuse.js (search engine), Mark.js (word highlighter) and Hugo (search index)
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on PR #146:
URL: https://github.com/apache/jena-site/pull/146#issuecomment-1427037319
I get results!
A lot of results :-(
Each 3 times - hits first then what seems to be everything.
... it goes on a lot further - it's croipped by the screen grab.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jena-site] afs commented on pull request #146: Add basic search with Fuse.js (search engine), Mark.js (word highlighter) and Hugo (search index)
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on PR #146:
URL: https://github.com/apache/jena-site/pull/146#issuecomment-1427012274
> so in the end I thought this was the simplest option to have search in our site, for now
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jena-site] kinow commented on pull request #146: Add basic search with Fuse.js (search engine), Mark.js (word highlighter) and Hugo (search index)
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on PR #146:
URL: https://github.com/apache/jena-site/pull/146#issuecomment-1500675919
>hugo version is the Jenkinsfile at top of jena-site:main is 0.66.0
>so my guess is hugo version.
Yeah, searched for issues, but did not find anything recent (what I found was from ~2019).
My Hugo version:
```bash
hugo version
hugo v0.111.3-5d4eb5154e1fed125ca8e9b5a0315c4180dab192+extended linux/amd64 BuildDate=2023-03-12T11:40:50Z VendorInfo=snap:0.111.3
```
Should I open a ticket to Infra to ask them to update the Hugo version of the Jenkins workers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jena-site] kinow commented on pull request #146: Add basic search with Fuse.js (search engine), Mark.js (word highlighter) and Hugo (search index)
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on PR #146:
URL: https://github.com/apache/jena-site/pull/146#issuecomment-1426973715
p.s. we could also use Algolia free, which I use for some sites I maintain, but someone needs to have the account and maintain the token, and it has a high limit but that Jena could reach as we have a lot of users I think... so in the end I thought this was the simplest option to have search in our site, for now :+1:
Ah! And here's the search on smaller viewports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jena-site] kinow commented on pull request #146: Add basic search with Fuse.js (search engine), Mark.js (word highlighter) and Hugo (search index)
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on PR #146:
URL: https://github.com/apache/jena-site/pull/146#issuecomment-1427047238
Now testing why some results like "TDB Transactions" are appearing in the results, as I cannot find SHACL in that page :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jena-site] kinow commented on pull request #146: Add basic search with Fuse.js (search engine), Mark.js (word highlighter) and Hugo (search index)
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on PR #146:
URL: https://github.com/apache/jena-site/pull/146#issuecomment-1427046786
Still working on the top menu responsiveness when we resize the screen.
But I think the search results should be:
- unique (did a `| uniq`) in Hugo when it creates the index, so no more duplicates :crossed_fingers:, and
- removing some pages, like the Search results page :sweat_smile: (noticed that while testing it, fixed by adding a front matter option `excludeSearch`).
Also removed options that did not appear in the Fuse.js docs (probably the author of the blog was using an older version previously to writing it), and added comments to the ones we are using, as well as a link to the Fuse.js docs—in case anyone needs to tweak it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jena-site] kinow commented on pull request #146: Add basic search with Fuse.js (search engine), Mark.js (word highlighter) and Hugo (search index)
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on PR #146:
URL: https://github.com/apache/jena-site/pull/146#issuecomment-1427083700
I enabled the extended search of Fuse.js, that allows exact terms, and search for something that starts with a term, or ends with, or excludes a term... but that didn't work quite well. It was searching the document title, I think? :disappointed_relieved:
And the syntax was different than what users of Google/DDG would expect (e.g. instead of "term" for an exact match, it was "=term"). So I didn't want our readers to get familiar/used to that syntax, in case we ever need to switch JS search libraries :+1:
Ready for another review :crossed_fingers:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jena-site] kinow commented on pull request #146: Add basic search with Fuse.js (search engine), Mark.js (word highlighter) and Hugo (search index)
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on PR #146:
URL: https://github.com/apache/jena-site/pull/146#issuecomment-1500692221
That fixed it, @afs. Thanks!!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [GitHub] [jena-site] kinow commented on pull request #146: Add basic search with Fuse.js (search engine), Mark.js (word highlighter) and Hugo (search index)
Posted by Andy Seaborne <an...@apache.org>.
On 07/04/2023 19:06, kinow (via GitHub) wrote:
>
> kinow commented on PR #146:
> URL: https://github.com/apache/jena-site/pull/146#issuecomment-1500516467
>
> Thanks for the review @afs . I wonder if something went wrong with the site build? I merged it earlier this morning and tried to access it now, but I can't see the search anywhere in the website. I tried the `staging.jena.apache.org` and `jena.staging.apache.org`, but these URL's didn't work. Could you remind me what's the process after a PR is merged, please, @afs ? Thanks!
I don't think "staging" works. They were pre-Hugo.
If it merged to main, then it's jena.apache.org - I see
7905e130d Add basic search with Fuse.js ... in git.
Locally, main shows "search" is working.
But on Jenkins there is
https://ci-builds.apache.org/job/Jena/job/Jena_Site2/job/main/213/console
which has a build failure.
Error: Error building site: failed to render pages: render of "home"
failed:
"/home/jenkins/712657a4/workspace/Jena_Jena_Site2_main/layouts/_default/index.json:7:28":
execute of template failed: template: _default/index.json:7:28:
executing "_default/index.json" at <uniq>: error calling uniq: elements
must be comparable
which I do not understand.
I tried again - same thing.
https://ci-builds.apache.org/job/Jena/job/Jena_Site2/job/main/
My hugo is hugo v0.111.3 -
hugo version is the Jenkinsfile at top of jena-site:main is 0.66.0
so my guess is hugo version.
Andy
The other issue with Jenkins is that it does not trigger when merging
commits with timestamps that are old. It seems to go on the commit date,
not merge date.
But it doesn't look like that is happening here. Job 213 ran at 7 Apr
2023, 11:17:18 UTC
[GitHub] [jena-site] kinow commented on pull request #146: Add basic search with Fuse.js (search engine), Mark.js (word highlighter) and Hugo (search index)
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on PR #146:
URL: https://github.com/apache/jena-site/pull/146#issuecomment-1500516467
Thanks for the review @afs . I wonder if something went wrong with the site build? I merged it earlier this morning and tried to access it now, but I can't see the search anywhere in the website. I tried the `staging.jena.apache.org` and `jena.staging.apache.org`, but these URL's didn't work. Could you remind me what's the process after a PR is merged, please, @afs ? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jena-site] afs commented on pull request #146: Add basic search with Fuse.js (search engine), Mark.js (word highlighter) and Hugo (search index)
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on PR #146:
URL: https://github.com/apache/jena-site/pull/146#issuecomment-1427016707
I pulled the branch and ran hugo.
When the screen size is a bit bigger than small the alignment goes wonky:
I searched for "SHACL" (browser = Firefox) but it stays on "Loading ..."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jena-site] kinow commented on pull request #146: Add basic search with Fuse.js (search engine), Mark.js (word highlighter) and Hugo (search index)
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on PR #146:
URL: https://github.com/apache/jena-site/pull/146#issuecomment-1427044269
>I get results!
Hooray! :sun_with_face:
>A lot of results :-(
Hoo... ray? :sun_behind_small_cloud:
>Each 3 times - hits first then what seems to be everything.
Huh :sun_behind_rain_cloud:
I see what you mean. I was happy to get results, and didn't try to tweak the Fuse.js nor Hugo index settings. For the duplicates I think I already found a solution (include an ID in the returned values). I'm going through the Fuse.js options now to tweak it a bit more...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jena-site] kinow commented on a diff in pull request #146: Add basic search with Fuse.js (search engine), Mark.js (word highlighter) and Hugo (search index)
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on code in PR #146:
URL: https://github.com/apache/jena-site/pull/146#discussion_r1103840564
##########
layouts/_default/search.html:
##########
@@ -0,0 +1,200 @@
+{{ define "main" }}
+<!-- Source: https://makewithhugo.com/add-search-to-a-hugo-site/ -->
+<main>
+ <div id="search-results"></div>
+ <div class="search-loading">Loading...</div>
+
+ <script id="search-result-template" type="text/x-js-template">
+ <div id="summary-${key}">
+ <h3><a href="${link}">${title}</a></h3>
+ <p class="pb-0 mb-0">${snippet}</p>
+ <p class="opacity-50 pt-0 mt-0"><small>Score: ${score}</small></p>
+ <p>
+ <small>
+ ${ isset tags }Tags: ${tags}<br>${ end }
+ </small>
+ </p>
+ </div>
+ </script>
+
+ <script src="/js/fuse.min.js" type="text/javascript" crossorigin="anonymous" referrerpolicy="no-referrer"></script>
+ <script src="/js/mark.min.js" type="text/javascript" crossorigin="anonymous" referrerpolicy="no-referrer"></script>
+ <script type="text/javascript">
+ (function() {
+ const summaryInclude = 180;
+ // See: https://fusejs.io/api/options.html
+ const fuseOptions = {
+ // Indicates whether comparisons should be case sensitive.
+ isCaseSensitive: false,
+ // Whether the score should be included in the result set.
+ // A score of 0 indicates a perfect match, while a score of 1 indicates a complete mismatch.
+ includeScore: true,
+ // Whether the matches should be included in the result set.
+ // When true, each record in the result set will include the indices of the matched characters.
+ // These can consequently be used for highlighting purposes.
+ includeMatches: true,
+ // Only the matches whose length exceeds this value will be returned.
+ // (For instance, if you want to ignore single character matches in the result, set it to 2).
+ minMatchCharLength: 2,
+ // Whether to sort the result list, by score.
+ shouldSort: true,
+ // List of keys that will be searched.
+ // This supports nested paths, weighted search, searching in arrays of strings and objects.
+ keys: [
+ {name: "title", weight: 0.8},
+ {name: "contents", weight: 0.7},
+ // {name: "tags", weight: 0.95},
+ // {name: "categories", weight: 0.05}
+ ],
+ // --- Fuzzy Matching Options
+ // Determines approximately where in the text is the pattern expected to be found.
+ location: 0,
+ // At what point does the match algorithm give up.
+ // A threshold of 0.0 requires a perfect match (of both letters and location),
+ // a threshold of 1.0 would match anything.
+ threshold: 0.2,
Review Comment:
With a `threshold` of `0` I get `7` search results for SHACL. That's the same number I get when grepping for it (case insensitive),
```bash
kinow@ranma:~/Development/java/jena/jena-site/source$ grep -r -H -o -i SHACL | awk -F: '{ print $1 }' | sort -h | uniq
documentation/fuseki2/fuseki-config-endpoint.md
documentation/__index.md
documentation/javadoc.md
documentation/notes/system-initialization.md
documentation/shacl/__index.md
documentation/tools/__index.md
download/maven.md
```
But if I search for "shakl" it brings `0` results.
With `0.2`, both SHACL and SHAKL bring me 14 search results. The 7 first results have a score lower than `1` (in Fuse.js higher is worse), and the other 7 have a score of `1` (I left the score to be displayed with results to help users).
So I decided to leave it to 0.2 so users still get some result if they misspell their search query.
##########
layouts/_default/search.html:
##########
@@ -0,0 +1,200 @@
+{{ define "main" }}
+<!-- Source: https://makewithhugo.com/add-search-to-a-hugo-site/ -->
+<main>
+ <div id="search-results"></div>
+ <div class="search-loading">Loading...</div>
+
+ <script id="search-result-template" type="text/x-js-template">
+ <div id="summary-${key}">
+ <h3><a href="${link}">${title}</a></h3>
+ <p class="pb-0 mb-0">${snippet}</p>
+ <p class="opacity-50 pt-0 mt-0"><small>Score: ${score}</small></p>
+ <p>
+ <small>
+ ${ isset tags }Tags: ${tags}<br>${ end }
+ </small>
+ </p>
+ </div>
+ </script>
+
+ <script src="/js/fuse.min.js" type="text/javascript" crossorigin="anonymous" referrerpolicy="no-referrer"></script>
+ <script src="/js/mark.min.js" type="text/javascript" crossorigin="anonymous" referrerpolicy="no-referrer"></script>
+ <script type="text/javascript">
+ (function() {
+ const summaryInclude = 180;
+ // See: https://fusejs.io/api/options.html
+ const fuseOptions = {
+ // Indicates whether comparisons should be case sensitive.
+ isCaseSensitive: false,
+ // Whether the score should be included in the result set.
+ // A score of 0 indicates a perfect match, while a score of 1 indicates a complete mismatch.
+ includeScore: true,
+ // Whether the matches should be included in the result set.
+ // When true, each record in the result set will include the indices of the matched characters.
+ // These can consequently be used for highlighting purposes.
+ includeMatches: true,
+ // Only the matches whose length exceeds this value will be returned.
+ // (For instance, if you want to ignore single character matches in the result, set it to 2).
+ minMatchCharLength: 2,
+ // Whether to sort the result list, by score.
+ shouldSort: true,
+ // List of keys that will be searched.
+ // This supports nested paths, weighted search, searching in arrays of strings and objects.
+ keys: [
+ {name: "title", weight: 0.8},
+ {name: "contents", weight: 0.7},
+ // {name: "tags", weight: 0.95},
+ // {name: "categories", weight: 0.05}
+ ],
+ // --- Fuzzy Matching Options
+ // Determines approximately where in the text is the pattern expected to be found.
+ location: 0,
+ // At what point does the match algorithm give up.
+ // A threshold of 0.0 requires a perfect match (of both letters and location),
+ // a threshold of 1.0 would match anything.
+ threshold: 0.2,
+ // Determines how close the match must be to the fuzzy location (specified by location).
+ // An exact letter match which is distance characters away from the fuzzy location would
+ // score as a complete mismatch. A distance of 0 requires the match be at the exact
+ // location specified. A distance of 1000 would require a perfect match to be within 800
+ // characters of the location to be found using a threshold of 0.8.
+ distance: 100,
+ // When true, search will ignore location and distance, so it won't matter where in
+ // the string the pattern appears.
+ //
+ // NOTE: These settings are used to calculate the Fuzziness Score (Bitap algorithm) in Fuse.js.
+ // It calculates threshold (default 0.6) * distance (default (100), which gives 60 by
+ // default, meaning it will search for the query-term within 60 characters from the location
+ // (default 0). Since Jena docs may have very long text that includes the query term anywhere
+ // we disable it with ignoreLocation: true.
+ // For more: https://fusejs.io/concepts/scoring-theory.html#scoring-theory
+ ignoreLocation: true,
Review Comment:
@afs Fuse.js uses the location of the match in its algorithm, which IMO doesn't make much sense for our use case. For example, by default it excludes documents that have the search match appearing 60 after the initial 60 characters.
The setting above disables it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jena-site] leeoniya commented on pull request #146: Add basic search with Fuse.js (search engine), Mark.js (word highlighter) and Hugo (search index)
Posted by "leeoniya (via GitHub)" <gi...@apache.org>.
leeoniya commented on PR #146:
URL: https://github.com/apache/jena-site/pull/146#issuecomment-1437082828
> in case we ever need to switch JS search libraries
this could save you some time: https://github.com/leeoniya/uFuzzy#a-biased-appraisal-of-similar-work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jena-site] afs commented on pull request #146: Add basic search with Fuse.js (search engine), Mark.js (word highlighter) and Hugo (search index)
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on PR #146:
URL: https://github.com/apache/jena-site/pull/146#issuecomment-1500603919
I don't think "staging" works. They were pre-Hugo.
If it merged to main, then it's jena.apache.org - I see
7905e130d Add basic search with Fuse.js ... in git.
On Jenkins there is
https://ci-builds.apache.org/job/Jena/job/Jena_Site2/job/main/213/console
which has a build failure.
Error: Error building site: failed to render pages: render of "home" failed: "/home/jenkins/712657a4/workspace/Jena_Jena_Site2_main/layouts/_default/index.json:7:28": execute of template failed: template: _default/index.json:7:28: executing "_default/index.json" at <uniq>: error calling uniq: elements must be comparable
which I do not understand.
I tried again - same thing.
https://ci-builds.apache.org/job/Jena/job/Jena_Site2/job/main/
My hugo is hugo v0.111.3
hugo version is the Jenkinsfile at top of jena-site:main is 0.66.0
so my guess is hugo version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jena-site] kinow commented on pull request #146: Add basic search with Fuse.js (search engine), Mark.js (word highlighter) and Hugo (search index)
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on PR #146:
URL: https://github.com/apache/jena-site/pull/146#issuecomment-1427032914
>I searched for "SHACL" (browser = Firefox) but it stays on "Loading ..."
I just looked at my local working copy, and I did a `git commit -am ...` and then left, without noticing that I forgot to add two new files :laughing: sorry.
New commit will push these missing files and this Loading... should either disappear very quickly or not even be visible (running locally Fuse.js renders so fast I cannot see the message).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jena-site] kinow commented on pull request #146: Add basic search with Fuse.js (search engine), Mark.js (word highlighter) and Hugo (search index)
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on PR #146:
URL: https://github.com/apache/jena-site/pull/146#issuecomment-1427034886
>When the screen size is a bit bigger than small the alignment goes wonky:
Oh, that happens if I remove the search field too :disappointed_relieved: let me take a look and see if I can find a solution for this...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jena-site] kinow commented on pull request #146: Add basic search with Fuse.js (search engine), Mark.js (word highlighter) and Hugo (search index)
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on PR #146:
URL: https://github.com/apache/jena-site/pull/146#issuecomment-1445423471
>this could save you some time: https://github.com/leeoniya/uFuzzy#a-biased-appraisal-of-similar-work
Thanks @leeoniya. Will keep that in mind if we have issues with Fuse.js and need to pick another library. For the moment Fuse.js seems to be OK :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jena-site] afs commented on pull request #146: Add basic search with Fuse.js (search engine), Mark.js (word highlighter) and Hugo (search index)
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on PR #146:
URL: https://github.com/apache/jena-site/pull/146#issuecomment-1500679225
Hugo isn't installed on the Jenkins nodes - it's pulled each time.
This is controlled by [jena-site/Jenkinsfile](https://github.com/apache/jena-site/blob/main/Jenkinsfile).
The version number is [Jenkinsfile#L26](https://github.com/apache/jena-site/blob/dd32b8a44ec71ba8bc94424da9e55d2b82b5f12e/Jenkinsfile#L26) and hugo is downloaded at [Jenkinsfile#L43](https://github.com/apache/jena-site/blob/dd32b8a44ec71ba8bc94424da9e55d2b82b5f12e/Jenkinsfile#L43).
Edit and commit!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org