You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hugegraph.apache.org by "afterimagex (via GitHub)" <gi...@apache.org> on 2024/08/12 12:12:32 UTC

[PR] feat(client): Implement new api & optimize code structure [incubator-hugegraph-ai]

afterimagex opened a new pull request, #63:
URL: https://github.com/apache/incubator-hugegraph-ai/pull/63

- Enhanced Naming Convention Support: Introduced support for underscore-named function calls in addition to existing camelCase naming convention. This allows for greater flexibility and compatibility with different coding styles and external libraries.

- Expanded index_label Types: Augmented the index_label functionality by adding support for shard and unique types. These additional types provide enhanced indexing capabilities that enable more sophisticated data organization and retrieval scenarios, improving overall performance and scalability.

- New Rank API Implementation: Implemented a new rank API to support ranking and sorting of data based on specified criteria. This feature enables applications to easily incorporate ranking logic into their workflows, enhancing user experience by presenting the most relevant or prioritized information first.

- Optimized HTTP Invocation and Response Handling: Refactored HTTP client invocations to utilize a more streamlined approach. Introduced ResponseValidation for managing response checks, effectively reducing the need for explicit check_if_success calls in multiple locations. This optimization not only simplifies code but also enhances its maintainability and readability, making it easier to identify and resolve potential issues related to HTTP response handling.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org

Re: [PR] feat(client): Implement new api & optimize code structure [incubator-hugegraph-ai]

Posted by "afterimagex (via GitHub)" <gi...@apache.org>.

afterimagex commented on code in PR #63:
URL: https://github.com/apache/incubator-hugegraph-ai/pull/63#discussion_r1714766383


##########
hugegraph-python-client/src/pyhugegraph/utils/log.py:
##########
@@ -46,7 +48,7 @@ class CustomConsoleHandler(logging.StreamHandler):
             "INFO": "\033[0;32m",  # Green
             "WARNING": "\033[0;33m",  # Yellow
             "ERROR": "\033[0;31m",  # Red
-            "CRITICAL": "\033[0;41m"  # Red background
+            "CRITICAL": "\033[0;41m",  # Red background

Review Comment:
   black-formatter



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org

Re: [PR] feat(client): Implement new api & optimize code structure [incubator-hugegraph-ai]

Posted by "imbajin (via GitHub)" <gi...@apache.org>.

imbajin merged PR #63:
URL: https://github.com/apache/incubator-hugegraph-ai/pull/63


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org

Re: [PR] feat(client): Implement new api & optimize code structure [incubator-hugegraph-ai]

Posted by "imbajin (via GitHub)" <gi...@apache.org>.

imbajin commented on code in PR #63:
URL: https://github.com/apache/incubator-hugegraph-ai/pull/63#discussion_r1714748565


##########
hugegraph-python-client/README.md:
##########


Review Comment:
   Could also add the cmd for
   ```markdown
   ### Install from source
   release soon
   ```
   <img width="756" alt="image" src="https://github.com/user-attachments/assets/d829e419-bc9d-41a5-8c9a-f6c64c1f4641">
   



##########
hugegraph-python-client/src/pyhugegraph/utils/log.py:
##########
@@ -46,7 +48,7 @@ class CustomConsoleHandler(logging.StreamHandler):
             "INFO": "\033[0;32m",  # Green
             "WARNING": "\033[0;33m",  # Yellow
             "ERROR": "\033[0;31m",  # Red
-            "CRITICAL": "\033[0;41m"  # Red background
+            "CRITICAL": "\033[0;41m",  # Red background

Review Comment:
   Extra  `,`?



##########
hugegraph-python-client/README.md:
##########
@@ -17,7 +17,7 @@ release soon
 ```python
 from pyhugegraph.client import PyHugeClient
 
-client = PyHugeClient("127.0.0.1", "8080", user="admin", pwd="admin", graph="hugegraph")
+client = PyHugeClient("127.0.0.1", "8080", user="admin", pwd="admin", graph="hugegraph", gs="DEFAULT")

Review Comment:
   - add a comment for this line (like `gs` is optional)
   - currently `gs` compatible with `graphspace`? (set as alias) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org

Re: [PR] feat(client): Implement new api & optimize code structure [incubator-hugegraph-ai]

Posted by "imbajin (via GitHub)" <gi...@apache.org>.

imbajin commented on code in PR #63:
URL: https://github.com/apache/incubator-hugegraph-ai/pull/63#discussion_r1714783858


##########
hugegraph-python-client/src/pyhugegraph/utils/log.py:
##########
@@ -46,7 +48,7 @@ class CustomConsoleHandler(logging.StreamHandler):
             "INFO": "\033[0;32m",  # Green
             "WARNING": "\033[0;33m",  # Yellow
             "ERROR": "\033[0;31m",  # Red
-            "CRITICAL": "\033[0;41m"  # Red background
+            "CRITICAL": "\033[0;41m",  # Red background

Review Comment:
   > black-formatter
   
   OK, just keep it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org