You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/25 21:40:35 UTC
[GitHub] [arrow-rs] alamb opened a new pull request #360: Disable MIRI check until it runs cleanly on CI
alamb opened a new pull request #360:
URL: https://github.com/apache/arrow-rs/pull/360
# Which issue does this PR close?
Related to https://github.com/apache/arrow-rs/issues/345 (but doesn't fix the underlying issue)
# Rationale for this change
The MIRI checks enabled in https://github.com/apache/arrow-rs/pull/323 have been failing frequently with false positives on PRs and master. Until they run cleanly and only fail when there are actual problems, running these CI checks on all PRs is slowing everyone down and causing confusion,
# What changes are included in this PR?
1. Disable MIRI check on CI
I disabled the whole thing this time, whereas prior to https://github.com/apache/arrow-rs/pull/323 they "ran" but the results were not checked. That seems like a waste of CPU time / github actions credits to me.
# Are there any user-facing changes?
Hopefully contributors' PRs will stop getting failing checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #360: Disable MIRI check until it runs cleanly on CI
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #360:
URL: https://github.com/apache/arrow-rs/pull/360#issuecomment-848286032
The MIRI failure is unrelated to this PR: https://github.com/apache/arrow-rs/issues/345
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb removed a comment on pull request #360: Disable MIRI check until it runs cleanly on CI
Posted by GitBox <gi...@apache.org>.
alamb removed a comment on pull request #360:
URL: https://github.com/apache/arrow-rs/pull/360#issuecomment-848286032
The MIRI failure is unrelated to this PR: https://github.com/apache/arrow-rs/issues/345
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] jorgecarleitao merged pull request #360: Disable MIRI check until it runs cleanly on CI
Posted by GitBox <gi...@apache.org>.
jorgecarleitao merged pull request #360:
URL: https://github.com/apache/arrow-rs/pull/360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #360: Disable MIRI check until it runs cleanly on CI
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #360:
URL: https://github.com/apache/arrow-rs/pull/360#issuecomment-849081399
I think @roee88 has found the root cause: https://github.com/apache/arrow-rs/issues/345#issuecomment-849055081 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #360: Disable MIRI check until it runs cleanly on CI
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #360:
URL: https://github.com/apache/arrow-rs/pull/360#issuecomment-848285105
cc @roee88 @vertexclique
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org