You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by md...@apache.org on 2016/05/09 15:00:51 UTC

svn commit: r1742974 - /jackrabbit/oak/trunk/oak-segment-tar/src/test/java/org/apache/jackrabbit/oak/segment/RecordTest.java

Author: mduerig
Date: Mon May  9 15:00:51 2016
New Revision: 1742974

URL: http://svn.apache.org/viewvc?rev=1742974&view=rev
Log:
OAK-4353: IndexOutOfBoundsException in FileStore.writeStream
@Ignored test case

Modified:
    jackrabbit/oak/trunk/oak-segment-tar/src/test/java/org/apache/jackrabbit/oak/segment/RecordTest.java

Modified: jackrabbit/oak/trunk/oak-segment-tar/src/test/java/org/apache/jackrabbit/oak/segment/RecordTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-segment-tar/src/test/java/org/apache/jackrabbit/oak/segment/RecordTest.java?rev=1742974&r1=1742973&r2=1742974&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-segment-tar/src/test/java/org/apache/jackrabbit/oak/segment/RecordTest.java (original)
+++ jackrabbit/oak/trunk/oak-segment-tar/src/test/java/org/apache/jackrabbit/oak/segment/RecordTest.java Mon May  9 15:00:51 2016
@@ -50,27 +50,35 @@ import com.google.common.collect.Immutab
 import org.apache.jackrabbit.oak.api.Blob;
 import org.apache.jackrabbit.oak.api.CommitFailedException;
 import org.apache.jackrabbit.oak.api.PropertyState;
+import org.apache.jackrabbit.oak.segment.file.FileStore;
 import org.apache.jackrabbit.oak.segment.memory.MemoryStore;
 import org.apache.jackrabbit.oak.spi.commit.CommitInfo;
 import org.apache.jackrabbit.oak.spi.commit.EmptyHook;
 import org.apache.jackrabbit.oak.spi.state.NodeBuilder;
 import org.apache.jackrabbit.oak.spi.state.NodeState;
+import org.junit.Before;
+import org.junit.Ignore;
+import org.junit.Rule;
 import org.junit.Test;
+import org.junit.rules.TemporaryFolder;
 
 public class RecordTest {
+    @Rule
+    public TemporaryFolder folder = new TemporaryFolder();
 
-    private final String hello = "Hello, World!";
+    private static final String HELLO_WORLD = "Hello, World!";
 
-    private final byte[] bytes = hello.getBytes(Charsets.UTF_8);
+    private final byte[] bytes = HELLO_WORLD.getBytes(Charsets.UTF_8);
 
-    private final SegmentStore store;
+    private SegmentStore store;
 
-    private final SegmentWriter writer;
+    private SegmentWriter writer;
 
     private final Random random = new Random(0xcafefaceL);
 
-    public RecordTest() throws IOException {
-        store = new MemoryStore();
+    @Before
+    public void setup() throws IOException {
+        store = FileStore.builder(folder.getRoot()).build();
         writer = store.getTracker().getWriter();
     }
 
@@ -84,14 +92,14 @@ public class RecordTest {
             for (int i = 0; i + n <= bytes.length; i++) {
                 Arrays.fill(bytes, i, i + n, (byte) '.');
                 assertEquals(n, block.read(i, bytes, i, n));
-                assertEquals(hello, new String(bytes, Charsets.UTF_8));
+                assertEquals(HELLO_WORLD, new String(bytes, Charsets.UTF_8));
             }
         }
 
         // Check reading with a too long length
         byte[] large = new byte[bytes.length * 2];
         assertEquals(bytes.length, block.read(0, large, 0, large.length));
-        assertEquals(hello, new String(large, 0, bytes.length, Charsets.UTF_8));
+        assertEquals(HELLO_WORLD, new String(large, 0, bytes.length, Charsets.UTF_8));
     }
 
     @Test
@@ -144,6 +152,7 @@ public class RecordTest {
     }
 
     @Test
+    @Ignore("OAK-4353")  // FIXME OAK-4353: IndexOutOfBoundsException in FileStore.writeStream
     public void testStreamRecord() throws IOException {
         checkRandomStreamRecord(0);
         checkRandomStreamRecord(1);