You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Surkov Aleksandr (Jira)" <ji...@apache.org> on 2020/05/22 14:57:00 UTC

[jira] [Updated] (IGNITE-12376) Change level of "TCP client created ..." log messages to WARN

     [ https://issues.apache.org/jira/browse/IGNITE-12376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Surkov Aleksandr updated IGNITE-12376:
--------------------------------------
    Description: 
Log messages generated when createTcpClient takes more than CONNECTION_ESTABLISH_THRESHOLD_MS (100 by default) has INFO level.

It seems it should be changed to WARN level and message text needs to be changed for better understanding. 

Message sample (current):

~{{2019-11-11 11:11:11.567[INFO ]tcp-comm-worker-nodename[o.a.i.s.c.tcp.TcpCommunicationSpi] TCP client created [client=GridTcpNioCommunicationClient... <output truncated> ]], duration=1234ms]}}~

 

Proposed format:

~{{2019-11-11 11:11:11.567[{color:#ff8b00}WARN{color} ]tcp-comm-worker-nodename[o.a.i.s.c.tcp.TcpCommunicationSpi] {color:#ff8b00}TCP client creation took longer than expected {color}[{color:#ff8b00}threshold=100ms{color}, client=GridTcpNioCommunicationClient... <output truncated> ]], duration=1234ms]}}~

 

  was:
Log messages generated when createTcpClient takes more than CONNECTION_ESTABLISH_THRESHOLD_MS (100 by default) has INFO level.

It seems it should be changed to WARN level and message text needs to be changed for better understanding. 

Message sample (current):

~{{2019-11-11 11:11:11.567[INFO ]tcp-comm-worker-nodename[o.a.i.s.c.tcp.TcpCommunicationSpi] TCP client created [client=GridTcpNioCommunicationClient... <output truncated> ]], duration=1234ms]}}~

 

Proposed format:

~{{2019-11-11 11:11:11.567[{color:#ff8b00}WARN{color} ]tcp-comm-worker-nodename[o.a.i.s.c.tcp.TcpCommunicationSpi] {color:#ff8b00}Long TCP client creation time{color} [{color:#ff8b00}threshold=100ms{color}, client=GridTcpNioCommunicationClient... <output truncated> ]], duration=1234ms]}}~

 


> Change level of "TCP client created ..." log messages to WARN
> -------------------------------------------------------------
>
>                 Key: IGNITE-12376
>                 URL: https://issues.apache.org/jira/browse/IGNITE-12376
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Ruslan Kuzmin
>            Assignee: Surkov Aleksandr
>            Priority: Minor
>              Labels: newbie
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Log messages generated when createTcpClient takes more than CONNECTION_ESTABLISH_THRESHOLD_MS (100 by default) has INFO level.
> It seems it should be changed to WARN level and message text needs to be changed for better understanding. 
> Message sample (current):
> ~{{2019-11-11 11:11:11.567[INFO ]tcp-comm-worker-nodename[o.a.i.s.c.tcp.TcpCommunicationSpi] TCP client created [client=GridTcpNioCommunicationClient... <output truncated> ]], duration=1234ms]}}~
>  
> Proposed format:
> ~{{2019-11-11 11:11:11.567[{color:#ff8b00}WARN{color} ]tcp-comm-worker-nodename[o.a.i.s.c.tcp.TcpCommunicationSpi] {color:#ff8b00}TCP client creation took longer than expected {color}[{color:#ff8b00}threshold=100ms{color}, client=GridTcpNioCommunicationClient... <output truncated> ]], duration=1234ms]}}~
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)