You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by "Richard Liang (JIRA)" <ji...@apache.org> on 2006/02/22 03:31:38 UTC
[jira] Created: (HARMONY-113) java.nio.charset.Charset should
regard empty charset name properly as Illegal CharsetName
java.nio.charset.Charset should regard empty charset name properly as Illegal CharsetName
-----------------------------------------------------------------------------------------
Key: HARMONY-113
URL: http://issues.apache.org/jira/browse/HARMONY-113
Project: Harmony
Type: Bug
Components: Classlib
Reporter: Richard Liang
I think it's caused by the different between RI 1.4.2 and RI 5.0. Three test cases in JIRA#57 should be updated accordingly.
public void testIsSupported_EmptyString() {
try {
Charset.isSupported("");
fail("Should throw IllegalCharsetNameException!");
} catch (IllegalCharsetNameException e) {
//
}
}
public void testConstructor_EmptyCanonicalName() {
try {
new MockCharset("", new String[0]);
fail("Should throw IllegalCharsetNameException!");
} catch (IllegalCharsetNameException e) {
//
}
}
public void testConstructor_EmptyAliases() {
try {
new MockCharset("mockChar", new String[] { "" });
fail("Should throw IllegalCharsetNameException!");
} catch (IllegalCharsetNameException e) {
//
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-113) java.nio.charset.Charset should
regard empty charset name properly as Illegal CharsetName
Posted by "Richard Liang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-113?page=comments#action_12367618 ]
Richard Liang commented on HARMONY-113:
---------------------------------------
Yes, Tim.
I think you can fix this issue. I will verify your update after you mark this issue as fixed. When JIRA57 is acceptted I will create patch for the test cases, otherwise there may be duplication. :-)
Thanks a lot.
> java.nio.charset.Charset should regard empty charset name properly as Illegal CharsetName
> -----------------------------------------------------------------------------------------
>
> Key: HARMONY-113
> URL: http://issues.apache.org/jira/browse/HARMONY-113
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Richard Liang
> Attachments: charset_patch.txt
>
> I think it's caused by the different between RI 1.4.2 and RI 5.0. Three test cases in JIRA#57 should be updated accordingly.
> public void testIsSupported_EmptyString() {
> try {
> Charset.isSupported("");
> fail("Should throw IllegalCharsetNameException!");
> } catch (IllegalCharsetNameException e) {
> //
> }
> }
> public void testConstructor_EmptyCanonicalName() {
> try {
> new MockCharset("", new String[0]);
> fail("Should throw IllegalCharsetNameException!");
> } catch (IllegalCharsetNameException e) {
> //
> }
> }
> public void testConstructor_EmptyAliases() {
> try {
> new MockCharset("mockChar", new String[] { "" });
> fail("Should throw IllegalCharsetNameException!");
> } catch (IllegalCharsetNameException e) {
> //
> }
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-113) java.nio.charset.Charset should
regard empty charset name properly as Illegal CharsetName
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-113?page=all ]
Tim Ellison reassigned HARMONY-113:
-----------------------------------
Assign To: Tim Ellison
> java.nio.charset.Charset should regard empty charset name properly as Illegal CharsetName
> -----------------------------------------------------------------------------------------
>
> Key: HARMONY-113
> URL: http://issues.apache.org/jira/browse/HARMONY-113
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Richard Liang
> Assignee: Tim Ellison
> Attachments: charset_patch.txt
>
> I think it's caused by the different between RI 1.4.2 and RI 5.0. Three test cases in JIRA#57 should be updated accordingly.
> public void testIsSupported_EmptyString() {
> try {
> Charset.isSupported("");
> fail("Should throw IllegalCharsetNameException!");
> } catch (IllegalCharsetNameException e) {
> //
> }
> }
> public void testConstructor_EmptyCanonicalName() {
> try {
> new MockCharset("", new String[0]);
> fail("Should throw IllegalCharsetNameException!");
> } catch (IllegalCharsetNameException e) {
> //
> }
> }
> public void testConstructor_EmptyAliases() {
> try {
> new MockCharset("mockChar", new String[] { "" });
> fail("Should throw IllegalCharsetNameException!");
> } catch (IllegalCharsetNameException e) {
> //
> }
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-113) java.nio.charset.Charset should
regard empty charset name properly as Illegal CharsetName
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-113?page=all ]
Tim Ellison resolved HARMONY-113:
---------------------------------
Resolution: Fixed
Richard,
Thanks for the patch, which looks ok.
Applied in NIO_CHAR module java.nio.Charset at repo revision 380635.
I have only used a subset of the tests that you provided, since there is no definition for MockCharset.
Please check that the patch was applied as you expected.
> java.nio.charset.Charset should regard empty charset name properly as Illegal CharsetName
> -----------------------------------------------------------------------------------------
>
> Key: HARMONY-113
> URL: http://issues.apache.org/jira/browse/HARMONY-113
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Richard Liang
> Assignee: Tim Ellison
> Attachments: charset_patch.txt
>
> I think it's caused by the different between RI 1.4.2 and RI 5.0. Three test cases in JIRA#57 should be updated accordingly.
> public void testIsSupported_EmptyString() {
> try {
> Charset.isSupported("");
> fail("Should throw IllegalCharsetNameException!");
> } catch (IllegalCharsetNameException e) {
> //
> }
> }
> public void testConstructor_EmptyCanonicalName() {
> try {
> new MockCharset("", new String[0]);
> fail("Should throw IllegalCharsetNameException!");
> } catch (IllegalCharsetNameException e) {
> //
> }
> }
> public void testConstructor_EmptyAliases() {
> try {
> new MockCharset("mockChar", new String[] { "" });
> fail("Should throw IllegalCharsetNameException!");
> } catch (IllegalCharsetNameException e) {
> //
> }
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-113) java.nio.charset.Charset should regard
empty charset name properly as Illegal CharsetName
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-113?page=all ]
Tim Ellison closed HARMONY-113:
-------------------------------
Verified by Richard
> java.nio.charset.Charset should regard empty charset name properly as Illegal CharsetName
> -----------------------------------------------------------------------------------------
>
> Key: HARMONY-113
> URL: http://issues.apache.org/jira/browse/HARMONY-113
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Richard Liang
> Assignee: Tim Ellison
> Attachments: charset_patch.txt
>
> I think it's caused by the different between RI 1.4.2 and RI 5.0. Three test cases in JIRA#57 should be updated accordingly.
> public void testIsSupported_EmptyString() {
> try {
> Charset.isSupported("");
> fail("Should throw IllegalCharsetNameException!");
> } catch (IllegalCharsetNameException e) {
> //
> }
> }
> public void testConstructor_EmptyCanonicalName() {
> try {
> new MockCharset("", new String[0]);
> fail("Should throw IllegalCharsetNameException!");
> } catch (IllegalCharsetNameException e) {
> //
> }
> }
> public void testConstructor_EmptyAliases() {
> try {
> new MockCharset("mockChar", new String[] { "" });
> fail("Should throw IllegalCharsetNameException!");
> } catch (IllegalCharsetNameException e) {
> //
> }
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-113) java.nio.charset.Charset should
regard empty charset name properly as Illegal CharsetName
Posted by "Richard Liang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-113?page=all ]
Richard Liang updated HARMONY-113:
----------------------------------
Attachment: charset_patch.txt
Please try my patch. Thanks a lot.
> java.nio.charset.Charset should regard empty charset name properly as Illegal CharsetName
> -----------------------------------------------------------------------------------------
>
> Key: HARMONY-113
> URL: http://issues.apache.org/jira/browse/HARMONY-113
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Richard Liang
> Attachments: charset_patch.txt
>
> I think it's caused by the different between RI 1.4.2 and RI 5.0. Three test cases in JIRA#57 should be updated accordingly.
> public void testIsSupported_EmptyString() {
> try {
> Charset.isSupported("");
> fail("Should throw IllegalCharsetNameException!");
> } catch (IllegalCharsetNameException e) {
> //
> }
> }
> public void testConstructor_EmptyCanonicalName() {
> try {
> new MockCharset("", new String[0]);
> fail("Should throw IllegalCharsetNameException!");
> } catch (IllegalCharsetNameException e) {
> //
> }
> }
> public void testConstructor_EmptyAliases() {
> try {
> new MockCharset("mockChar", new String[] { "" });
> fail("Should throw IllegalCharsetNameException!");
> } catch (IllegalCharsetNameException e) {
> //
> }
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-113) java.nio.charset.Charset should
regard empty charset name properly as Illegal CharsetName
Posted by "Richard Liang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-113?page=comments#action_12367897 ]
Richard Liang commented on HARMONY-113:
---------------------------------------
Yes, Tim. The patch looks good.
> java.nio.charset.Charset should regard empty charset name properly as Illegal CharsetName
> -----------------------------------------------------------------------------------------
>
> Key: HARMONY-113
> URL: http://issues.apache.org/jira/browse/HARMONY-113
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Richard Liang
> Assignee: Tim Ellison
> Attachments: charset_patch.txt
>
> I think it's caused by the different between RI 1.4.2 and RI 5.0. Three test cases in JIRA#57 should be updated accordingly.
> public void testIsSupported_EmptyString() {
> try {
> Charset.isSupported("");
> fail("Should throw IllegalCharsetNameException!");
> } catch (IllegalCharsetNameException e) {
> //
> }
> }
> public void testConstructor_EmptyCanonicalName() {
> try {
> new MockCharset("", new String[0]);
> fail("Should throw IllegalCharsetNameException!");
> } catch (IllegalCharsetNameException e) {
> //
> }
> }
> public void testConstructor_EmptyAliases() {
> try {
> new MockCharset("mockChar", new String[] { "" });
> fail("Should throw IllegalCharsetNameException!");
> } catch (IllegalCharsetNameException e) {
> //
> }
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-113) java.nio.charset.Charset should
regard empty charset name properly as Illegal CharsetName
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-113?page=comments#action_12367498 ]
Tim Ellison commented on HARMONY-113:
-------------------------------------
Richard,
The tests you provide above are dependent upon the HARMONY-57 code being incorporated into the project.
Would you like to submit stand-alone test cases? or if you prefer I can mark this fix as dependent upon HARMONY-57.
Regards,
Tim
> java.nio.charset.Charset should regard empty charset name properly as Illegal CharsetName
> -----------------------------------------------------------------------------------------
>
> Key: HARMONY-113
> URL: http://issues.apache.org/jira/browse/HARMONY-113
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Richard Liang
> Attachments: charset_patch.txt
>
> I think it's caused by the different between RI 1.4.2 and RI 5.0. Three test cases in JIRA#57 should be updated accordingly.
> public void testIsSupported_EmptyString() {
> try {
> Charset.isSupported("");
> fail("Should throw IllegalCharsetNameException!");
> } catch (IllegalCharsetNameException e) {
> //
> }
> }
> public void testConstructor_EmptyCanonicalName() {
> try {
> new MockCharset("", new String[0]);
> fail("Should throw IllegalCharsetNameException!");
> } catch (IllegalCharsetNameException e) {
> //
> }
> }
> public void testConstructor_EmptyAliases() {
> try {
> new MockCharset("mockChar", new String[] { "" });
> fail("Should throw IllegalCharsetNameException!");
> } catch (IllegalCharsetNameException e) {
> //
> }
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-113) java.nio.charset.Charset should
regard empty charset name properly as Illegal CharsetName
Posted by "Richard Liang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-113?page=comments#action_12367454 ]
Richard Liang commented on HARMONY-113:
---------------------------------------
I'v forgotten to say the test cases above pass on RI 5.0
> java.nio.charset.Charset should regard empty charset name properly as Illegal CharsetName
> -----------------------------------------------------------------------------------------
>
> Key: HARMONY-113
> URL: http://issues.apache.org/jira/browse/HARMONY-113
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Richard Liang
> Attachments: charset_patch.txt
>
> I think it's caused by the different between RI 1.4.2 and RI 5.0. Three test cases in JIRA#57 should be updated accordingly.
> public void testIsSupported_EmptyString() {
> try {
> Charset.isSupported("");
> fail("Should throw IllegalCharsetNameException!");
> } catch (IllegalCharsetNameException e) {
> //
> }
> }
> public void testConstructor_EmptyCanonicalName() {
> try {
> new MockCharset("", new String[0]);
> fail("Should throw IllegalCharsetNameException!");
> } catch (IllegalCharsetNameException e) {
> //
> }
> }
> public void testConstructor_EmptyAliases() {
> try {
> new MockCharset("mockChar", new String[] { "" });
> fail("Should throw IllegalCharsetNameException!");
> } catch (IllegalCharsetNameException e) {
> //
> }
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira