You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/06/16 07:32:12 UTC

[GitHub] [zeppelin] Reamer commented on a change in pull request #4135: [ZEPPELIN-5290] NPE on empty dynamic form input

Reamer commented on a change in pull request #4135:
URL: https://github.com/apache/zeppelin/pull/4135#discussion_r652425047



##########
File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/display/Input.java
##########
@@ -373,7 +373,11 @@ public static String getSimpleQuery(Map<String, Object> params, String script, b
         }
       } else {
         // single-selection
-        expanded = value.toString();
+        if (value == null) {

Review comment:
       [StringUtils.defaultString](http://commons.apache.org/proper/commons-lang/javadocs/api-3.1/org/apache/commons/lang3/StringUtils.html#defaultString%28java.lang.String%29) looks more elegant.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org