You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "dweiss (via GitHub)" <gi...@apache.org> on 2024/09/05 20:12:35 UTC
[PR] jgit/ clean status check should ignore any 'untracked folders' [lucene]
dweiss opened a new pull request, #13728:
URL: https://github.com/apache/lucene/pull/13728
Fixes #13719.
We can't easily determine whether an "untracked folder" contains something that is .gitignored and currently we report the status as dirty (contrary to what git --porcelain says). This patch just removes all the "untracked folders" logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] jgit/ clean status check should ignore any 'untracked folders' [lucene]
Posted by "uschindler (via GitHub)" <gi...@apache.org>.
uschindler commented on PR #13728:
URL: https://github.com/apache/lucene/pull/13728#issuecomment-2333707595
Thanks. I wasn't aware of this extra File walk. Who added this? Thanks for removing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] jgit/ clean status check should ignore any 'untracked folders' [lucene]
Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on PR #13728:
URL: https://github.com/apache/lucene/pull/13728#issuecomment-2333765565
> Thanks. I wasn't aware of this extra File walk. Who added this? Thanks for removing it.
Can't remember. Could have been me. Clearly not working in all cases though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] jgit/ clean status check should ignore any 'untracked folders' [lucene]
Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on PR #13728:
URL: https://github.com/apache/lucene/pull/13728#issuecomment-2332594641
I'll merge this tomorrow and backport to 9x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] jgit/ clean status check should ignore any 'untracked folders' [lucene]
Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss merged PR #13728:
URL: https://github.com/apache/lucene/pull/13728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org