You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/07/05 04:51:09 UTC
[GitHub] [dolphinscheduler] ruanwenjun opened a new issue, #10785: [Bug] [Master] State event handle error will not retry
ruanwenjun opened a new issue, #10785:
URL: https://github.com/apache/dolphinscheduler/issues/10785
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
Right now, when we deal the state change event, we will not retry in some case, due to we catch the state handle error exception, and don't rethrow it.
e.g.
https://github.com/apache/dolphinscheduler/blob/7d79a2165ee5f0bf1aa7c949c852da179d6c0cc9/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java#L700-L726
When we update the processInstance failed, we shouldn't catch the exception
And when we update the status to database, we need to recover the status in memory, when update to db failed.
### What you expected to happen
xx
### How to reproduce
When the database restart, the workflow status will incorrect.
### Anything else
_No response_
### Version
dev
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun closed issue #10785: [Bug] [Master] State event handle error will not retry
Posted by GitBox <gi...@apache.org>.
ruanwenjun closed issue #10785: [Bug] [Master] State event handle error will not retry
URL: https://github.com/apache/dolphinscheduler/issues/10785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #10785: [Bug] [Master] State event handle error will not retry
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #10785:
URL: https://github.com/apache/dolphinscheduler/issues/10785#issuecomment-1174609517
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org