You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Jonathan Gray (JIRA)" <ji...@apache.org> on 2009/06/14 01:02:07 UTC

[jira] Created: (HBASE-1516) Investigate if StoreScanner will not return the next row if earlied-out of previous row

Investigate if StoreScanner will not return the next row if earlied-out of previous row
---------------------------------------------------------------------------------------

                 Key: HBASE-1516
                 URL: https://issues.apache.org/jira/browse/HBASE-1516
             Project: Hadoop HBase
          Issue Type: Bug
          Components: regionserver
    Affects Versions: 0.20.0
            Reporter: Jonathan Gray
            Assignee: Jonathan Gray
             Fix For: 0.20.0


StoreScanner line 122 states:

    // this wont get us the next row if the previous round hasn't iterated
    // past all the cols from the previous row. Potential bug!

Investigate whether this is a bug or not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1516) Investigate if StoreScanner will not return the next row if earlied-out of previous row

Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Gray updated HBASE-1516:
---------------------------------

    Status: Patch Available  (was: Reopened)

> Investigate if StoreScanner will not return the next row if earlied-out of previous row
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-1516
>                 URL: https://issues.apache.org/jira/browse/HBASE-1516
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.20.0
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1516-v1.patch
>
>
> StoreScanner line 122 states:
>     // this wont get us the next row if the previous round hasn't iterated
>     // past all the cols from the previous row. Potential bug!
> Investigate whether this is a bug or not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (HBASE-1516) Investigate if StoreScanner will not return the next row if earlied-out of previous row

Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Gray reopened HBASE-1516:
----------------------------------


> Investigate if StoreScanner will not return the next row if earlied-out of previous row
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-1516
>                 URL: https://issues.apache.org/jira/browse/HBASE-1516
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.20.0
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>             Fix For: 0.20.0
>
>
> StoreScanner line 122 states:
>     // this wont get us the next row if the previous round hasn't iterated
>     // past all the cols from the previous row. Potential bug!
> Investigate whether this is a bug or not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1516) Investigate if StoreScanner will not return the next row if earlied-out of previous row

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719371#action_12719371 ] 

stack commented on HBASE-1516:
------------------------------

+1

> Investigate if StoreScanner will not return the next row if earlied-out of previous row
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-1516
>                 URL: https://issues.apache.org/jira/browse/HBASE-1516
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.20.0
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1516-v1.patch
>
>
> StoreScanner line 122 states:
>     // this wont get us the next row if the previous round hasn't iterated
>     // past all the cols from the previous row. Potential bug!
> Investigate whether this is a bug or not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1516) Investigate if StoreScanner will not return the next row if earlied-out of previous row

Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Gray updated HBASE-1516:
---------------------------------

    Attachment: HBASE-1516-v1.patch

Removes the comment.

> Investigate if StoreScanner will not return the next row if earlied-out of previous row
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-1516
>                 URL: https://issues.apache.org/jira/browse/HBASE-1516
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.20.0
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1516-v1.patch
>
>
> StoreScanner line 122 states:
>     // this wont get us the next row if the previous round hasn't iterated
>     // past all the cols from the previous row. Potential bug!
> Investigate whether this is a bug or not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-1516) Investigate if StoreScanner will not return the next row if earlied-out of previous row

Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12719369#action_12719369 ] 

ryan rawson commented on HBASE-1516:
------------------------------------

+1 I'll commit 

> Investigate if StoreScanner will not return the next row if earlied-out of previous row
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-1516
>                 URL: https://issues.apache.org/jira/browse/HBASE-1516
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.20.0
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1516-v1.patch
>
>
> StoreScanner line 122 states:
>     // this wont get us the next row if the previous round hasn't iterated
>     // past all the cols from the previous row. Potential bug!
> Investigate whether this is a bug or not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1516) Investigate if StoreScanner will not return the next row if earlied-out of previous row

Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ryan rawson updated HBASE-1516:
-------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

> Investigate if StoreScanner will not return the next row if earlied-out of previous row
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-1516
>                 URL: https://issues.apache.org/jira/browse/HBASE-1516
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.20.0
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1516-v1.patch
>
>
> StoreScanner line 122 states:
>     // this wont get us the next row if the previous round hasn't iterated
>     // past all the cols from the previous row. Potential bug!
> Investigate whether this is a bug or not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HBASE-1516) Investigate if StoreScanner will not return the next row if earlied-out of previous row

Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Gray resolved HBASE-1516.
----------------------------------

    Resolution: Invalid

Looks like this is not a bug because the StoreScanner doesn't use the DONE keyword unless you've reached the end.  Rather, it uses SEEK_NEXT_ROW to ensure that it is always seeked down to the next row.

This is correct behavior, but also potentially inefficient.  Need to implement shortcuts in HFile to allow skipping of blocks when available.  Opened HBASE-1517

> Investigate if StoreScanner will not return the next row if earlied-out of previous row
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-1516
>                 URL: https://issues.apache.org/jira/browse/HBASE-1516
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.20.0
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>             Fix For: 0.20.0
>
>
> StoreScanner line 122 states:
>     // this wont get us the next row if the previous round hasn't iterated
>     // past all the cols from the previous row. Potential bug!
> Investigate whether this is a bug or not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.