You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/23 15:56:02 UTC

[GitHub] [apisix] spacewander opened a new pull request #2507: change(batch-requests): limit the body size to 1M

spacewander opened a new pull request #2507:
URL: https://github.com/apache/apisix/pull/2507


   To avoid blocking on reading large body file and
   spending too much memory in encode JSON body.
   
   ### What this PR does / why we need it:
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   
   ### Pre-submission checklist:
   
   * [x] Did you explain what problem does this PR solve? Or what new features have been added?
   * [x] Have you added corresponding test cases?
   * [x] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis commented on a change in pull request #2507: change(batch-requests): limit the body size to 1M

Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #2507:
URL: https://github.com/apache/apisix/pull/2507#discussion_r511217172



##########
File path: apisix/core/request.lua
##########
@@ -16,12 +16,15 @@
 --
 
 local lfs = require("lfs")
+local log = require "apisix.core.log"

Review comment:
       code style: `require("****")`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander merged pull request #2507: change(batch-requests): limit the body size to 1M

Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #2507:
URL: https://github.com/apache/apisix/pull/2507


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis commented on pull request #2507: change(batch-requests): limit the body size to 1M

Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #2507:
URL: https://github.com/apache/apisix/pull/2507#issuecomment-715646887


   CI failed: https://github.com/apache/apisix/pull/2507/checks?check_run_id=1298927664#step:9:138
   
   ```
   #   Failed test 'TEST 57: route size more than 1.5 MiB - status code ok'
   #   at /home/runner/work/apisix/apisix/test-nginx/lib/Test/Nginx/Socket.pm line 935.
   #          got: '500'
   #     expected: '400'
   
   #   Failed test 'TEST 57: route size more than 1.5 MiB - response_body - response is expected (repeated req 0, req 0)'
   #   at /home/runner/work/apisix/apisix/test-nginx/lib/Test/Nginx/Socket.pm line 1589.
   #          got: '<html>
   # <head><title>500 Internal Server Error</title></head>
   # <body>
   # <center><h1>500 Internal Server Error</h1></center>
   # <hr><center>openresty/1.17.8.2</center>
   # </body>
   # </html>
   # '
   #     expected: '{"error_msg":"invalid request body: request size 1678025 is greater than the maximum size 1572864 allowed"}
   # '
   
   t/admin/routes.t .......................... 
   Dubious, test returned 3 (wstat 768, 0x300)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on a change in pull request #2507: change(batch-requests): limit the body size to 1M

Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #2507:
URL: https://github.com/apache/apisix/pull/2507#discussion_r511376740



##########
File path: apisix/core/request.lua
##########
@@ -16,12 +16,15 @@
 --
 
 local lfs = require("lfs")
+local log = require "apisix.core.log"

Review comment:
       @membphis 
   Updated




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org