You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by "Paul Kronenwetter (JIRA)" <ji...@apache.org> on 2007/04/16 00:24:15 UTC
[jira] Created: (FOR-990) PluginGallery misbehaves on images ending
with .JPG vs. .jpg.
PluginGallery misbehaves on images ending with .JPG vs. .jpg.
-------------------------------------------------------------
Key: FOR-990
URL: https://issues.apache.org/jira/browse/FOR-990
Project: Forrest
Issue Type: Bug
Components: Plugin: input.PhotoGallery
Affects Versions: 0.8-dev
Reporter: Paul Kronenwetter
Priority: Minor
Images ending with JPG do not receive equal treatment as those ending in jpg. Specifically {file}.small.jpg and {file}.thumb.jpg are not created for images ending in JPG. From CFAS's broken-links.xml:
<link message="/home/kronenpj/src/svn/cfas/src/documentation/content/xdocs/images/gallery/planet/mars20030710x.jpg (No such file or directory)" uri="/gallery/
planet/mars20030710x.thumb.jpg">
<referrer uri="/gallery/planet/index.html"/>
<referrer uri="/gallery/planet/index_1.html"/>
</link>
mars20030710x.JPG is the source file under xdocs/images/gallery/planet.
This is not the only example of where this occurs. I have the following {file}.JPG images in the PhotoGallery source directory and all of them exhibit similar errors in broken-links.xml:
./lunar/DSCF0023.JPG
./lunar/Mare_Australe_4.JPG
./lunar/DSCF0018.JPG
./planet/Venus.11.JPG
./planet/mars20030710x.JPG
./planet/mars20030726x.JPG
./messier/M16WH.JPG
./ngc/ngc2024.JPG
The workaround of course is to rename the source files. I don't believe it's the intention of the plugin to dictate the case-style for filenames. Also, converting a file to a different case on Windows is mildly difficult as the Windows file system is case-insensitive. I'm working on a Gentoo Linux box running Sun's JDK 1.5.0.11.
I've tried tweaking resources/stylesheets/dir-to-galleryHome.xsl and resources.xmap where JPG is referenced in a few different ways, but I couldn't generate anything that worked. I'll chalk that up to not understanding what I was doing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FOR-990) PluginGallery misbehaves on images
ending with .JPG vs. .jpg.
Posted by "Gavin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489080 ]
Gavin commented on FOR-990:
---------------------------
FOR-982 needs fixing before anyone on Windows can look to solve the problem.
> PluginGallery misbehaves on images ending with .JPG vs. .jpg.
> -------------------------------------------------------------
>
> Key: FOR-990
> URL: https://issues.apache.org/jira/browse/FOR-990
> Project: Forrest
> Issue Type: Bug
> Components: Plugin: input.PhotoGallery
> Affects Versions: 0.8-dev
> Reporter: Paul Kronenwetter
> Priority: Minor
>
> Images ending with JPG do not receive equal treatment as those ending in jpg. Specifically {file}.small.jpg and {file}.thumb.jpg are not created for images ending in JPG. From CFAS's broken-links.xml:
> <link message="/home/kronenpj/src/svn/cfas/src/documentation/content/xdocs/images/gallery/planet/mars20030710x.jpg (No such file or directory)" uri="/gallery/
> planet/mars20030710x.thumb.jpg">
> <referrer uri="/gallery/planet/index.html"/>
> <referrer uri="/gallery/planet/index_1.html"/>
> </link>
> mars20030710x.JPG is the source file under xdocs/images/gallery/planet.
> This is not the only example of where this occurs. I have the following {file}.JPG images in the PhotoGallery source directory and all of them exhibit similar errors in broken-links.xml:
> ./lunar/DSCF0023.JPG
> ./lunar/Mare_Australe_4.JPG
> ./lunar/DSCF0018.JPG
> ./planet/Venus.11.JPG
> ./planet/mars20030710x.JPG
> ./planet/mars20030726x.JPG
> ./messier/M16WH.JPG
> ./ngc/ngc2024.JPG
> The workaround of course is to rename the source files. I don't believe it's the intention of the plugin to dictate the case-style for filenames. Also, converting a file to a different case on Windows is mildly difficult as the Windows file system is case-insensitive. I'm working on a Gentoo Linux box running Sun's JDK 1.5.0.11.
> I've tried tweaking resources/stylesheets/dir-to-galleryHome.xsl and resources.xmap where JPG is referenced in a few different ways, but I couldn't generate anything that worked. I'll chalk that up to not understanding what I was doing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FOR-990) PluginGallery misbehaves on images
ending with .JPG vs. .jpg.
Posted by "Paul Kronenwetter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488993 ]
Paul Kronenwetter commented on FOR-990:
---------------------------------------
Thanks for thinking about this guys!
If I had a little more of a clue, I could try to work on this. Right now, I'm just randomly changing things that I think might help, but I'm not getting any closer.
> PluginGallery misbehaves on images ending with .JPG vs. .jpg.
> -------------------------------------------------------------
>
> Key: FOR-990
> URL: https://issues.apache.org/jira/browse/FOR-990
> Project: Forrest
> Issue Type: Bug
> Components: Plugin: input.PhotoGallery
> Affects Versions: 0.8-dev
> Reporter: Paul Kronenwetter
> Priority: Minor
>
> Images ending with JPG do not receive equal treatment as those ending in jpg. Specifically {file}.small.jpg and {file}.thumb.jpg are not created for images ending in JPG. From CFAS's broken-links.xml:
> <link message="/home/kronenpj/src/svn/cfas/src/documentation/content/xdocs/images/gallery/planet/mars20030710x.jpg (No such file or directory)" uri="/gallery/
> planet/mars20030710x.thumb.jpg">
> <referrer uri="/gallery/planet/index.html"/>
> <referrer uri="/gallery/planet/index_1.html"/>
> </link>
> mars20030710x.JPG is the source file under xdocs/images/gallery/planet.
> This is not the only example of where this occurs. I have the following {file}.JPG images in the PhotoGallery source directory and all of them exhibit similar errors in broken-links.xml:
> ./lunar/DSCF0023.JPG
> ./lunar/Mare_Australe_4.JPG
> ./lunar/DSCF0018.JPG
> ./planet/Venus.11.JPG
> ./planet/mars20030710x.JPG
> ./planet/mars20030726x.JPG
> ./messier/M16WH.JPG
> ./ngc/ngc2024.JPG
> The workaround of course is to rename the source files. I don't believe it's the intention of the plugin to dictate the case-style for filenames. Also, converting a file to a different case on Windows is mildly difficult as the Windows file system is case-insensitive. I'm working on a Gentoo Linux box running Sun's JDK 1.5.0.11.
> I've tried tweaking resources/stylesheets/dir-to-galleryHome.xsl and resources.xmap where JPG is referenced in a few different ways, but I couldn't generate anything that worked. I'll chalk that up to not understanding what I was doing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FOR-990) PluginGallery misbehaves on images
ending with .JPG vs. .jpg.
Posted by "Tim Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488988 ]
Tim Williams commented on FOR-990:
----------------------------------
Yeah, for the original image the other case is accounted for but not the addition renditions. This could get ridiculous with the various mutations obviously, so it'd be nice if there was a way to say .equalsIgnoreCase() in the matcher itself, but I don't know. I'm really busy and don't have time to look but had this info on the top of head so I thought I'd pass it along.
--tim
> PluginGallery misbehaves on images ending with .JPG vs. .jpg.
> -------------------------------------------------------------
>
> Key: FOR-990
> URL: https://issues.apache.org/jira/browse/FOR-990
> Project: Forrest
> Issue Type: Bug
> Components: Plugin: input.PhotoGallery
> Affects Versions: 0.8-dev
> Reporter: Paul Kronenwetter
> Priority: Minor
>
> Images ending with JPG do not receive equal treatment as those ending in jpg. Specifically {file}.small.jpg and {file}.thumb.jpg are not created for images ending in JPG. From CFAS's broken-links.xml:
> <link message="/home/kronenpj/src/svn/cfas/src/documentation/content/xdocs/images/gallery/planet/mars20030710x.jpg (No such file or directory)" uri="/gallery/
> planet/mars20030710x.thumb.jpg">
> <referrer uri="/gallery/planet/index.html"/>
> <referrer uri="/gallery/planet/index_1.html"/>
> </link>
> mars20030710x.JPG is the source file under xdocs/images/gallery/planet.
> This is not the only example of where this occurs. I have the following {file}.JPG images in the PhotoGallery source directory and all of them exhibit similar errors in broken-links.xml:
> ./lunar/DSCF0023.JPG
> ./lunar/Mare_Australe_4.JPG
> ./lunar/DSCF0018.JPG
> ./planet/Venus.11.JPG
> ./planet/mars20030710x.JPG
> ./planet/mars20030726x.JPG
> ./messier/M16WH.JPG
> ./ngc/ngc2024.JPG
> The workaround of course is to rename the source files. I don't believe it's the intention of the plugin to dictate the case-style for filenames. Also, converting a file to a different case on Windows is mildly difficult as the Windows file system is case-insensitive. I'm working on a Gentoo Linux box running Sun's JDK 1.5.0.11.
> I've tried tweaking resources/stylesheets/dir-to-galleryHome.xsl and resources.xmap where JPG is referenced in a few different ways, but I couldn't generate anything that worked. I'll chalk that up to not understanding what I was doing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FOR-990) PluginGallery misbehaves on images
ending with .JPG vs. .jpg.
Posted by "Gavin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488984 ]
Gavin commented on FOR-990:
---------------------------
I think we just need to add a 'jpg|JPG' to the template matches don't we.
> PluginGallery misbehaves on images ending with .JPG vs. .jpg.
> -------------------------------------------------------------
>
> Key: FOR-990
> URL: https://issues.apache.org/jira/browse/FOR-990
> Project: Forrest
> Issue Type: Bug
> Components: Plugin: input.PhotoGallery
> Affects Versions: 0.8-dev
> Reporter: Paul Kronenwetter
> Priority: Minor
>
> Images ending with JPG do not receive equal treatment as those ending in jpg. Specifically {file}.small.jpg and {file}.thumb.jpg are not created for images ending in JPG. From CFAS's broken-links.xml:
> <link message="/home/kronenpj/src/svn/cfas/src/documentation/content/xdocs/images/gallery/planet/mars20030710x.jpg (No such file or directory)" uri="/gallery/
> planet/mars20030710x.thumb.jpg">
> <referrer uri="/gallery/planet/index.html"/>
> <referrer uri="/gallery/planet/index_1.html"/>
> </link>
> mars20030710x.JPG is the source file under xdocs/images/gallery/planet.
> This is not the only example of where this occurs. I have the following {file}.JPG images in the PhotoGallery source directory and all of them exhibit similar errors in broken-links.xml:
> ./lunar/DSCF0023.JPG
> ./lunar/Mare_Australe_4.JPG
> ./lunar/DSCF0018.JPG
> ./planet/Venus.11.JPG
> ./planet/mars20030710x.JPG
> ./planet/mars20030726x.JPG
> ./messier/M16WH.JPG
> ./ngc/ngc2024.JPG
> The workaround of course is to rename the source files. I don't believe it's the intention of the plugin to dictate the case-style for filenames. Also, converting a file to a different case on Windows is mildly difficult as the Windows file system is case-insensitive. I'm working on a Gentoo Linux box running Sun's JDK 1.5.0.11.
> I've tried tweaking resources/stylesheets/dir-to-galleryHome.xsl and resources.xmap where JPG is referenced in a few different ways, but I couldn't generate anything that worked. I'll chalk that up to not understanding what I was doing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FOR-990) PluginGallery misbehaves on images
ending with .JPG vs. .jpg.
Posted by "Gavin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12488992 ]
Gavin commented on FOR-990:
---------------------------
For Tim's idea, in the PersistantImageReader.java we have
fName = fName.replaceFirst(".jpg","." + this.variant + ".jpg");
So we could incorporate equalsIgnoreCase() there, but don't know if that will suffice, we'd probably still need an XSL equivelant in the sitemap.xmap matchers. (Guess I'll try it when I get time)
> PluginGallery misbehaves on images ending with .JPG vs. .jpg.
> -------------------------------------------------------------
>
> Key: FOR-990
> URL: https://issues.apache.org/jira/browse/FOR-990
> Project: Forrest
> Issue Type: Bug
> Components: Plugin: input.PhotoGallery
> Affects Versions: 0.8-dev
> Reporter: Paul Kronenwetter
> Priority: Minor
>
> Images ending with JPG do not receive equal treatment as those ending in jpg. Specifically {file}.small.jpg and {file}.thumb.jpg are not created for images ending in JPG. From CFAS's broken-links.xml:
> <link message="/home/kronenpj/src/svn/cfas/src/documentation/content/xdocs/images/gallery/planet/mars20030710x.jpg (No such file or directory)" uri="/gallery/
> planet/mars20030710x.thumb.jpg">
> <referrer uri="/gallery/planet/index.html"/>
> <referrer uri="/gallery/planet/index_1.html"/>
> </link>
> mars20030710x.JPG is the source file under xdocs/images/gallery/planet.
> This is not the only example of where this occurs. I have the following {file}.JPG images in the PhotoGallery source directory and all of them exhibit similar errors in broken-links.xml:
> ./lunar/DSCF0023.JPG
> ./lunar/Mare_Australe_4.JPG
> ./lunar/DSCF0018.JPG
> ./planet/Venus.11.JPG
> ./planet/mars20030710x.JPG
> ./planet/mars20030726x.JPG
> ./messier/M16WH.JPG
> ./ngc/ngc2024.JPG
> The workaround of course is to rename the source files. I don't believe it's the intention of the plugin to dictate the case-style for filenames. Also, converting a file to a different case on Windows is mildly difficult as the Windows file system is case-insensitive. I'm working on a Gentoo Linux box running Sun's JDK 1.5.0.11.
> I've tried tweaking resources/stylesheets/dir-to-galleryHome.xsl and resources.xmap where JPG is referenced in a few different ways, but I couldn't generate anything that worked. I'll chalk that up to not understanding what I was doing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.