[GitHub] [iotdb] jamber001 commented on a diff in pull request #6200: [IOTDB-3424] avoid running duplicated IotDB servers

[GitBox <gi...@apache.org>]

jamber001 commented on code in PR #6200:
URL: https://github.com/apache/iotdb/pull/6200#discussion_r894111663


##########
server/src/assembly/resources/sbin/start-datanode.sh:
##########
@@ -97,6 +97,49 @@ launch_service()
 	return $?
 }
 
+
+# check whether tool 'lsof' & 'realpath' exists
+check_tool_env() {
+  if  ! type lsof > /dev/null 2>&1 ; then
+    echo ""
+    echo " Error: No tool 'lsof', Please install it."
+    exit 1
+  fi
+
+  if  ! type realpath > /dev/null 2>&1 ; then

Review Comment:
   Strange. 
   1) In past start stop scripts, they also depend on some third-party tool  such netstat, ps etc.  If they are absent, user need also to insteall .
   2) When I dev this PR, I specially test realpath in Linux and Mac. Normally, Linux and Mac has tool realpath. Does your Mac have no this tool ?
   3) For edge device, if it is linux OS. Normally, it contain realpath. Because realpath belong to coreutils .
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org