You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/16 07:07:04 UTC
[jira] [Commented] (WEEX-35) A component open URL got different
action on iOS and Android
[ https://issues.apache.org/jira/browse/WEEX-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011858#comment-16011858 ]
ASF GitHub Bot commented on WEEX-35:
------------------------------------
GitHub user IskenHuang opened a pull request:
https://github.com/apache/incubator-weex/pull/349
* [android] fixed issues #35. when a tag href is empty
As https://issues.apache.org/jira/browse/WEEX-35 ，Let iOS and Android A component open empty url the same logic
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/IskenHuang/incubator-weex android-bugfix-acomponent
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/349.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #349
----
commit 656749b82a9b2aa7a9172cf09eb8f21b273eeca8
Author: Isken Huang <is...@gmail.com>
Date: 2017-05-16T07:01:53Z
* [android] fixed issues #35. when a tag href is empty
----
> A component open URL got different action on iOS and Android
> ------------------------------------------------------------
>
> Key: WEEX-35
> URL: https://issues.apache.org/jira/browse/WEEX-35
> Project: Weex
> Issue Type: Bug
> Environment: iOS, Android
> Reporter: Isken Huang
>
> iOS: https://github.com/apache/incubator-weex/blob/master/ios/sdk/WeexSDK/Sources/Component/WXAComponent.m#L63
> Android: https://github.com/apache/incubator-weex/blob/master/android/sdk/src/main/java/com/taobao/weex/ui/component/WXA.java#L53
> iOS SDK's is when href exist and string length more then 0 to do something. Android SDK's is when href is not null to do something. This logic should be the same.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)