You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2020/03/11 09:53:15 UTC
[GitHub] [drill] vvysotskyi commented on a change in pull request #2020:
DRILL-7634: Rollup of code cleanup changes
vvysotskyi commented on a change in pull request #2020: DRILL-7634: Rollup of code cleanup changes
URL: https://github.com/apache/drill/pull/2020#discussion_r390833446
##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillAggFuncHolder.java
##########
@@ -81,51 +79,47 @@ public boolean isAggregating() {
@Override
public JVar[] renderStart(ClassGenerator<?> g, HoldingContainer[] inputVariables, FieldReference fieldReference) {
if (!g.getMappingSet().isHashAggMapping()) { //Declare workspace vars for non-hash-aggregation.
- JVar[] workspaceJVars = declareWorkspaceVariables(g);
- generateBody(g, BlockType.SETUP, setup(), null, workspaceJVars, true);
- return workspaceJVars;
+ JVar[] workspaceJVars = declareWorkspaceVariables(g);
+ generateBody(g, BlockType.SETUP, setup(), null, workspaceJVars, true);
+ return workspaceJVars;
} else { //Declare workspace vars and workspace vectors for hash aggregation.
Review comment:
Please fix indentation for this line also.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services