You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/03/25 19:38:16 UTC
Review Request: Fixed MonitorTest.WatchUnwatch flakiness by adding missing
Clock::settle calls.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10123/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
See above. Seems like perhaps Clock::advance() should internally perform a Clock::settle()?
This addresses bug MESOS-399.
https://issues.apache.org/jira/browse/MESOS-399
Diffs
-----
src/tests/monitor_tests.cpp 1d883e7c53a24787124ccd6caf26b4a045aec149
Diff: https://reviews.apache.org/r/10123/diff/
Testing
-------
./bin/mesos-tests.sh --gtest_filter="MonitorTest.*" --verbose --gtest_repeat=10000 --gtest_break_on_failure
Thanks,
Ben Mahler
Re: Review Request: Fixed MonitorTest.WatchUnwatch flakiness by adding
missing Clock::settle calls.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10123/#review18371
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On March 25, 2013, 6:38 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10123/
> -----------------------------------------------------------
>
> (Updated March 25, 2013, 6:38 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> See above. Seems like perhaps Clock::advance() should internally perform a Clock::settle()?
>
>
> This addresses bug MESOS-399.
> https://issues.apache.org/jira/browse/MESOS-399
>
>
> Diffs
> -----
>
> src/tests/monitor_tests.cpp 1d883e7c53a24787124ccd6caf26b4a045aec149
>
> Diff: https://reviews.apache.org/r/10123/diff/
>
>
> Testing
> -------
>
> ./bin/mesos-tests.sh --gtest_filter="MonitorTest.*" --verbose --gtest_repeat=10000 --gtest_break_on_failure
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Fixed MonitorTest.WatchUnwatch flakiness by adding
missing Clock::settle calls.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10123/#review18360
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 25, 2013, 6:38 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10123/
> -----------------------------------------------------------
>
> (Updated March 25, 2013, 6:38 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> See above. Seems like perhaps Clock::advance() should internally perform a Clock::settle()?
>
>
> This addresses bug MESOS-399.
> https://issues.apache.org/jira/browse/MESOS-399
>
>
> Diffs
> -----
>
> src/tests/monitor_tests.cpp 1d883e7c53a24787124ccd6caf26b4a045aec149
>
> Diff: https://reviews.apache.org/r/10123/diff/
>
>
> Testing
> -------
>
> ./bin/mesos-tests.sh --gtest_filter="MonitorTest.*" --verbose --gtest_repeat=10000 --gtest_break_on_failure
>
>
> Thanks,
>
> Ben Mahler
>
>