[jira] Commented: (HADOOP-3852) If ShellCommandExecutor had a toString() operator that listed the command run, its error messages may be more meaningful

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617810#action_12617810 ] 

Hadoop QA commented on HADOOP-3852:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12387093/hadoop-3852.patch
  against trunk revision 680577.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2970/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2970/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2970/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2970/console

This message is automatically generated.

> If ShellCommandExecutor had a toString() operator that listed the command run, its error messages may be more meaningful
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3852
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3852
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: util
>    Affects Versions: 0.19.0
>            Reporter: Steve Loughran
>            Priority: Minor
>         Attachments: hadoop-3852.patch
>
>
> It may be easier to identify what causes error commands to be returned on an exec if the command is included in the error message. this can be done with 
> * a toString() operator on the class that includes the list of arguments (when non null)
> * a test that this works with arguments with spaces, and a null array
> * relevant use of the operator when an execute fails, such as in TaskTracker

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.