You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2015/09/01 16:27:28 UTC
Re: Review Request 37830: Added a test for converting JSON arrays to
Resources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37830/
-----------------------------------------------------------
(Updated Sept. 1, 2015, 2:27 p.m.)
Review request for mesos, Joseph Wu and Michael Park.
Changes
-------
Rebased.
Bugs: MESOS-3312
https://issues.apache.org/jira/browse/MESOS-3312
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56
Diff: https://reviews.apache.org/r/37830/diff/
Testing
-------
make check (Mac OS 10.10.4)
Thanks,
Alexander Rukletsov
Re: Review Request 37830: Added a test for converting JSON arrays to
Resources.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37830/
-----------------------------------------------------------
(Updated Sept. 10, 2015, 6:46 p.m.)
Review request for mesos, Joseph Wu and Michael Park.
Changes
-------
MPark's comments.
Bugs: MESOS-3312
https://issues.apache.org/jira/browse/MESOS-3312
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56
Diff: https://reviews.apache.org/r/37830/diff/
Testing
-------
make check (Mac OS 10.10.4)
Thanks,
Alexander Rukletsov
Re: Review Request 37830: Added a test for converting JSON arrays to
Resources.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37830/#review98375
-----------------------------------------------------------
Ship it!
src/tests/resources_tests.cpp (lines 153 - 158)
<https://reviews.apache.org/r/37830/#comment154836>
I needed the same thing recently for [reservation tests](https://github.com/apache/mesos/blob/master/src/tests/reservation_endpoints_tests.cpp#L70)!
I've filed [MESOS-3405](https://issues.apache.org/jira/browse/MESOS-3405) for this :)
src/tests/resources_tests.cpp (line 160)
<https://reviews.apache.org/r/37830/#comment154837>
This seems like an unrelated test.
- Michael Park
On Sept. 9, 2015, 2:46 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37830/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2015, 2:46 p.m.)
>
>
> Review request for mesos, Joseph Wu and Michael Park.
>
>
> Bugs: MESOS-3312
> https://issues.apache.org/jira/browse/MESOS-3312
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56
>
> Diff: https://reviews.apache.org/r/37830/diff/
>
>
> Testing
> -------
>
> make check (Mac OS 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 37830: Added a test for converting JSON arrays to
Resources.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37830/
-----------------------------------------------------------
(Updated Sept. 9, 2015, 2:46 p.m.)
Review request for mesos, Joseph Wu and Michael Park.
Changes
-------
Rebased.
Bugs: MESOS-3312
https://issues.apache.org/jira/browse/MESOS-3312
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56
Diff: https://reviews.apache.org/r/37830/diff/
Testing
-------
make check (Mac OS 10.10.4)
Thanks,
Alexander Rukletsov
Re: Review Request 37830: Added a test for converting JSON arrays to
Resources.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37830/
-----------------------------------------------------------
(Updated Sept. 7, 2015, 9:12 a.m.)
Review request for mesos, Joseph Wu and Michael Park.
Changes
-------
Rebased.
Bugs: MESOS-3312
https://issues.apache.org/jira/browse/MESOS-3312
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56
Diff: https://reviews.apache.org/r/37830/diff/
Testing
-------
make check (Mac OS 10.10.4)
Thanks,
Alexander Rukletsov
Re: Review Request 37830: Added a test for converting JSON arrays to
Resources.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37830/
-----------------------------------------------------------
(Updated Sept. 3, 2015, 1:33 p.m.)
Review request for mesos, Joseph Wu and Michael Park.
Changes
-------
Rebased.
Bugs: MESOS-3312
https://issues.apache.org/jira/browse/MESOS-3312
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56
Diff: https://reviews.apache.org/r/37830/diff/
Testing
-------
make check (Mac OS 10.10.4)
Thanks,
Alexander Rukletsov
Re: Review Request 37830: Added a test for converting JSON arrays to
Resources.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37830/#review97292
-----------------------------------------------------------
Patch looks great!
Reviews applied: [37826, 37827, 37830]
All tests passed.
- Mesos ReviewBot
On Sept. 1, 2015, 2:27 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37830/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2015, 2:27 p.m.)
>
>
> Review request for mesos, Joseph Wu and Michael Park.
>
>
> Bugs: MESOS-3312
> https://issues.apache.org/jira/browse/MESOS-3312
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/resources_tests.cpp 2ae93a9c8235e5e4643539d409df51c39c6d7e56
>
> Diff: https://reviews.apache.org/r/37830/diff/
>
>
> Testing
> -------
>
> make check (Mac OS 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>