You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Jérôme Lacoste <je...@smartcardsystem.com> on 2001/08/02 16:32:31 UTC
Reminder: [SUBMIT] Attr, a chmod equivalent for Windows
Middle of June I submitted the Attrib task.
It has not made the Ant tree. I guess it is because it is a Windows task and
cannot be tested by everybody.
Can somebody review/validate it? It would be nice if it could make the Ant
tree before 1.4.
You will find the original mail with attachments at
http://marc.theaimsgroup.com/?l=ant-dev&m=99235305909094&w=2.
Thanks,
Jerome
RE: Reminder: [SUBMIT] Attr, a chmod equivalent for Windows
Posted by Martin van den Bemt <mv...@mvdb.com>.
I'll review the code for the latest stuff and try again.. Btw... that
message was my attempt for version 1.3. I sent a message for 1.2 with chgrp
and chown when probably sam was on his own ;-)
I think bugzilla is the right approach.. at least you can track the "issues"
better.
Btw I can test it on both windows and linux (it shouldn't work on windows
btw..), I'm using both for all the build processes. I'll dig into it again
and put it in bugzilla. You now scheduling 1.4 again, so I don't anticipate
on it being there or feedback in short notice ;-)
Mvgr,
Martin
> -----Original Message-----
> From: Conor MacNeill [mailto:conor@cortexebusiness.com.au]
> Sent: Friday, August 03, 2001 3:41 PM
> To: ant-dev@jakarta.apache.org
> Subject: Re: Reminder: [SUBMIT] Attr, a chmod equivalent for Windows
>
>
> Martin,
>
> I'm sorry if your patches did not get committed. That happens. We are all
> busy people doing our day jobs, etc etc - I won't bore you with the
> minutiae. Sometimes submissions get overlooked.
>
> As for the code in question, the last post you made on the subject, that I
> can find, is
>
> > Before you freeze, these 2 will be handy. I don't know when you're gonna
> > freeze the cvs tree, but I was also working on chrights (which calls
> chmod,
> > chgrp and chown), but I still have a little trouble calling them...
>
> Now, I'll admit that was a long time ago but it didn't quite sound to me
> that your were finished. You might also guess that around this
> time we were
> pretty busy building, testing and managing the release.
>
> BTW, I wasn't always a committer :-) I guess that if I had just gone away,
> I still wouldn't be.
>
> If you want to submit the tasks again, I think they should be
> considered. I
> won't commit them myself. I have been doing most of my Ant development on
> NT till now (although I will be changing after the 1.4 release),
> so I can't
> really add much value to testing these particular tasks. That makes it
> difficult to do a proper job reviewing them.
>
> Another approach is to add these things to bugzilla, so they will
> remain on
> the list until someone acknowledges them. Both approaches are valid.
>
> As I said, it is your choice.
>
> Conor
>
>
> ----- Original Message -----
> From: "Martin van den Bemt" <mv...@mvdb.com>
> To: <an...@jakarta.apache.org>
> Sent: Friday, August 03, 2001 10:54 PM
> Subject: RE: Reminder: [SUBMIT] Attr, a chmod equivalent for Windows
>
>
> > maby you don't have that problem, since you have commit access. If
> invested
> > time isn't "appreciated" then I don't invest any more time, unless I am
> > convinced something actually happens with it.. (even a -1 would
> be ok for
> > me..). That is excpected feedback for projects that are actively asking
> to
> > get involved..
> >
> > If you say it isn't a waste of time, please let me know how
> getting stuff
> > into ant actually works (not talking about patches..), so we
> are clear on
> > that (1 month before going beta we look at all new submissions or
> something
> > like that?).
> >
> > Mvgr,
> > Martin
> >
> > > -----Original Message-----
> > > From: Conor MacNeill [mailto:conor@cortexebusiness.com.au]
> > > Sent: Friday, August 03, 2001 2:44 PM
> > > To: ant-dev@jakarta.apache.org
> > > Subject: Re: Reminder: [SUBMIT] Attr, a chmod equivalent for Windows
> > >
> > >
> > > From: "Martin van den Bemt" <mv...@mvdb.com>
> > > > that's the reason I stopped submitting stuff.. It never ends up the
> > > source
> > > > tree anyway.. (added a chown chgrp and chrights (all 3 combined)),
> but
> > > never
> > > > heard something again..
> > > >
> > >
> > > That is your choice.
> > >
> > > Conor
> > >
> > >
> > >
> >
> >
>
>
RE: Reminder: [SUBMIT] Attr, a chmod equivalent for Windows
Posted by Jérôme Lacoste <je...@smartcardsystem.com>.
> Maby a misunderstanding here.. I'm not doubting that there should be an
> attrib task..
> I was refering to Mathew's question : (at least my interpration of it ) is
> it tested on a linux (or other non windows box) and does it actually skip
> the task?
Martin,
I do not have a Linux box at hand here. Perhaps someone can test it for me.
Within the code of the submission, there is a isValidOs() method
implementation. I don't know if it requires something else. I had just added
some functionality to the original submission.
For people used to not-cross platform tasks, one can probably quickly find
what misses from the submission
(http://marc.theaimsgroup.com/?l=ant-dev&m=99235305909094&w=2) so that Ant
does not try to use it on non-Windows platform.
Cheers,
Jerome
RE: Reminder: [SUBMIT] Attr, a chmod equivalent for Windows
Posted by Martin van den Bemt <mv...@mvdb.com>.
Maby a misunderstanding here.. I'm not doubting that there should be an
attrib task..
I was refering to Mathew's question : (at least my interpration of it ) is
it tested on a linux (or other non windows box) and does it actually skip
the task?
Sorry for the misunderstanding.
Mvgr,
Martin
> -----Original Message-----
> From: Jérôme Lacoste [mailto:jerome.lacoste@smartcardsystem.com]
> Sent: Friday, August 03, 2001 7:21 PM
> To: ant-dev@jakarta.apache.org
> Subject: RE: Reminder: [SUBMIT] Attr, a chmod equivalent for Windows
>
>
> Mathew you're right. I didn't specify in which way they were equivalent.
>
> Correction:
>
> > It calls the Windows 'Attrib' program equivalent to 'chmod' on Unix.
>
> equivalent regarding the goal (change the permissions) but not in
> functionality (because available permissions are different depending on
> OSes).
>
> Attrib is OS dependent, so is Chmod, isn't it?
>
> Most of the required functionality is the read/write-ability. It is
> sometimes necessary to change it.
> We don't have it on Windows, we have it on Linux/Unix.
> Why not have the counterpart?
>
> Jerome
>
>
RE: Reminder: [SUBMIT] Attr, a chmod equivalent for Windows
Posted by Jérôme Lacoste <je...@smartcardsystem.com>.
Mathew you're right. I didn't specify in which way they were equivalent.
Correction:
> It calls the Windows 'Attrib' program equivalent to 'chmod' on Unix.
equivalent regarding the goal (change the permissions) but not in
functionality (because available permissions are different depending on
OSes).
Attrib is OS dependent, so is Chmod, isn't it?
Most of the required functionality is the read/write-ability. It is
sometimes necessary to change it.
We don't have it on Windows, we have it on Linux/Unix.
Why not have the counterpart?
Jerome
Re: Reminder: [SUBMIT] Attr, a chmod equivalent for Windows
Posted by Matthew Inger <ma...@sedonacorp.com>.
Martin van den Bemt wrote:
>What he means is what does attrib do on a linux box?
>It should only excecute on a windows box and on no other OS. (unless
>supported).
>The goal is (as much as possible) to keep buildfiles platform independend
>and OS specific implementations should (at least I think that's what is
>happening now) ignored.
>
>Mvgr,
>Martin
>
>>-----Original Message-----
>>From: Jérôme Lacoste [mailto:jerome.lacoste@smartcardsystem.com]
>>Sent: Friday, August 03, 2001 6:38 PM
>>To: ant-dev@jakarta.apache.org
>>Subject: RE: Reminder: [SUBMIT] Attr, a chmod equivalent for Windows
>>
>>
>>>Yes, I know that :-). I'm going through my list. What will
>>>
>>happen if this
>>
>>>is run on Unix. What does it do?
>>>
>>It calls the Windows 'Attrib' program equivalent to 'chmod' on Unix.
>>
>>We had a thread on it just before it was submitted. (It was submitted by
>>somebody else, somebody proposed a change, I implemented it)
>>
>>
>>Here's Attrib help on Windows 2000.
>>-----------------------------------
>>Displays or changes file attributes.
>>
>>ATTRIB [+R | -R] [+A | -A ] [+S | -S] [+H | -H] [[drive:] [path] filename]
>> [/S [/D]]
>>
>> + Sets an attribute.
>> - Clears an attribute.
>> R Read-only file attribute.
>> A Archive file attribute.
>> S System file attribute.
>> H Hidden file attribute.
>> /S Processes matching files in the current folder
>> and all subfolders.
>> /D Processes folders as well.
>>
>>
>
>
it seems to me like attrib is not the equivalent of chmod, nor could any
program
on windows be the equivalent.
for one, attrib has no notions of users or groups, or execute permissions.
plus the windows permission scheme is so different than unix that any
nt command would have much more complex arguments than chmod,
since you can do per-user, per-group, and global permissions. instead of
just
owner, owning group,and global.
--
Matt Inger (matt.inger@sedonacorp.com)
Sedona Corporation
455 S. Gulph Road, Suite 300
King of Prussia, PA 19406
(484) 679-2213
"Self-respect - the secure feeling that no one,
as yet, is suspicious." -H.L. Mencken
RE: Reminder: [SUBMIT] Attr, a chmod equivalent for Windows
Posted by Martin van den Bemt <mv...@mvdb.com>.
What he means is what does attrib do on a linux box?
It should only excecute on a windows box and on no other OS. (unless
supported).
The goal is (as much as possible) to keep buildfiles platform independend
and OS specific implementations should (at least I think that's what is
happening now) ignored.
Mvgr,
Martin
> -----Original Message-----
> From: Jérôme Lacoste [mailto:jerome.lacoste@smartcardsystem.com]
> Sent: Friday, August 03, 2001 6:38 PM
> To: ant-dev@jakarta.apache.org
> Subject: RE: Reminder: [SUBMIT] Attr, a chmod equivalent for Windows
>
>
> > Yes, I know that :-). I'm going through my list. What will
> happen if this
> > is run on Unix. What does it do?
>
> It calls the Windows 'Attrib' program equivalent to 'chmod' on Unix.
>
> We had a thread on it just before it was submitted. (It was submitted by
> somebody else, somebody proposed a change, I implemented it)
>
>
> Here's Attrib help on Windows 2000.
> -----------------------------------
> Displays or changes file attributes.
>
> ATTRIB [+R | -R] [+A | -A ] [+S | -S] [+H | -H] [[drive:] [path] filename]
> [/S [/D]]
>
> + Sets an attribute.
> - Clears an attribute.
> R Read-only file attribute.
> A Archive file attribute.
> S System file attribute.
> H Hidden file attribute.
> /S Processes matching files in the current folder
> and all subfolders.
> /D Processes folders as well.
>
>
RE: Reminder: [SUBMIT] Attr, a chmod equivalent for Windows
Posted by Jérôme Lacoste <je...@smartcardsystem.com>.
> Yes, I know that :-). I'm going through my list. What will happen if this
> is run on Unix. What does it do?
It calls the Windows 'Attrib' program equivalent to 'chmod' on Unix.
We had a thread on it just before it was submitted. (It was submitted by
somebody else, somebody proposed a change, I implemented it)
Here's Attrib help on Windows 2000.
-----------------------------------
Displays or changes file attributes.
ATTRIB [+R | -R] [+A | -A ] [+S | -S] [+H | -H] [[drive:] [path] filename]
[/S [/D]]
+ Sets an attribute.
- Clears an attribute.
R Read-only file attribute.
A Archive file attribute.
S System file attribute.
H Hidden file attribute.
/S Processes matching files in the current folder
and all subfolders.
/D Processes folders as well.
Re: Reminder: [SUBMIT] Attr, a chmod equivalent for Windows
Posted by Conor MacNeill <co...@cortexebusiness.com.au>.
From: "Jérôme Lacoste" <je...@smartcardsystem.com>
To: <an...@jakarta.apache.org>
Sent: Friday, August 03, 2001 11:46 PM
Subject: RE: Reminder: [SUBMIT] Attr, a chmod equivalent for Windows
>
> > If you want to submit the tasks again, I think they should be
considered.
> I
> > won't commit them myself. I have been doing most of my Ant development
on
> > NT till now (although I will be changing after the 1.4 release), so I
> can't
> > really add much value to testing these particular tasks. That makes it
> > difficult to do a proper job reviewing them.
>
> I just sneak in into the thread to remind you that the 'Attr' task (at
the
> origin for the thread) runs on Windows and can be tested on NT...
>
Yes, I know that :-). I'm going through my list. What will happen if this
is run on Unix. What does it do?
Conor
RE: Reminder: [SUBMIT] Attr, a chmod equivalent for Windows
Posted by Jérôme Lacoste <je...@smartcardsystem.com>.
> we were talking about chown chgrp and chmod..
Before writing anything like that, I would have read the thread's Subject.
Second I would not have sent it to everybody, but just to me.
I also apologize for disturding the Ant-Dev list with such comments.
Jerome
RE: Reminder: [SUBMIT] Attr, a chmod equivalent for Windows
Posted by Martin van den Bemt <mv...@mvdb.com>.
we were talking about chown chgrp and chmod..
> -----Original Message-----
> From: Jérôme Lacoste [mailto:jerome.lacoste@smartcardsystem.com]
> Sent: Friday, August 03, 2001 3:47 PM
> To: ant-dev@jakarta.apache.org
> Subject: RE: Reminder: [SUBMIT] Attr, a chmod equivalent for Windows
>
>
>
> > If you want to submit the tasks again, I think they should be
> considered.
> I
> > won't commit them myself. I have been doing most of my Ant
> development on
> > NT till now (although I will be changing after the 1.4 release), so I
> can't
> > really add much value to testing these particular tasks. That makes it
> > difficult to do a proper job reviewing them.
>
> I just sneak in into the thread to remind you that the 'Attr' task (at the
> origin for the thread) runs on Windows and can be tested on NT...
>
> Jerome
>
>
RE: Reminder: [SUBMIT] Attr, a chmod equivalent for Windows
Posted by Jérôme Lacoste <je...@smartcardsystem.com>.
> If you want to submit the tasks again, I think they should be considered.
I
> won't commit them myself. I have been doing most of my Ant development on
> NT till now (although I will be changing after the 1.4 release), so I
can't
> really add much value to testing these particular tasks. That makes it
> difficult to do a proper job reviewing them.
I just sneak in into the thread to remind you that the 'Attr' task (at the
origin for the thread) runs on Windows and can be tested on NT...
Jerome
Re: Reminder: [SUBMIT] Attr, a chmod equivalent for Windows
Posted by Conor MacNeill <co...@cortexebusiness.com.au>.
Martin,
I'm sorry if your patches did not get committed. That happens. We are all
busy people doing our day jobs, etc etc - I won't bore you with the
minutiae. Sometimes submissions get overlooked.
As for the code in question, the last post you made on the subject, that I
can find, is
> Before you freeze, these 2 will be handy. I don't know when you're gonna
> freeze the cvs tree, but I was also working on chrights (which calls
chmod,
> chgrp and chown), but I still have a little trouble calling them...
Now, I'll admit that was a long time ago but it didn't quite sound to me
that your were finished. You might also guess that around this time we were
pretty busy building, testing and managing the release.
BTW, I wasn't always a committer :-) I guess that if I had just gone away,
I still wouldn't be.
If you want to submit the tasks again, I think they should be considered. I
won't commit them myself. I have been doing most of my Ant development on
NT till now (although I will be changing after the 1.4 release), so I can't
really add much value to testing these particular tasks. That makes it
difficult to do a proper job reviewing them.
Another approach is to add these things to bugzilla, so they will remain on
the list until someone acknowledges them. Both approaches are valid.
As I said, it is your choice.
Conor
----- Original Message -----
From: "Martin van den Bemt" <mv...@mvdb.com>
To: <an...@jakarta.apache.org>
Sent: Friday, August 03, 2001 10:54 PM
Subject: RE: Reminder: [SUBMIT] Attr, a chmod equivalent for Windows
> maby you don't have that problem, since you have commit access. If
invested
> time isn't "appreciated" then I don't invest any more time, unless I am
> convinced something actually happens with it.. (even a -1 would be ok for
> me..). That is excpected feedback for projects that are actively asking
to
> get involved..
>
> If you say it isn't a waste of time, please let me know how getting stuff
> into ant actually works (not talking about patches..), so we are clear on
> that (1 month before going beta we look at all new submissions or
something
> like that?).
>
> Mvgr,
> Martin
>
> > -----Original Message-----
> > From: Conor MacNeill [mailto:conor@cortexebusiness.com.au]
> > Sent: Friday, August 03, 2001 2:44 PM
> > To: ant-dev@jakarta.apache.org
> > Subject: Re: Reminder: [SUBMIT] Attr, a chmod equivalent for Windows
> >
> >
> > From: "Martin van den Bemt" <mv...@mvdb.com>
> > > that's the reason I stopped submitting stuff.. It never ends up the
> > source
> > > tree anyway.. (added a chown chgrp and chrights (all 3 combined)),
but
> > never
> > > heard something again..
> > >
> >
> > That is your choice.
> >
> > Conor
> >
> >
> >
>
>
RE: Reminder: [SUBMIT] Attr, a chmod equivalent for Windows
Posted by Martin van den Bemt <mv...@mvdb.com>.
maby you don't have that problem, since you have commit access. If invested
time isn't "appreciated" then I don't invest any more time, unless I am
convinced something actually happens with it.. (even a -1 would be ok for
me..). That is excpected feedback for projects that are actively asking to
get involved..
If you say it isn't a waste of time, please let me know how getting stuff
into ant actually works (not talking about patches..), so we are clear on
that (1 month before going beta we look at all new submissions or something
like that?).
Mvgr,
Martin
> -----Original Message-----
> From: Conor MacNeill [mailto:conor@cortexebusiness.com.au]
> Sent: Friday, August 03, 2001 2:44 PM
> To: ant-dev@jakarta.apache.org
> Subject: Re: Reminder: [SUBMIT] Attr, a chmod equivalent for Windows
>
>
> From: "Martin van den Bemt" <mv...@mvdb.com>
> > that's the reason I stopped submitting stuff.. It never ends up the
> source
> > tree anyway.. (added a chown chgrp and chrights (all 3 combined)), but
> never
> > heard something again..
> >
>
> That is your choice.
>
> Conor
>
>
>
Re: Reminder: [SUBMIT] Attr, a chmod equivalent for Windows
Posted by Conor MacNeill <co...@cortexebusiness.com.au>.
From: "Martin van den Bemt" <mv...@mvdb.com>
> that's the reason I stopped submitting stuff.. It never ends up the
source
> tree anyway.. (added a chown chgrp and chrights (all 3 combined)), but
never
> heard something again..
>
That is your choice.
Conor
RE: Reminder: [SUBMIT] Attr, a chmod equivalent for Windows
Posted by Martin van den Bemt <mv...@mvdb.com>.
that's the reason I stopped submitting stuff.. It never ends up the source
tree anyway.. (added a chown chgrp and chrights (all 3 combined)), but never
heard something again..
> -----Original Message-----
> From: Jérôme Lacoste [mailto:jerome.lacoste@smartcardsystem.com]
> Sent: Thursday, August 02, 2001 4:33 PM
> To: ant-dev@jakarta.apache.org
> Cc: SKanga@ingenuus.com
> Subject: Reminder: [SUBMIT] Attr, a chmod equivalent for Windows
>
>
> Middle of June I submitted the Attrib task.
> It has not made the Ant tree. I guess it is because it is a
> Windows task and
> cannot be tested by everybody.
>
> Can somebody review/validate it? It would be nice if it could make the Ant
> tree before 1.4.
>
> You will find the original mail with attachments at
> http://marc.theaimsgroup.com/?l=ant-dev&m=99235305909094&w=2.
>
> Thanks,
>
> Jerome
>
>