You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "amoghrajesh (via GitHub)" <gi...@apache.org> on 2025/11/05 18:54:24 UTC
Re: [PR] Respect default_args in DAG when its set to a "falsy" value [airflow]
amoghrajesh commented on code in PR #57853:
URL: https://github.com/apache/airflow/pull/57853#discussion_r2495741434
##########
airflow-core/tests/unit/serialization/test_dag_serialization.py:
##########
@@ -4139,6 +4139,27 @@ def test_multiple_tasks_share_client_defaults(self):
value2 = getattr(deserialized_task2, field)
assert value1 == value2, f"Tasks have different values for {field}: {value1} vs {value2}"
+ @operator_defaults({"retries": 3})
+ def test_explicit_schema_default_preserved_when_client_defaults_differ(self):
+ """Test that explicitly set values matching schema defaults are preserved when client_defaults differ."""
+ with DAG(dag_id="test_explicit_schema_default", default_args={"retries": 0}) as dag:
+ BashOperator(task_id="task1", bash_command="echo 1")
Review Comment:
Added
##########
airflow-core/tests/unit/serialization/test_dag_serialization.py:
##########
Review Comment:
Yea, sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org