You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2022/10/11 17:21:17 UTC

[GitHub] [cassandra-sidecar] frankgh commented on a diff in pull request #38: CASSANDRASC-44 Refactor health check to use vertx timer

frankgh commented on code in PR #38:
URL: https://github.com/apache/cassandra-sidecar/pull/38#discussion_r992598120


##########
common/src/main/java/org/apache/cassandra/sidecar/common/CassandraAdapterDelegate.java:
##########
@@ -127,7 +95,7 @@ public synchronized void checkSession()
      * Should be called on initial connect as well as when a server comes back since it might be from an upgrade
      * synchronized so we don't flood the DB with version requests
      *
-     * If the healthcheck determines we've changed versions, it should load the proper adapter
+     * <p>If the healthcheck determines we've changed versions, it should load the proper adapter

Review Comment:
   this is a javadoc standard I believe. You need to open new paragraphs with the paragraph (`<p>`) tag. I will close the tag



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org