You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2018/07/02 21:28:59 UTC

[GitHub] keith-turner commented on a change in pull request #546: Fix multiple concurrency bugs in Master.gatherTableInformation()

keith-turner commented on a change in pull request #546: Fix multiple concurrency bugs in Master.gatherTableInformation()
URL: https://github.com/apache/accumulo/pull/546#discussion_r199626495
 
 

 ##########
 File path: server/master/src/main/java/org/apache/accumulo/master/Master.java
 ##########
 @@ -1196,13 +1203,21 @@ public void run() {
     } catch (InterruptedException e) {
       log.debug("Interrupted while fetching status");
     }
+
+    tp.shutdownNow();
+
+    // Because result is a ConcurrentSkipListMap will not see a concurrent modification exception,
+    // even though background threads may still try to put.
+    SortedMap<TServerInstance,TabletServerStatus> info = ImmutableSortedMap.copyOf(result);
 
 Review comment:
   The bad server processing needs some attention, I will open up a follow on issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services