You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Ali Ok (JIRA)" <de...@myfaces.apache.org> on 2010/02/16 15:11:27 UTC
[jira] Created: (MYFACES-2560) Known class name for EL RI's
ExpressionFactoryImpl is wrong
Known class name for EL RI's ExpressionFactoryImpl is wrong
-----------------------------------------------------------
Key: MYFACES-2560
URL: https://issues.apache.org/jira/browse/MYFACES-2560
Project: MyFaces Core
Issue Type: Bug
Components: JSR-314
Affects Versions: 2.0.0-beta, 2.0.0-alpha
Environment: JSP 2.0 Environment, like Google App Engine
Reporter: Ali Ok
On Jsp2.0 environment using Myfaces 2.0 beta, users should provide the
ExpressionFactory implementation.
And if Jasper EL Impl or Sun's RI is available on the classpath, they are
automatically set.
However, impl class name of RI may be wrong.
Until revision 761982, it was "com.sun.el.ExpressionFactoryImpl", which is
correct class name.
Then it became "com.sun.facelets.el.ExpressionFactoryImpl", that I couldn't
find anywhere (spec, facelets.dev.java.net, etc. )
Is this change correct?
You can see the code on Jsp20FacesInitializer#EL_RI_EXPRESSION_FACTORY_IMPL.
It is still "com.sun.el.ExpressionFactoryImpl" on Myfaces 1.2.8.
It is not big deal, I can override it with a context parameter; but running
Myfaces out-of-the-box is important :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MYFACES-2560) Known class name for EL RI's
ExpressionFactoryImpl is wrong
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Korherr updated MYFACES-2560:
-----------------------------------
Resolution: Fixed
Fix Version/s: 2.0.0-beta-3
Status: Resolved (was: Patch Available)
> Known class name for EL RI's ExpressionFactoryImpl is wrong
> -----------------------------------------------------------
>
> Key: MYFACES-2560
> URL: https://issues.apache.org/jira/browse/MYFACES-2560
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-alpha, 2.0.0-beta
> Environment: JSP 2.0 Environment, like Google App Engine
> Reporter: Ali Ok
> Assignee: Jakob Korherr
> Fix For: 2.0.0-beta-3
>
> Attachments: 2560.patch
>
>
> On Jsp2.0 environment using Myfaces 2.0 beta, users should provide the
> ExpressionFactory implementation.
> And if Jasper EL Impl or Sun's RI is available on the classpath, they are
> automatically set.
> However, impl class name of RI may be wrong.
> Until revision 761982, it was "com.sun.el.ExpressionFactoryImpl", which is
> correct class name.
> Then it became "com.sun.facelets.el.ExpressionFactoryImpl", that I couldn't
> find anywhere (spec, facelets.dev.java.net, etc. )
> Is this change correct?
> You can see the code on Jsp20FacesInitializer#EL_RI_EXPRESSION_FACTORY_IMPL.
> It is still "com.sun.el.ExpressionFactoryImpl" on Myfaces 1.2.8.
> It is not big deal, I can override it with a context parameter; but running
> Myfaces out-of-the-box is important :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2560) Known class name for EL RI's
ExpressionFactoryImpl is wrong
Posted by "Ali Ok (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843566#action_12843566 ]
Ali Ok commented on MYFACES-2560:
---------------------------------
Thanks for the commit Jakob.
Configuration required to run MyFaces on Google App Engine is reduced by one unnecessary instruction :)
> Known class name for EL RI's ExpressionFactoryImpl is wrong
> -----------------------------------------------------------
>
> Key: MYFACES-2560
> URL: https://issues.apache.org/jira/browse/MYFACES-2560
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-alpha, 2.0.0-beta
> Environment: JSP 2.0 Environment, like Google App Engine
> Reporter: Ali Ok
> Assignee: Jakob Korherr
> Fix For: 2.0.0-beta-3
>
> Attachments: 2560.patch
>
>
> On Jsp2.0 environment using Myfaces 2.0 beta, users should provide the
> ExpressionFactory implementation.
> And if Jasper EL Impl or Sun's RI is available on the classpath, they are
> automatically set.
> However, impl class name of RI may be wrong.
> Until revision 761982, it was "com.sun.el.ExpressionFactoryImpl", which is
> correct class name.
> Then it became "com.sun.facelets.el.ExpressionFactoryImpl", that I couldn't
> find anywhere (spec, facelets.dev.java.net, etc. )
> Is this change correct?
> You can see the code on Jsp20FacesInitializer#EL_RI_EXPRESSION_FACTORY_IMPL.
> It is still "com.sun.el.ExpressionFactoryImpl" on Myfaces 1.2.8.
> It is not big deal, I can override it with a context parameter; but running
> Myfaces out-of-the-box is important :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MYFACES-2560) Known class name for EL RI's
ExpressionFactoryImpl is wrong
Posted by "Ali Ok (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ali Ok updated MYFACES-2560:
----------------------------
Status: Patch Available (was: Open)
> Known class name for EL RI's ExpressionFactoryImpl is wrong
> -----------------------------------------------------------
>
> Key: MYFACES-2560
> URL: https://issues.apache.org/jira/browse/MYFACES-2560
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-alpha, 2.0.0-beta
> Environment: JSP 2.0 Environment, like Google App Engine
> Reporter: Ali Ok
>
> On Jsp2.0 environment using Myfaces 2.0 beta, users should provide the
> ExpressionFactory implementation.
> And if Jasper EL Impl or Sun's RI is available on the classpath, they are
> automatically set.
> However, impl class name of RI may be wrong.
> Until revision 761982, it was "com.sun.el.ExpressionFactoryImpl", which is
> correct class name.
> Then it became "com.sun.facelets.el.ExpressionFactoryImpl", that I couldn't
> find anywhere (spec, facelets.dev.java.net, etc. )
> Is this change correct?
> You can see the code on Jsp20FacesInitializer#EL_RI_EXPRESSION_FACTORY_IMPL.
> It is still "com.sun.el.ExpressionFactoryImpl" on Myfaces 1.2.8.
> It is not big deal, I can override it with a context parameter; but running
> Myfaces out-of-the-box is important :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2560) Known class name for EL RI's
ExpressionFactoryImpl is wrong
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843568#action_12843568 ]
Jakob Korherr commented on MYFACES-2560:
----------------------------------------
You're welcome! And thanks for the patch ;)
Great!
> Known class name for EL RI's ExpressionFactoryImpl is wrong
> -----------------------------------------------------------
>
> Key: MYFACES-2560
> URL: https://issues.apache.org/jira/browse/MYFACES-2560
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-alpha, 2.0.0-beta
> Environment: JSP 2.0 Environment, like Google App Engine
> Reporter: Ali Ok
> Assignee: Jakob Korherr
> Fix For: 2.0.0-beta-3
>
> Attachments: 2560.patch
>
>
> On Jsp2.0 environment using Myfaces 2.0 beta, users should provide the
> ExpressionFactory implementation.
> And if Jasper EL Impl or Sun's RI is available on the classpath, they are
> automatically set.
> However, impl class name of RI may be wrong.
> Until revision 761982, it was "com.sun.el.ExpressionFactoryImpl", which is
> correct class name.
> Then it became "com.sun.facelets.el.ExpressionFactoryImpl", that I couldn't
> find anywhere (spec, facelets.dev.java.net, etc. )
> Is this change correct?
> You can see the code on Jsp20FacesInitializer#EL_RI_EXPRESSION_FACTORY_IMPL.
> It is still "com.sun.el.ExpressionFactoryImpl" on Myfaces 1.2.8.
> It is not big deal, I can override it with a context parameter; but running
> Myfaces out-of-the-box is important :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-2560) Known class name for EL RI's
ExpressionFactoryImpl is wrong
Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/MYFACES-2560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843563#action_12843563 ]
Jakob Korherr commented on MYFACES-2560:
----------------------------------------
This was changed in Revision 761982 with the comment Synchronized the code with final draft (2009-03-27). However I also couldn't find this change documented anywhere else, so I think it's the best thing to change it back the way it was (which I also personally think is the right class)!
> Known class name for EL RI's ExpressionFactoryImpl is wrong
> -----------------------------------------------------------
>
> Key: MYFACES-2560
> URL: https://issues.apache.org/jira/browse/MYFACES-2560
> Project: MyFaces Core
> Issue Type: Bug
> Components: JSR-314
> Affects Versions: 2.0.0-alpha, 2.0.0-beta
> Environment: JSP 2.0 Environment, like Google App Engine
> Reporter: Ali Ok
> Assignee: Jakob Korherr
> Attachments: 2560.patch
>
>
> On Jsp2.0 environment using Myfaces 2.0 beta, users should provide the
> ExpressionFactory implementation.
> And if Jasper EL Impl or Sun's RI is available on the classpath, they are
> automatically set.
> However, impl class name of RI may be wrong.
> Until revision 761982, it was "com.sun.el.ExpressionFactoryImpl", which is
> correct class name.
> Then it became "com.sun.facelets.el.ExpressionFactoryImpl", that I couldn't
> find anywhere (spec, facelets.dev.java.net, etc. )
> Is this change correct?
> You can see the code on Jsp20FacesInitializer#EL_RI_EXPRESSION_FACTORY_IMPL.
> It is still "com.sun.el.ExpressionFactoryImpl" on Myfaces 1.2.8.
> It is not big deal, I can override it with a context parameter; but running
> Myfaces out-of-the-box is important :)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.