You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/12 18:06:30 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #5728: drivers: Merge the common driver initialization into one place
xiaoxiang781216 opened a new pull request #5728:
URL: https://github.com/apache/incubator-nuttx/pull/5728
## Summary
## Impact
Minor, code refactor
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5728: drivers: Merge the common driver initialization into one place
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5728:
URL: https://github.com/apache/incubator-nuttx/pull/5728#discussion_r825345350
##########
File path: arch/mips/src/common/mips_initialize.c
##########
@@ -67,10 +52,6 @@
void up_initialize(void)
{
- /* Initialize global variables */
-
- CURRENT_REGS = NULL;
Review comment:
Yes, the global variable is already zero.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5728: drivers: Merge the common driver initialization into one place
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5728:
URL: https://github.com/apache/incubator-nuttx/pull/5728#discussion_r825340423
##########
File path: arch/sim/src/sim/up_initialize.c
##########
@@ -351,5 +243,7 @@ void up_initialize(void)
audio_register("pcm0c", sim_audio_initialize(false));
#endif
- up_loop_init();
+ kthread_create("loop_task", 1,
Review comment:
```suggestion
kthread_create("loop_task", SCHED_PRIORITY_MIN,
```
##########
File path: arch/mips/src/common/mips_initialize.c
##########
@@ -67,10 +52,6 @@
void up_initialize(void)
{
- /* Initialize global variables */
-
- CURRENT_REGS = NULL;
Review comment:
Just to make sure that this is intentional change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5728: drivers: Merge the common driver initialization into one place
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5728:
URL: https://github.com/apache/incubator-nuttx/pull/5728#discussion_r825345749
##########
File path: arch/sim/src/sim/up_initialize.c
##########
@@ -351,5 +243,7 @@ void up_initialize(void)
audio_register("pcm0c", sim_audio_initialize(false));
#endif
- up_loop_init();
+ kthread_create("loop_task", 1,
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis merged pull request #5728: drivers: Merge the common driver initialization into one place
Posted by GitBox <gi...@apache.org>.
acassis merged pull request #5728:
URL: https://github.com/apache/incubator-nuttx/pull/5728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org