You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2019/01/10 14:20:23 UTC
[GitHub] alamar commented on a change in pull request #5798: IGNITE-10886
JVM_OPTS and -J-PARAMS doesn't allow spaces
alamar commented on a change in pull request #5798: IGNITE-10886 JVM_OPTS and -J-PARAMS doesn't allow spaces
URL: https://github.com/apache/ignite/pull/5798#discussion_r246775093
##########
File path: bin/ignite.sh
##########
@@ -186,26 +186,26 @@ do
if [ "${INTERACTIVE}" == "1" ] ; then
case $osname in
Darwin*)
- "$JAVA" ${JVM_OPTS} ${QUIET} "${DOCK_OPTS}" "${RESTART_SUCCESS_OPT}" ${JMX_MON} \
- -DIGNITE_UPDATE_NOTIFIER=false -DIGNITE_HOME="${IGNITE_HOME}" \
- -DIGNITE_PROG_NAME="$0" ${JVM_XOPTS} -cp "${CP}" ${MAIN_CLASS}
+ echo "$JVM_OPTS $JVM_XOPTS" | xargs -I {} "$JAVA" {} ${QUIET} "${DOCK_OPTS}" "${RESTART_SUCCESS_OPT}" ${JMX_MON} \
+ -DIGNITE_HOME="${IGNITE_HOME}" \
+ -DIGNITE_PROG_NAME="$0" -cp "${CP}" ${MAIN_CLASS}
;;
*)
- "$JAVA" ${JVM_OPTS} ${QUIET} "${RESTART_SUCCESS_OPT}" ${JMX_MON} \
- -DIGNITE_UPDATE_NOTIFIER=false -DIGNITE_HOME="${IGNITE_HOME}" \
+ echo "$JVM_OPTS $JVM_XOPTS" | xargs -I {} "$JAVA" {} ${QUIET} "${RESTART_SUCCESS_OPT}" ${JMX_MON} \
+ -DIGNITE_HOME="${IGNITE_HOME}" \
-DIGNITE_PROG_NAME="$0" ${JVM_XOPTS} -cp "${CP}" ${MAIN_CLASS}
Review comment:
Duplicate XOPTS here and below
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services