[incubator-uniffle] branch master updated: [MINOR] chore: delete checkstyle-suppressions.xml (#878)

[ro...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

roryqi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git


The following commit(s) were added to refs/heads/master by this push:
     new e1e5fa8e [MINOR] chore: delete checkstyle-suppressions.xml (#878)
e1e5fa8e is described below

commit e1e5fa8ed65b71d4b1ef49684704d01d8e5bc949
Author: Kaijie Chen <ck...@apache.org>
AuthorDate: Sun May 14 13:38:39 2023 +0800

    [MINOR] chore: delete checkstyle-suppressions.xml (#878)
    
    ### What changes were proposed in this pull request?
    
    Delete checkstyle-suppressions.xml
    
    ### Why are the changes needed?
    
    It's not taking any effect.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    No need.
---
 checkstyle-suppressions.xml | 23 -----------------------
 checkstyle.xml              |  5 +++--
 pom.xml                     |  1 -
 3 files changed, 3 insertions(+), 26 deletions(-)

diff --git a/checkstyle-suppressions.xml b/checkstyle-suppressions.xml
deleted file mode 100644
index 86226f35..00000000
--- a/checkstyle-suppressions.xml
+++ /dev/null
@@ -1,23 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!--
-  ~ Licensed to the Apache Software Foundation (ASF) under one or more
-  ~ contributor license agreements.  See the NOTICE file distributed with
-  ~ this work for additional information regarding copyright ownership.
-  ~ The ASF licenses this file to You under the Apache License, Version 2.0
-  ~ (the "License"); you may not use this file except in compliance with
-  ~ the License.  You may obtain a copy of the License at
-  ~
-  ~    http://www.apache.org/licenses/LICENSE-2.0
-  ~
-  ~ Unless required by applicable law or agreed to in writing, software
-  ~ distributed under the License is distributed on an "AS IS" BASIS,
-  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-  ~ See the License for the specific language governing permissions and
-  ~ limitations under the License.
-  -->
-<!DOCTYPE suppressions PUBLIC
-  "-//Puppy Crawl//DTD Suppressions 1.1//EN"
-  "http://www.puppycrawl.com/dtds/suppressions_1_1.dtd">
-<suppressions>
-  <suppress checks="." files="java[\\/]org[\\/]apache[\\/]hive[\\/]service"/>
-</suppressions>
diff --git a/checkstyle.xml b/checkstyle.xml
index 9c24b9c9..19c20165 100644
--- a/checkstyle.xml
+++ b/checkstyle.xml
@@ -29,11 +29,12 @@
         <property name="fileNamePattern" value="module\-info\.java$"/>
     </module>
     <!-- https://checkstyle.org/config_filters.html#SuppressionFilter -->
+    <!--
     <module name="SuppressionFilter">
-        <property name="file" value="${org.checkstyle.google.suppressionfilter.config}"
-                  default="checkstyle-suppressions.xml" />
+        <property name="file" default="checkstyle-suppressions.xml"/>
         <property name="optional" value="true"/>
     </module>
+    -->
     <!-- new add -->
     <module name="SuppressWarningsFilter" />
     <!-- Checks for whitespace                               -->
diff --git a/pom.xml b/pom.xml
index 0368f717..98cf3ed2 100644
--- a/pom.xml
+++ b/pom.xml
@@ -863,7 +863,6 @@
         <version>${maven-checkstyle-plugin.version}</version>
         <configuration>
           <configLocation>checkstyle.xml</configLocation>
-          <suppressionsLocation>checkstyle-suppressions.xml</suppressionsLocation>
           <encoding>UTF-8</encoding>
           <consoleOutput>true</consoleOutput>
           <failsOnError>true</failsOnError>