You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by Claudenw <gi...@git.apache.org> on 2018/01/21 13:32:43 UTC
[GitHub] jena pull request #343: Fixes for JENA-1457
GitHub user Claudenw opened a pull request:
https://github.com/apache/jena/pull/343
Fixes for JENA-1457
I had some issues with merging into my branch so I created this pull to ensure that only expected files were updated.
As part of addition ot JENA-1457 this updates junit-contracts to version 0.2.0
Also added .recommenders directory to RAT exclude. (it was already in .gitignore)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Claudenw/jena master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/343.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #343
----
commit 50703b41060227741304d5e6e236ef57c10b6df8
Author: Claude Warren <cl...@...>
Date: 2017-12-29T20:45:33Z
fixed Graph tests
commit 20b78ae0ddc7a2102602a28f9ed3f48a40c99a1b
Author: Andy Seaborne <an...@...>
Date: 2017-12-18T14:49:40Z
Blank node labels for JSON Result Set reading
commit 30989a54b4aec3453152ce970832eea8e8acc0d3
Author: Claude Warren <cl...@...>
Date: 2018-01-20T10:10:53Z
Merge remote-tracking branch 'apache/master' into FixGraphContractTestTransactionUsage
commit fa23c25835247e2586ed37ad491c45322dca45b6
Author: Claude Warren <cl...@...>
Date: 2018-01-20T10:40:33Z
Added .recommenders to RAT exclusion.
commit 185badb543a6290ae533a0142f416ab4f466043b
Author: Claude Warren <cl...@...>
Date: 2018-01-20T21:29:36Z
Updated version number for junit-contracts to 0.2.0
commit 363e95818710ec45352bf8e1330dcf3bf1f59686
Author: Claude Warren <cl...@...>
Date: 2018-01-21T12:13:23Z
Merge branch 'master' into FixGraphContractTestTransactionUsage
commit 554a7dc86a4967a9971354f4d7b19354a9d07402
Author: Claude Warren <cl...@...>
Date: 2018-01-21T13:12:19Z
fixes JENA-1457
Removed incorrect JSONInput.java
----
---
[GitHub] jena issue #343: Fixes for JENA-1457
Posted by afs <gi...@git.apache.org>.
Github user afs commented on the issue:
https://github.com/apache/jena/pull/343
Yes - there are problems with JSONInput. This is visible in the {{.patch}} form. It looks like changes were copied from Jena master and separately committed.
---
[GitHub] jena pull request #343: Fixes for JENA-1457
Posted by afs <gi...@git.apache.org>.
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/343#discussion_r162823649
--- Diff: jena-core/src/test/java/org/apache/jena/graph/GraphWithPerformContractTest.java ---
@@ -68,7 +68,13 @@ public void testPerformAdd_Triple() {
g.performAdd(triple("S3 P3 O3"));
txnCommit(g);
GL.assertEmpty();
+ txnRun( g, new Runnable() {
--- End diff --
There is no need to explicitly have a `Runnable` here or in the other uses:
```
txnRun( g, ()->assertTrue(g.contains(triple("S3 P3 O3"))) );
```
makes the tests shorter and clearer.
---
[GitHub] jena pull request #343: Fixes for JENA-1457
Posted by Claudenw <gi...@git.apache.org>.
Github user Claudenw closed the pull request at:
https://github.com/apache/jena/pull/343
---