You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geode.apache.org by sboorlagadda <gi...@git.apache.org> on 2016/02/05 20:21:56 UTC

[GitHub] incubator-geode pull request: Geode 891: DataType needs better uni...

GitHub user sboorlagadda opened a pull request:

    https://github.com/apache/incubator-geode/pull/89

    Geode 891: DataType needs better unit test coverage

    * Added tests for missing cases
    * Removed SQLF case

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sboorlagadda/incubator-geode GEODE-891

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-geode/pull/89.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #89
    
----
commit 03158afb9f6398dbc3f481172bc235ceb56819ac
Author: Sai Boorlagadda <sb...@pivotal.io>
Date:   2016-02-02T23:29:49Z

    GEODE-891 : DataType needs better unit test coverage
    
    * Added tests for missing cases
    * Removed SQLF case

commit c47c236d79edc2c43b9d0251ffb89f94b0741e97
Author: Sai Boorlagadda <sb...@pivotal.io>
Date:   2016-02-04T22:50:55Z

    Added PowerMockIgnore annotation to defer class loading.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request: Geode 891: DataType needs better uni...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-geode/pull/89


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request: Geode 891: DataType needs better uni...

Posted by dschneider-pivotal <gi...@git.apache.org>.

Github user dschneider-pivotal commented on the pull request:

    https://github.com/apache/incubator-geode/pull/89#issuecomment-180632089
  
    I will pull this in


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request: Geode 891: DataType needs better uni...

Posted by sboorlagadda <gi...@git.apache.org>.

Github user sboorlagadda commented on the pull request:

    https://github.com/apache/incubator-geode/pull/89#issuecomment-180510365
  
    RBT URL: https://reviews.apache.org/r/43155/


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---