You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/04/22 00:41:54 UTC
[kudu-CR] [webserver-test] fix TestInvalidHeaders on macOS
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15779
Change subject: [webserver-test] fix TestInvalidHeaders on macOS
......................................................................
[webserver-test] fix TestInvalidHeaders on macOS
Change-Id: I19cfb90ba18bf8b9125ca635f2417f4058c4c5f1
---
M src/kudu/server/webserver-test.cc
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/15779/1
--
To view, visit http://gerrit.cloudera.org:8080/15779
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I19cfb90ba18bf8b9125ca635f2417f4058c4c5f1
Gerrit-Change-Number: 15779
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [webserver-test] fix TestInvalidHeaders on macOS
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15779 )
Change subject: [webserver-test] fix TestInvalidHeaders on macOS
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15779
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19cfb90ba18bf8b9125ca635f2417f4058c4c5f1
Gerrit-Change-Number: 15779
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 22 Apr 2020 03:55:12 +0000
Gerrit-HasComments: No
[kudu-CR] [webserver-test] fix TestInvalidHeaders on macOS
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15779 )
Change subject: [webserver-test] fix TestInvalidHeaders on macOS
......................................................................
[webserver-test] fix TestInvalidHeaders on macOS
Change-Id: I19cfb90ba18bf8b9125ca635f2417f4058c4c5f1
Reviewed-on: http://gerrit.cloudera.org:8080/15779
Reviewed-by: Hao Hao <ha...@cloudera.com>
Reviewed-by: Volodymyr Verovkin <ve...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/server/webserver-test.cc
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Hao Hao: Looks good to me, approved
Volodymyr Verovkin: Looks good to me, but someone else must approve
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15779
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I19cfb90ba18bf8b9125ca635f2417f4058c4c5f1
Gerrit-Change-Number: 15779
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
[kudu-CR] [webserver-test] fix TestInvalidHeaders on macOS
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [webserver-test] fix TestInvalidHeaders on macOS
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/15779
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I19cfb90ba18bf8b9125ca635f2417f4058c4c5f1
Gerrit-Change-Number: 15779
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
[kudu-CR] [webserver-test] fix TestInvalidHeaders on macOS
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15779 )
Change subject: [webserver-test] fix TestInvalidHeaders on macOS
......................................................................
Patch Set 1: Verified+1
Unrelated build failures due to sub-process JARs and also it seems a machine was down during the build:
18:01:12 pip._vendor.urllib3.exceptions.ProtocolError: ("Connection broken: ConnectionResetError(104, 'Connection reset by peer')", ConnectionResetError(104, 'Connection reset by peer'))
--
To view, visit http://gerrit.cloudera.org:8080/15779
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19cfb90ba18bf8b9125ca635f2417f4058c4c5f1
Gerrit-Change-Number: 15779
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Apr 2020 15:14:06 +0000
Gerrit-HasComments: No
[kudu-CR] [webserver-test] fix TestInvalidHeaders on macOS
Posted by "Volodymyr Verovkin (Code Review)" <ge...@cloudera.org>.
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15779 )
Change subject: [webserver-test] fix TestInvalidHeaders on macOS
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/15779
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19cfb90ba18bf8b9125ca635f2417f4058c4c5f1
Gerrit-Change-Number: 15779
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Apr 2020 03:59:52 +0000
Gerrit-HasComments: No