[GitHub] [arrow] pitrou commented on a change in pull request #11798: ARROW-7051: [C++] Improve MakeArrayOfNull to support creation of multiple arrays

[GitBox <gi...@apache.org>]

pitrou commented on a change in pull request #11798:
URL: https://github.com/apache/arrow/pull/11798#discussion_r761004032



##########
File path: cpp/src/arrow/compute/kernels/util_internal.h
##########
@@ -161,6 +164,21 @@ int64_t CopyNonNullValues(const Datum& datum, T* out) {
   return n;
 }
 
+//--------------------------------------------------------------------------
+// An internal function to create an empty array, chucked array, record batch and table.
+
+Result<std::shared_ptr<Array>> CreateEmptyArray(std::shared_ptr<DataType> type,
+                                                MemoryPool* memory_pool);

Review comment:
       1) Is there a reason these functions are in `compute/kernels/util_internal.h` rather than public APIs? These could go in the respective public headers, such as `array/util.h`, `chunked_array.h`, etc.
   
   2) We generally use "Make" rather than "Create" when naming factory functions (e.g. "MakeArrayOfNull"), can you reuse the same convention here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org