You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/14 09:22:13 UTC

[GitHub] [apisix] spacewander opened a new pull request #2418: change: use 405 as the error code for unsupported HTTP method

spacewander opened a new pull request #2418:
URL: https://github.com/apache/apisix/pull/2418


   ### What this PR does / why we need it:
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   
   ### Pre-submission checklist:
   
   * [ ] Did you explain what problem does this PR solve? Or what new features have been added?
   * [x] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on pull request #2418: change: use 405 as the error code for unsupported HTTP method

Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #2418:
URL: https://github.com/apache/apisix/pull/2418#issuecomment-709667024


   @membphis 
   There is one: https://github.com/apache/apisix/pull/2418/files#diff-71cab91a4d79fa23828f2cbf6ba02ff99f93d0109e4cc2b392253ffcf6d99889R304
   I don't add test case to plugin_metadata as it will conflict with my another PR, and the case is trivial.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis commented on pull request #2418: change: use 405 as the error code for unsupported HTTP method

Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #2418:
URL: https://github.com/apache/apisix/pull/2418#issuecomment-709668650


   merged, many thx ^_^


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis merged pull request #2418: change: use 405 as the error code for unsupported HTTP method

Posted by GitBox <gi...@apache.org>.
membphis merged pull request #2418:
URL: https://github.com/apache/apisix/pull/2418


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis commented on pull request #2418: change: use 405 as the error code for unsupported HTTP method

Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #2418:
URL: https://github.com/apache/apisix/pull/2418#issuecomment-709668494


   @spacewander got it, thx for your explain


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org