[GitHub] [solr] HoustonPutman commented on a diff in pull request #1941: SOLR-16925 Broken JSON indentation using JacksonJsonWriter

["HoustonPutman (via GitHub)" <gi...@apache.org>]

HoustonPutman commented on code in PR #1941:
URL: https://github.com/apache/solr/pull/1941#discussion_r1331893557


##########
solr/core/src/java/org/apache/solr/response/JacksonJsonWriter.java:
##########
@@ -25,11 +25,17 @@
 import java.io.OutputStream;
 import java.math.BigDecimal;
 import java.math.BigInteger;
+import java.util.Arrays;
 import org.apache.solr.common.PushWriter;
 import org.apache.solr.request.SolrQueryRequest;
 
 /** A JSON ResponseWriter that uses jackson. */
 public class JacksonJsonWriter extends BinaryResponseWriter {
+  private static final char[] indentChars = new char[81];
+
+  static {
+    Arrays.fill(indentChars, ' ');
+  }
 
   protected final JsonFactory jsonfactory;
   protected static final PrettyPrinter pretty =

Review Comment:
   ```suggestion
     protected static final DefaultPrettyPrinter pretty =
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org