You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/03/19 02:16:58 UTC
[GitHub] [apisix] iamayushdas opened a new pull request #3866: docs: added key types for limit-count plugin
iamayushdas opened a new pull request #3866:
URL: https://github.com/apache/apisix/pull/3866
### What this PR does / why we need it:
To make users aware of limit-count key types the can use
#3855
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [x] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3866: docs: added key types for limit-count plugin
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #3866:
URL: https://github.com/apache/apisix/pull/3866#discussion_r597372780
##########
File path: docs/en/latest/plugins/limit-count.md
##########
@@ -79,7 +79,17 @@ curl -i http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335
You can open dashboard with a browser: `http://127.0.0.1:9080/apisix/dashboard/`, to complete the above operation through the web interface, first add a route:

-Then add limit-count plugin:
+## Then add limit-count plugin:
Review comment:
Why make it a title?
##########
File path: docs/en/latest/plugins/limit-count.md
##########
@@ -79,7 +79,17 @@ curl -i http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335
You can open dashboard with a browser: `http://127.0.0.1:9080/apisix/dashboard/`, to complete the above operation through the web interface, first add a route:

-Then add limit-count plugin:
+## Then add limit-count plugin:
+
+The <strong>Key type</strong> in limit-count plugin can be the following:
Review comment:
Please use markdown syntax if possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] iamayushdas closed pull request #3866: docs: added key types for limit-count plugin
Posted by GitBox <gi...@apache.org>.
iamayushdas closed pull request #3866:
URL: https://github.com/apache/apisix/pull/3866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] iamayushdas commented on a change in pull request #3866: docs: added key types for limit-count plugin
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #3866:
URL: https://github.com/apache/apisix/pull/3866#discussion_r597375631
##########
File path: docs/en/latest/plugins/limit-count.md
##########
@@ -79,7 +79,17 @@ curl -i http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335
You can open dashboard with a browser: `http://127.0.0.1:9080/apisix/dashboard/`, to complete the above operation through the web interface, first add a route:

-Then add limit-count plugin:
+## Then add limit-count plugin:
Review comment:
#### Then add limit-count plugin:
is this size good to go?
to make it lil bit more noticed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] iamayushdas commented on a change in pull request #3866: docs: added key types for limit-count plugin
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #3866:
URL: https://github.com/apache/apisix/pull/3866#discussion_r597376468
##########
File path: docs/en/latest/plugins/limit-count.md
##########
@@ -79,7 +79,17 @@ curl -i http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335
You can open dashboard with a browser: `http://127.0.0.1:9080/apisix/dashboard/`, to complete the above operation through the web interface, first add a route:

-Then add limit-count plugin:
+## Then add limit-count plugin:
+
+The <strong>Key type</strong> in limit-count plugin can be the following:
Review comment:
changes done in next commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org