You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/12/14 18:36:23 UTC
[GitHub] [trafficcontrol] mitchell852 opened a new pull request #6425: adds note to blueprint regarding lazy consensus option
mitchell852 opened a new pull request #6425:
URL: https://github.com/apache/trafficcontrol/pull/6425
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this PR.
Feel free to add the name of a tool or script that is affected but not on the list.
-->
- Documentation
## What is the best way to verify this PR?
Read Contributing.md file, blueprint section
## PR submission checklist
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #6425: adds note to blueprint regarding lazy consensus option
Posted by GitBox <gi...@apache.org>.
rawlinp commented on a change in pull request #6425:
URL: https://github.com/apache/trafficcontrol/pull/6425#discussion_r770923316
##########
File path: CONTRIBUTING.md
##########
@@ -68,7 +68,7 @@ list with a short description of your feature plus a link to the blueprint PR.
1. Wait for feedback to be applied to your blueprint PR. Because it's a PR,
line-specific feedback can be given.
1. Just like any PR, once all the concerns have been addressed, the blueprint is
-merged into the blueprints directory (if accepted) or closed (if rejected).
+merged into the blueprints directory (if accepted) or closed (if rejected). Note: Blueprint authors have the option of invoking [lazy consensus](https://community.apache.org/committers/lazyConsensus.html) to facilitate the merge of the blueprint if community feedback is not being provided or feedback has stalled. To invoke lazy consensus, please make the community aware via an email to the [dev@trafficcontrol.apache.org](mailto:dev@trafficcontrol.apache.org) mailing list that you intend to invoke lazy consensus after X hours with no feedback.
Review comment:
I would leave that up to the discretion of the blueprint submitter IMO. Let's say someone reviews your blueprint then goes on vacation for two weeks. Depending on their feedback, you might think they'd be ok with the blueprint merging once their feedback is addressed, rather than forcing you to wait 2 weeks for them to get back. Plus, it's not like once a blueprint is reviewed and merged that the design cannot change after that. Merging a blueprint just generally means you should be able to move forward with the proposed design, although that's not a hard rule either. In the above scenario, if the person who left feedback still didn't agree with the blueprint after it was merged, the blueprint could always be changed (assuming general consensus on the new change).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #6425: adds note to blueprint regarding lazy consensus option
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on a change in pull request #6425:
URL: https://github.com/apache/trafficcontrol/pull/6425#discussion_r769026725
##########
File path: CONTRIBUTING.md
##########
@@ -68,7 +68,7 @@ list with a short description of your feature plus a link to the blueprint PR.
1. Wait for feedback to be applied to your blueprint PR. Because it's a PR,
line-specific feedback can be given.
1. Just like any PR, once all the concerns have been addressed, the blueprint is
-merged into the blueprints directory (if accepted) or closed (if rejected).
+merged into the blueprints directory (if accepted) or closed (if rejected). Note: Blueprint authors have the option of invoking <a href="https://community.apache.org/committers/lazyConsensus.html" target="_blank">lazy consensus</a> to facilitate the merge of the blueprint if community feedback is not being provided or feedback has stalled. To invoke lazy consensus, please make the community aware via an email to the dev mailing list that you intend to invoke lazy consensus after X hours with no feedback.
Review comment:
> Why are you using an HTML anchor tag instead of just a markdown link?
oh haha. that's what happens when i do something fast w/o thinking very much. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #6425: adds note to blueprint regarding lazy consensus option
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #6425:
URL: https://github.com/apache/trafficcontrol/pull/6425#discussion_r768988585
##########
File path: CONTRIBUTING.md
##########
@@ -68,7 +68,7 @@ list with a short description of your feature plus a link to the blueprint PR.
1. Wait for feedback to be applied to your blueprint PR. Because it's a PR,
line-specific feedback can be given.
1. Just like any PR, once all the concerns have been addressed, the blueprint is
-merged into the blueprints directory (if accepted) or closed (if rejected).
+merged into the blueprints directory (if accepted) or closed (if rejected). Note: Blueprint authors have the option of invoking <a href="https://community.apache.org/committers/lazyConsensus.html" target="_blank">lazy consensus</a> to facilitate the merge of the blueprint if community feedback is not being provided or feedback has stalled. To invoke lazy consensus, please make the community aware via an email to the dev mailing list that you intend to invoke lazy consensus after X hours with no feedback.
Review comment:
Why are you using an HTML anchor tag instead of just a markdown link?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #6425: adds note to blueprint regarding lazy consensus option
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on a change in pull request #6425:
URL: https://github.com/apache/trafficcontrol/pull/6425#discussion_r770924797
##########
File path: CONTRIBUTING.md
##########
@@ -68,7 +68,7 @@ list with a short description of your feature plus a link to the blueprint PR.
1. Wait for feedback to be applied to your blueprint PR. Because it's a PR,
line-specific feedback can be given.
1. Just like any PR, once all the concerns have been addressed, the blueprint is
-merged into the blueprints directory (if accepted) or closed (if rejected).
+merged into the blueprints directory (if accepted) or closed (if rejected). Note: Blueprint authors have the option of invoking [lazy consensus](https://community.apache.org/committers/lazyConsensus.html) to facilitate the merge of the blueprint if community feedback is not being provided or feedback has stalled. To invoke lazy consensus, please make the community aware via an email to the [dev@trafficcontrol.apache.org](mailto:dev@trafficcontrol.apache.org) mailing list that you intend to invoke lazy consensus after X hours with no feedback.
Review comment:
Sounds good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #6425: adds note to blueprint regarding lazy consensus option
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on a change in pull request #6425:
URL: https://github.com/apache/trafficcontrol/pull/6425#discussion_r770914393
##########
File path: CONTRIBUTING.md
##########
@@ -68,7 +68,7 @@ list with a short description of your feature plus a link to the blueprint PR.
1. Wait for feedback to be applied to your blueprint PR. Because it's a PR,
line-specific feedback can be given.
1. Just like any PR, once all the concerns have been addressed, the blueprint is
-merged into the blueprints directory (if accepted) or closed (if rejected).
+merged into the blueprints directory (if accepted) or closed (if rejected). Note: Blueprint authors have the option of invoking [lazy consensus](https://community.apache.org/committers/lazyConsensus.html) to facilitate the merge of the blueprint if community feedback is not being provided or feedback has stalled. To invoke lazy consensus, please make the community aware via an email to the [dev@trafficcontrol.apache.org](mailto:dev@trafficcontrol.apache.org) mailing list that you intend to invoke lazy consensus after X hours with no feedback.
Review comment:
"feedback has stalled" implies that some feedback has already been left. Is there a precedent for lazy consensus being used, in this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman merged pull request #6425: adds note to blueprint regarding lazy consensus option
Posted by GitBox <gi...@apache.org>.
zrhoffman merged pull request #6425:
URL: https://github.com/apache/trafficcontrol/pull/6425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #6425: adds note to blueprint regarding lazy consensus option
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on a change in pull request #6425:
URL: https://github.com/apache/trafficcontrol/pull/6425#discussion_r770880006
##########
File path: CONTRIBUTING.md
##########
@@ -68,7 +68,7 @@ list with a short description of your feature plus a link to the blueprint PR.
1. Wait for feedback to be applied to your blueprint PR. Because it's a PR,
line-specific feedback can be given.
1. Just like any PR, once all the concerns have been addressed, the blueprint is
-merged into the blueprints directory (if accepted) or closed (if rejected).
+merged into the blueprints directory (if accepted) or closed (if rejected). Note: Blueprint authors have the option of invoking [lazy consensus](https://community.apache.org/committers/lazyConsensus.html) to facilitate the merge of the blueprint if community feedback is not being provided or feedback has stalled. To invoke lazy consensus, please make the community aware via an email to the [dev@trafficcontrol.apache.org](mailto:dev@trafficcontrol.apache.org) mailing list that you intend to invoke lazy consensus after X hours with no feedback.
Review comment:
Maybe mention that lazy consensus cannot be invoked once any feedback is left.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #6425: adds note to blueprint regarding lazy consensus option
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on a change in pull request #6425:
URL: https://github.com/apache/trafficcontrol/pull/6425#discussion_r770902588
##########
File path: CONTRIBUTING.md
##########
@@ -68,7 +68,7 @@ list with a short description of your feature plus a link to the blueprint PR.
1. Wait for feedback to be applied to your blueprint PR. Because it's a PR,
line-specific feedback can be given.
1. Just like any PR, once all the concerns have been addressed, the blueprint is
-merged into the blueprints directory (if accepted) or closed (if rejected).
+merged into the blueprints directory (if accepted) or closed (if rejected). Note: Blueprint authors have the option of invoking [lazy consensus](https://community.apache.org/committers/lazyConsensus.html) to facilitate the merge of the blueprint if community feedback is not being provided or feedback has stalled. To invoke lazy consensus, please make the community aware via an email to the [dev@trafficcontrol.apache.org](mailto:dev@trafficcontrol.apache.org) mailing list that you intend to invoke lazy consensus after X hours with no feedback.
Review comment:
isn't that sort of implied with
> or feedback has stalled
> you intend to invoke lazy consensus after X hours with no feedback
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org