You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "kije (via GitHub)" <gi...@apache.org> on 2023/11/06 13:35:58 UTC

[I] [Bug] cannot export two connected charts with svg renderer / `getConnectedDataURL` broken with SVG renderer [echarts]

kije opened a new issue, #19278:
URL: https://github.com/apache/echarts/issues/19278

   ### Version
   
   5.4.3
   
   ### Link to Minimal Reproduction
   
   https://github.com/kije/echarts/commit/7969c3cd8ef9a92d2ea9d3d60f6e59e2f03fe00f
   
   ### Steps to Reproduce
   
   1. create two Echart instances with `svg` renderer
   2. connect them via `echarts.connect()`
   3. try to export the charts as `svg`
   
   ### Current Behavior
   
   When trying to export two connected charts with svg renderer, the following error occurs:
   
   ```console
   Uncaught TypeError: Cannot set properties of undefined (setting 'innerHTML')
       at ECharts.getConnectedDataURL (echarts.js:26673:49)
   ```
   
   The issue seems to be here
   https://github.com/apache/echarts/blob/fd9e62d7fdd88e95ddaf3c371353e8f6ca7d9e6a/src/core/echarts.ts#L874-L887
   
   
   Iv'e added some tests [in my fork here](https://github.com/kije/echarts/commit/7969c3cd8ef9a92d2ea9d3d60f6e59e2f03fe00f) that reproduce the issue.
   
   Might have been caused by [`[Feature] [svg] Refactor SVG renderer. Improved SVG rendering performance by 2x ~ 10x` in 5.3.0](https://github.com/apache/echarts/releases/tag/5.3.0)?
   
   
   ### Expected Behavior
   
   SVG export with SVG renderer of connected charts works and does not produce an error.
   
   ### Environment
   
   ```markdown
   - OS: Mac OS 14.0
   - Browser: Google Chrome 118.0.5993.117
   - Framework: -
   ```
   
   
   ### Any additional comments?
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


Re: [I] [Bug] cannot export two connected charts with svg renderer / `getConnectedDataURL` broken with SVG renderer [echarts]

Posted by "plainheart (via GitHub)" <gi...@apache.org>.
plainheart commented on issue #19278:
URL: https://github.com/apache/echarts/issues/19278#issuecomment-1797080818

   Link to #18028. This is a known issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


Re: [I] [Bug] cannot export two connected charts with svg renderer / `getConnectedDataURL` broken with SVG renderer [echarts]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #19278:
URL: https://github.com/apache/echarts/issues/19278#issuecomment-3499389702

   This issue has been automatically marked as stale because it did not have recent activity. It will be closed in 7 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


Re: [I] [Bug] cannot export two connected charts with svg renderer / `getConnectedDataURL` broken with SVG renderer [echarts]

Posted by "helgasoft (via GitHub)" <gi...@apache.org>.
helgasoft commented on issue #19278:
URL: https://github.com/apache/echarts/issues/19278#issuecomment-1796466122

   **bug confirmed** for ```type: 'svg'```.
   Works ok for default ```toolbox.feature.saveAsImage.type = 'png'```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org